ShuriZma
/
RetroArch
mirror of https://github.com/libretro/RetroArch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Makefiles: don't print info unconditionally 

The point of making the default "semi-silent" (each target is printed,
but not the entire invocation verbatim) was to factor out information
about invocation to a one-time target (info) and not repeating it ever
again. With V=1, the info target is silent, because each command
invocation will be printed verbatim, which needs no herald.

The undesired side effect of me introducing the info target and making
it a dependency of the default all target is that info doesn't respect
the --silent make option, so in this use case it was more noisy, not
less.

I believe the most elegant solution that satisfies all use cases is to
stop printing info unconditionally, and instead list it explicitly in
make invocations in CI, together with the all target. Then this info is
kept available for inspection from logs, but it's not repeated on each
invocation. The intention was to make the logs easier to read and scroll
in search for new compiler warnings.
This commit is contained in:
pstef 2025-04-29 18:36:48 +00:00
parent 54af661d95
commit 0c838c14e9
14 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -171,7 +171,7 @@ ifneq ($(MOC_HEADERS),)
RARCH_OBJ += $(MOC_OBJ) RARCH_OBJ += $(MOC_OBJ)
endif endif
all: info $(TARGET) config.mk all: $(TARGET) config.mk
define INFO define INFO
ASFLAGS: $(ASFLAGS) ASFLAGS: $(ASFLAGS)

2
Makefile.ctr
View File

@ -274,7 +274,7 @@ endif
.PHONY: $(BUILD) clean all .PHONY: $(BUILD) clean all
all: info $(TARGET) all: $(TARGET)
define INFO define INFO
AR: $(AR) AR: $(AR)

2
Makefile.dos
View File

@ -207,7 +207,7 @@ DEPENDS := $(filter-out libretro_libnx.a,$(DEPENDS_TMP))
#--------------------------------------------------------------------------------- #---------------------------------------------------------------------------------
# main targets # main targets
#--------------------------------------------------------------------------------- #---------------------------------------------------------------------------------
all: info $(OUTPUT) all: $(OUTPUT)
define INFO define INFO
CC: $(CC) CC: $(CC)

2
Makefile.miyoo
View File

@ -166,7 +166,7 @@ endif
RARCH_OBJ := $(addprefix $(OBJDIR)/,$(OBJ)) RARCH_OBJ := $(addprefix $(OBJDIR)/,$(OBJ))
all: info $(TARGET) all: $(TARGET)
define INFO define INFO
ASFLAGS: $(ASFLAGS) ASFLAGS: $(ASFLAGS)

2
Makefile.ngc
View File

@ -241,7 +241,7 @@ OBJOUT = -o
LINKOUT = -o LINKOUT = -o
LINK = $(CXX) LINK = $(CXX)
all: info $(EXT_TARGET) all: $(EXT_TARGET)
define INFO define INFO
CC: $(CC) CC: $(CC)

2
Makefile.orbis
View File

@ -182,7 +182,7 @@ endif
TARGETS := $(TARGET).self TARGETS := $(TARGET).self
all: info $(TARGETS) all: $(TARGETS)
define INFO define INFO
CC: $(CC) CC: $(CC)

2
Makefile.ps2
View File

@ -108,7 +108,7 @@ EE_INCS = $(INCDIR)
EE_BIN = $(TARGET).elf EE_BIN = $(TARGET).elf
EE_GPVAL = $(GPVAL) EE_GPVAL = $(GPVAL)
all: info $(EE_BIN) all: $(EE_BIN)
define INFO define INFO
EE_BIN: $(EE_BIN) EE_BIN: $(EE_BIN)

2
Makefile.psl1ght
View File

@ -130,7 +130,7 @@ ifneq ($(V),1)
Q := @ Q := @
endif endif
all: info $(SELF_TARGET) all: $(SELF_TARGET)
define INFO define INFO
CXX: $(CXX) CXX: $(CXX)

2
Makefile.retrofw
View File

@ -184,7 +184,7 @@ X-OD-NeedsDownscaling=true
endef endef
export DESKTOP_ENTRY export DESKTOP_ENTRY
all: info $(TARGET) opk all: $(TARGET) opk
define INFO define INFO
ASFLAGS: $(ASFLAGS) ASFLAGS: $(ASFLAGS)

2
Makefile.rs90
View File

@ -186,7 +186,7 @@ X-OD-NeedsDownscaling=true
endef endef
export DESKTOP_ENTRY export DESKTOP_ENTRY
all: info $(TARGET) opk all: $(TARGET) opk
define INFO define INFO
ASFLAGS: $(ASFLAGS) ASFLAGS: $(ASFLAGS)

2
Makefile.vita
View File

@ -201,7 +201,7 @@ TARGETS := $(TARGET).vpk
DEPFLAGS = -MT $@ -MMD -MP -MF $*.Tdepend DEPFLAGS = -MT $@ -MMD -MP -MF $*.Tdepend
POSTCOMPILE = mv -f $*.Tdepend $*.depend POSTCOMPILE = mv -f $*.Tdepend $*.depend
all: info $(TARGETS) all: $(TARGETS)
define INFO define INFO
ASFLAGS: $(ASFLAGS) ASFLAGS: $(ASFLAGS)

2
Makefile.webos
View File

@ -204,7 +204,7 @@ define APPINFO
endef endef
export APPINFO export APPINFO
all: info $(TARGET) ipk all: $(TARGET) ipk
define INFO define INFO
ASFLAGS: $(ASFLAGS) ASFLAGS: $(ASFLAGS)

2
Makefile.wii
View File

@ -273,7 +273,7 @@ OBJOUT = -o
LINKOUT = -o LINKOUT = -o
LINK = $(CXX) LINK = $(CXX)
all: info $(EXT_TARGET) all: $(EXT_TARGET)
define INFO define INFO
CC: $(CC) CC: $(CC)

2
Makefile.wiiu
View File

@ -302,7 +302,7 @@ endif
DEPFLAGS = -MT $@ -MMD -MP -MF $(BUILD_DIR)/$*.depend DEPFLAGS = -MT $@ -MMD -MP -MF $(BUILD_DIR)/$*.depend
all: info $(TARGETS) all: $(TARGETS)
define INFO define INFO
AR: $(AR) AR: $(AR)