From 0c838c14e99cab036387577de96a63f9a873dc5d Mon Sep 17 00:00:00 2001
From: pstef <3462925+pstef@users.noreply.github.com>
Date: Tue, 29 Apr 2025 18:36:48 +0000
Subject: [PATCH] Makefiles: don't print info unconditionally

The point of making the default "semi-silent" (each target is printed,
but not the entire invocation verbatim) was to factor out information
about invocation to a one-time target (info) and not repeating it ever
again. With V=1, the info target is silent, because each command
invocation will be printed verbatim, which needs no herald.

The undesired side effect of me introducing the info target and making
it a dependency of the default all target is that info doesn't respect
the --silent make option, so in this use case it was more noisy, not
less.

I believe the most elegant solution that satisfies all use cases is to
stop printing info unconditionally, and instead list it explicitly in
make invocations in CI, together with the all target. Then this info is
kept available for inspection from logs, but it's not repeated on each
invocation. The intention was to make the logs easier to read and scroll
in search for new compiler warnings.
---
 Makefile         | 2 +-
 Makefile.ctr     | 2 +-
 Makefile.dos     | 2 +-
 Makefile.miyoo   | 2 +-
 Makefile.ngc     | 2 +-
 Makefile.orbis   | 2 +-
 Makefile.ps2     | 2 +-
 Makefile.psl1ght | 2 +-
 Makefile.retrofw | 2 +-
 Makefile.rs90    | 2 +-
 Makefile.vita    | 2 +-
 Makefile.webos   | 2 +-
 Makefile.wii     | 2 +-
 Makefile.wiiu    | 2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/Makefile b/Makefile
index ca736ddab3..9d68f555d7 100644
--- a/Makefile
+++ b/Makefile
@@ -171,7 +171,7 @@ ifneq ($(MOC_HEADERS),)
     RARCH_OBJ += $(MOC_OBJ)
 endif
 
-all: info $(TARGET) config.mk
+all: $(TARGET) config.mk
 
 define INFO
 ASFLAGS: $(ASFLAGS)
diff --git a/Makefile.ctr b/Makefile.ctr
index ad4093bc9c..5ac5102b92 100644
--- a/Makefile.ctr
+++ b/Makefile.ctr
@@ -274,7 +274,7 @@ endif
 
 .PHONY: $(BUILD) clean all
 
-all: info $(TARGET)
+all: $(TARGET)
 
 define INFO
 AR: $(AR)
diff --git a/Makefile.dos b/Makefile.dos
index 2f36430112..18f716e91d 100644
--- a/Makefile.dos
+++ b/Makefile.dos
@@ -207,7 +207,7 @@ DEPENDS      := $(filter-out libretro_libnx.a,$(DEPENDS_TMP))
 #---------------------------------------------------------------------------------
 # main targets
 #---------------------------------------------------------------------------------
-all: info $(OUTPUT)
+all: $(OUTPUT)
 
 define INFO
 CC: $(CC)
diff --git a/Makefile.miyoo b/Makefile.miyoo
index 67c1b73d91..77cbfedd44 100644
--- a/Makefile.miyoo
+++ b/Makefile.miyoo
@@ -166,7 +166,7 @@ endif
 
 RARCH_OBJ := $(addprefix $(OBJDIR)/,$(OBJ))
 
-all: info $(TARGET)
+all: $(TARGET)
 
 define INFO
 ASFLAGS: $(ASFLAGS)
diff --git a/Makefile.ngc b/Makefile.ngc
index c733120fbf..a82230c738 100644
--- a/Makefile.ngc
+++ b/Makefile.ngc
@@ -241,7 +241,7 @@ OBJOUT   = -o
 LINKOUT  = -o
 LINK = $(CXX)
 
-all: info $(EXT_TARGET)
+all: $(EXT_TARGET)
 
 define INFO
 CC: $(CC)
diff --git a/Makefile.orbis b/Makefile.orbis
index b598f715e0..b5bd2f9bf4 100644
--- a/Makefile.orbis
+++ b/Makefile.orbis
@@ -182,7 +182,7 @@ endif
 
 TARGETS := $(TARGET).self
 
-all: info $(TARGETS)
+all: $(TARGETS)
 
 define INFO
 CC: $(CC)
diff --git a/Makefile.ps2 b/Makefile.ps2
index 1ffe0d1e95..ef5c905b8d 100644
--- a/Makefile.ps2
+++ b/Makefile.ps2
@@ -108,7 +108,7 @@ EE_INCS = $(INCDIR)
 EE_BIN = $(TARGET).elf
 EE_GPVAL = $(GPVAL)
 
-all: info $(EE_BIN)
+all: $(EE_BIN)
 
 define INFO
 EE_BIN: $(EE_BIN)
diff --git a/Makefile.psl1ght b/Makefile.psl1ght
index 6350e07cb4..cbff2b32ff 100644
--- a/Makefile.psl1ght
+++ b/Makefile.psl1ght
@@ -130,7 +130,7 @@ ifneq ($(V),1)
 	Q := @
 endif
 
-all: info $(SELF_TARGET)
+all: $(SELF_TARGET)
 
 define INFO
 CXX: $(CXX)
diff --git a/Makefile.retrofw b/Makefile.retrofw
index fc0a2ddffa..d3ecb0a008 100644
--- a/Makefile.retrofw
+++ b/Makefile.retrofw
@@ -184,7 +184,7 @@ X-OD-NeedsDownscaling=true
 endef
 export DESKTOP_ENTRY
 
-all: info $(TARGET) opk
+all: $(TARGET) opk
 
 define INFO
 ASFLAGS: $(ASFLAGS)
diff --git a/Makefile.rs90 b/Makefile.rs90
index 58492e5308..58323d3615 100644
--- a/Makefile.rs90
+++ b/Makefile.rs90
@@ -186,7 +186,7 @@ X-OD-NeedsDownscaling=true
 endef
 export DESKTOP_ENTRY
 
-all: info $(TARGET) opk
+all: $(TARGET) opk
 
 define INFO
 ASFLAGS: $(ASFLAGS)
diff --git a/Makefile.vita b/Makefile.vita
index ec94f0cbca..c4691300e6 100644
--- a/Makefile.vita
+++ b/Makefile.vita
@@ -201,7 +201,7 @@ TARGETS := $(TARGET).vpk
 DEPFLAGS    = -MT $@ -MMD -MP -MF $*.Tdepend
 POSTCOMPILE = mv -f $*.Tdepend $*.depend
 
-all: info $(TARGETS)
+all: $(TARGETS)
 
 define INFO
 ASFLAGS: $(ASFLAGS)
diff --git a/Makefile.webos b/Makefile.webos
index 4ca35b420c..f774f23505 100644
--- a/Makefile.webos
+++ b/Makefile.webos
@@ -204,7 +204,7 @@ define APPINFO
 endef
 export APPINFO
 
-all: info $(TARGET) ipk
+all: $(TARGET) ipk
 
 define INFO
 ASFLAGS: $(ASFLAGS)
diff --git a/Makefile.wii b/Makefile.wii
index f25ebff1a7..193036f282 100644
--- a/Makefile.wii
+++ b/Makefile.wii
@@ -273,7 +273,7 @@ OBJOUT   = -o
 LINKOUT  = -o
 LINK = $(CXX)
 
-all: info $(EXT_TARGET)
+all: $(EXT_TARGET)
 
 define INFO
 CC: $(CC)
diff --git a/Makefile.wiiu b/Makefile.wiiu
index ee66630887..47552d31a7 100644
--- a/Makefile.wiiu
+++ b/Makefile.wiiu
@@ -302,7 +302,7 @@ endif
 
 DEPFLAGS    = -MT $@ -MMD -MP -MF $(BUILD_DIR)/$*.depend
 
-all: info $(TARGETS)
+all: $(TARGETS)
 
 define INFO
 AR: $(AR)