Commit Graph

291 Commits

Author SHA1 Message Date
adelikat c731e1168e Revert "Fix nullability warnings in PathExtensions"
This reverts commit f022954554.
2020-03-19 08:50:45 -05:00
YoshiRulz f022954554
Fix nullability warnings in PathExtensions
Definitely not happy with any of this
2020-03-19 15:23:01 +10:00
adelikat d953318160
Remove cbuffer (#1883)
* delete unused ShortBuffer

* convert IntBuffer to int[] in the Atari2600 core

* remove IntBuffer from NES mappers, and delete class

* convert ByteBuffer to byte[] in atari 2600 mappers

* remove ByteBuffer usages in NESHawk, remove ByteBuffer class

* remove Buffer.cs

* remove IDisposable from NES.NESBoardBase

* remove Dispose from Atari2600 MapperBase, note, it wasn't event being called
2020-03-18 08:55:02 -05:00
adelikat e16dc33722 move some PathManager methods to a PathUtils class in BizHawk.Common 2020-03-15 15:59:10 -05:00
adelikat 9fa4bac8d4 Path extensions - address nullability in a few places 2020-03-15 15:47:12 -05:00
adelikat 33a14327b7 move most logic from PathManager to extension methods in BizHawk.Common 2020-03-15 15:45:11 -05:00
adelikat 348cbd18df
Remove PathManager code that had dependencies on Globals (#1881)
* move one usage of Firwmare method into Firmware config where it is better suited

* PathManager - remove unused code

* move some PathEntry specific logic out of PathManger and into PathEntryCollection extension methods

* PathManager - detangle some exe pathing logic from Global.Config usage, clarify what a completely broken method should actuall do

* move more logic from PathManager to PathEntryCollection extension method

* move absolute path creation to PathEntryCollection, lots of refactoring and simplifying of PathEntries usage

* simplify PathEntryColleciton usage more

* simplify PathEntryCollection more

* break PathEntry classes into separate files, a bit of cleanup

* move Rom path logic out of PathManager into PathEntryCollectionExtensions

* move config UseRecentForRoms and LastRomPath into PathEntries, note that this is a breaking change for previous configs, those values will revert back to default values

* move SaveRamPath logic from PathManager to PathEntryCollections

* move cheats path logic from PathManager to PathEntryCollection

* move another method out of PathManager

* move some Retro hacks to PathEntryCollections, exposes more implicit dependencies

* move savestate logic out of PathManager to PathEntryCollection

* move more logic out of PathManager

* move some savestate logic out of PathManager, move most to MainForm where it is used, detangle some implicit dependencies from SaveSlotManager

* rename method

* move more logic from PathManager to PathCollectionEntry

* movie final Global.Config.PathEntries logic out of PathManager and into PathEnties
2020-03-15 15:12:36 -05:00
adelikat 888a5225fe create an OrderBy() overload that does OrderBy or OrderByDesc, and use it to simplify sorting in RamSearchEngine (can be used to simplify other things like CheatList) 2020-03-04 18:40:26 -06:00
adelikat 46d05de51f nothing to see here 2020-02-28 12:52:48 -06:00
YoshiRulz 848eaabf46
Move CWD hacks to own class 2020-02-28 13:26:14 +10:00
James Groom c9d20426d3
Cleanup HawkFile (#1865) 2020-02-27 17:41:07 -06:00
YoshiRulz 71e3dbf6bc Replace RangeStruct with ValueTuple, add deconstruction for Range 2020-02-27 04:34:31 +00:00
adelikat f5e9e8eecd cleanup VersionInfo.cs a bit 2020-02-26 15:33:50 -06:00
adelikat e744511573 misc cleanups 2020-02-25 15:14:14 -06:00
adelikat 72d4b0ac46 use inline out 2020-02-25 15:14:13 -06:00
YoshiRulz 2b8c0edcc2
Reorganise *.props 2020-02-23 06:17:35 +10:00
adelikat 9e7bdd2424 cleanups in Bizware, mostly higher language features like null propagation and expression bodies 2020-02-22 12:02:40 -06:00
YoshiRulz be60911ff9
Cleanup StringExtensions 2020-02-19 08:26:08 +10:00
YoshiRulz 3afcf416e8
Follow attribute class best practices, cleanup docs on attributes 2020-02-19 03:54:50 +10:00
zeromus 4617476bcd SharpCompressArchiveHandler: throw fewer exceptions 2020-02-09 23:27:09 -05:00
adelikat d7f97b1539 actually delete things instead of removing them from the project 2020-02-08 13:09:27 -06:00
YoshiRulz 2c74b1a693
Properly fix assembly loading issue, retarget BizHawk.Common again
temp fix was 9ffef2531
2020-01-29 00:23:10 +10:00
YoshiRulz 215de3c0c0
Make Roslyn Analyzers opt-in at compile-time (resolves #1813)
They are still run by the IDE at design-time. To opt-in, set the MSBuild
property MachineRunAnalyzersDuringBuild. From the command-line, you can do this
by adding `/p:MachineRunAnalyzersDuringBuild=true`.
2020-01-26 10:34:07 +10:00
adelikat 9ffef2531d put BizHawk.Common back to framework for now, fixes Enum properties used in the PropertyGrid throwing exceptions about not being able to find System.ComponentModel 2020-01-25 15:37:27 -06:00
YoshiRulz 6f3f01125c
Enable SA1504 and fix noncompliance
"All accessors should be single-line or multi-line"
i.e. no block form on one line
2020-01-25 14:56:56 +10:00
YoshiRulz bfde89b9f3
Enable SA1139 and fix noncompliance
"Use literal suffix notation instead of casting"
2020-01-25 07:55:48 +10:00
YoshiRulz 4ed402fc59
Cleanup some more files 2020-01-24 09:37:15 +10:00
YoshiRulz 3ae58fd9d6
Use SolutionDir to make relative paths absolute
No need for warning of relative paths in filename anymore
2020-01-24 04:59:27 +10:00
YoshiRulz 3537c516fb
Configure StyleCop (not running) and revert using-inside-namespace 2020-01-24 04:40:46 +10:00
YoshiRulz 751ef54f4f
Fix typo in ToFloatBuffer 2020-01-23 15:54:26 +10:00
YoshiRulz abba7fbb78
Cleanup Ranges and SimpleTime 2020-01-23 15:53:19 +10:00
YoshiRulz ff2efca658
Cleanup Util 2020-01-23 14:54:34 +10:00
YoshiRulz 8de0355228
Prepare for nullability annotation in BizHawk.Common
attributes: https://docs.microsoft.com/en-us/dotnet/csharp/nullable-attributes
2020-01-23 14:54:29 +10:00
YoshiRulz 97cb9b47f1
Retarget BizHawk.Common to .NET Standard 2.0 2020-01-23 14:54:26 +10:00
YoshiRulz c7801b8ce2
Move BizHawk.Common.BizInvoke namespace to separate project 2020-01-23 14:54:23 +10:00
YoshiRulz 5a3f4ab1b3
Use File.Copy in InstanceDll instead of manipulating streams 2020-01-23 14:54:13 +10:00
YoshiRulz 7e727fc77c
Move CRC32, remove unused project dependencies 2020-01-22 05:49:18 +10:00
YoshiRulz b1ef7bcbbb
Retarget .NET Framework from 4.6.1 to 4.8 2020-01-21 04:42:09 +10:00
YoshiRulz e435fb807b
Migrate to "new csproj", remove unnecessary tags/info, and dedupe
Didn't want to mess with resource generation so the execuable projects didn't
get migrated, just cleaned up
2020-01-19 01:43:39 +10:00
YoshiRulz 1c3e823ea2
Allow immutable=>immutable range copy 2020-01-17 06:33:43 +10:00
YoshiRulz 4a5ece2076
Use ranges in MemoryBlock* 2020-01-03 23:35:07 +10:00
YoshiRulz d71b7af31c
Change exceptions in ranges 2020-01-03 21:52:59 +10:00
YoshiRulz dbe82f6d86
Implement "fancy math", scrap RangeImpl, fix typos, and cleanup 2020-01-03 06:03:49 +10:00
YoshiRulz e7d0fb8299
Refactor/genericise MutableIntRange, add immmutables, add more methods
call now and I'll throw in not one but two float equality extensions for free
2020-01-03 03:32:51 +10:00
YoshiRulz 19705b78fd
Improve exception docs in BizHawk.Common 2020-01-02 21:51:14 +10:00
adelikat 0082de7c0a cleanup Quantizer.cs 2019-12-31 10:24:57 -06:00
adelikat bdd0d56a70 delete the console log window, always show LogWindow instead 2019-12-29 14:39:44 -06:00
YoshiRulz 264b27475e
Fix default referring to non-nullable type 2019-12-23 04:12:02 +10:00
YoshiRulz 7cd29c0f54
Finish moving Win32 imports to BizHawk.Common, organise, and cleanup 2019-12-21 18:33:11 +10:00
YoshiRulz 580aa2eaf9
Refactoring and cleanup of dynamic lib loading
Also fixed error reporting in WindowsLLManager, and fixed bug in
MednaDisc.CheckLibrary
2019-12-21 18:22:58 +10:00