846253760e
Extract more helpers for finding Lua forms/controls by handle
2024-08-25 03:49:57 +10:00
b69e466c03
Extract constant in `FormsLuaLibrary`
2024-08-25 03:39:29 +10:00
a1faf8bf0a
Speed up `forms.*` by knowing that form/control handles are unique
2024-08-25 03:39:13 +10:00
170d1a62ed
Add warning message for Lua functions called with mismatched x/y/w/h
2024-08-25 03:39:02 +10:00
884fee6c6d
Encapsulate x/y/w/h checks in `FormsLuaLibrary`
2024-08-25 03:39:02 +10:00
ecaece0488
Fix Lua forms having a blank title when not specified
2024-08-25 03:39:01 +10:00
c3057298f9
Fix `forms.destroyall` not clearing the list
2024-08-25 03:39:01 +10:00
681a5764d6
Fix LuaPictureBox functions only working on the first form
...
fixes 672536305
2024-08-25 03:38:58 +10:00
bda40c7ba3
Dedup `forms.{drawString,drawText}` implementations
2024-08-25 03:38:41 +10:00
b99a3831e9
Change return type of `BootGodDb.Identify` to `IReadOnlyList`
2024-08-23 16:51:40 +10:00
fc446868a7
Fix `BootGodDb.Identify` mutating lookup
...
fixes f010d6f80633216be1
2024-08-23 16:45:44 +10:00
8c9587e00b
Fix BootGodDB lookup being completely broken in quicknes
...
- closes #3703
Presumably broken since e38726db50
2024-08-22 23:15:20 +02:00
f010d6f802
Fix bootgod exception on missing game hash
...
fixes 633216be14
2024-08-22 22:54:21 +02:00
7dfb624427
Remove `WorkingDictionary<K, V>`
2024-08-23 02:53:30 +10:00
34d71e90bc
Add more `GetValueOrDefault` overloads
2024-08-23 02:53:30 +10:00
72b2e78957
Refactor `AutoFireStickyXorAdapter.IncrementLoops`
2024-08-23 02:49:47 +10:00
5dd3dc7ae5
Refactor `AutofireController.{IsPressed,LatchFromPhysical}`
2024-08-23 02:49:47 +10:00
384e4c913c
Short-circuit loops in `{,Autofire}Controller.LatchFromPhysical`
2024-08-23 02:49:47 +10:00
633216be14
Remove `Bag<K, V>`
2024-08-23 02:48:03 +10:00
ba4c406a36
Add names to bool argument in `TAStudio.StartNewMovieWrapper` calls
...
fixes b6a0688be
2024-08-22 22:44:14 +10:00
325880be18
Further cleanups to `MainForm.ProcessInput`
...
fixes 2f5dfcea3
2024-08-22 22:40:42 +10:00
2f5dfcea33
simplify variable assignment
2024-08-22 13:34:39 +02:00
17733e38f7
Check all individual buttons with input key priority
...
- closes #3842
If any of the pressed buttons is an input, don't trigger any hotkeys.
2024-08-22 13:33:56 +02:00
f07c689c58
Improve horizontal TAStudio layout a bit
...
see #3708
2024-08-22 01:30:46 +02:00
b6a0688be0
simplify TAStudio movie starting
...
- removes HandleMovieLoadStuff, which should ™️ not be necessary
- pass newMovie parameter into MainForm.StartNewMovie. This is currently probably irrelevant, but useful later
2024-08-21 22:24:39 +02:00
1c44dc5913
don't create undo steps when setting TasMovie.StartsFromSavestate
...
A movie either starts from a savestate, or doesn't. It should not be possible to undo the marker changes done when setting this value.
2024-08-21 22:12:32 +02:00
c2a336647c
Use `Type.EmptyTypes` in `MovieImport.ImportFile`
2024-08-21 22:15:14 +10:00
4e85a71d53
HexEditor "File on Disk" fixes (squashed PR #3998 )
...
* Fix keeping rom domain selected
* Turn unnecessary field into local
* Handle `null` return from `GetRomBytes()`
* Simplify `GetRomBytes()`
* Add try-catch around opening rom file
2024-08-21 15:59:39 +10:00
b9cd4a93cc
Remove unneeded modifer
2024-08-20 15:23:36 -07:00
02acd542c2
Guard against cheat codes in RetroAchievements' hardcore mode
...
originally I thought just blocking the cheat window would be enough, but autoloaded cheat codes could sneak through. An actual check for cheat codes being active prevents this being an issue.
2024-08-20 15:22:39 -07:00
beab2b141b
Only force a core name if one exists
...
This could actually not be the case for imported movies for example and is handled elsewhere, but this force parameter breaks rom loading completely when QueuedCoreName is empty.
2024-08-20 23:10:38 +02:00
cdd7ee1fea
Improve missing firmware dialog readability
...
see comment here: https://github.com/TASEmulators/BizHawk/issues/3980#issuecomment-2269483563
2024-08-20 23:09:16 +02:00
8d4c29a64f
ensure updated core settings are always saved in config
...
- closes #3966
2024-08-18 23:12:24 +02:00
3ede77b8b7
Change OnMovieEnd default to 'Pause' instead of 'Finish' ( #4008 )
2024-08-18 18:45:04 +03:00
d9331c5a28
Add feature flag to disable the gamedb
2024-08-18 16:21:51 +10:00
c319bf5fb8
Fix LINQ chain in `FirmwareManager.DoScanAndResolve`
...
fixes 963b925a1
2024-08-18 16:09:31 +10:00
963b925a1a
prefer ideal firmware over acceptable firmware
...
see #3974
2024-08-18 03:30:31 +02:00
fa08002fbf
don't set quickNES's priority to low
...
it's the preferred core after all, this doesn't make sense
2024-08-18 03:28:56 +02:00
92399482d4
also search in descriptions in the lua functions filter
...
- closes #3651
2024-08-18 02:46:57 +02:00
e893e3a1ff
Cleanup CueFileResolver
...
also closes #3532
2024-08-18 02:38:23 +02:00
7c89bda312
update displaymanager on rom load failure
2024-08-17 22:26:10 +02:00
9085bd6e0c
Set correct GameInfo even when rom loading failed
...
- closes #3986
(maybe this should be in CloseGame as well?)
2024-08-17 22:25:55 +02:00
5ee53db53b
Nix expr: Expose Mono's profiler
2024-08-17 18:17:00 +10:00
07508a91f2
Nix expr: Remove TODO which has been resolved
2024-08-17 18:11:11 +10:00
60366c13b5
Fix signature of `IMemoryApi.WriteFloat`
2024-08-16 22:49:35 +10:00
70b640240e
Simplify boolean comparison
...
this was getting flagged in CI but not on my machine
2024-08-16 21:09:38 +10:00
6b160d9bd0
Revert RAM Search refactor (PR #3954 )
...
reverts 1a9e5e52f1
2024-08-15 01:57:47 +10:00
0f22ef2ad0
Revert "Change ToRawInt to ToRawUInt"
...
This reverts commit 542e043261
2024-08-15 01:53:59 +10:00
0184bcd0af
Restore numeric values for `PreviousType` enum
...
fixes 1a9e5e52f
2024-08-14 00:38:12 +10:00
ab7f379e74
Correct rewind dialog typo
2024-08-09 19:41:52 +10:00
YoshiRulz