10bceeb0dc
Nope, I think it's a good idea now.
...
Revert "This reverts commit c878c85daeaaf0cae3e28f24bc1a8b511293d7b6."
This reverts commit 1d1f2a18c6
2020-04-23 21:20:59 -04:00
1d1f2a18c6
This reverts commit c878c85dae.
2020-04-23 21:06:12 -04:00
c878c85dae
for your consideration: sync settings return flags instead of a bool, so we can have more granularity in what needs resetting than just "reboot core". for instance, we would like to minimize the number of times the window layout is redone by not doing it when the screen settings havent changed. HOWEVER, while I was writing this commit message, I realized, I should probably do it just by being more cautious in kicking off the layout (unless the data coming from the core has changed, a layout shouldnt happen). So I am going to make this commit, in case it inspires anyone, and then revert it.
2020-04-23 21:05:56 -04:00
325551ecd0
consistently check if callbacks exist before calling memory callbacks, across all cores
2020-04-21 16:42:57 -05:00
3c638f018f
refactor CoreComm usage in remaining cores
2020-03-15 09:44:47 -05:00
3afcf416e8
Follow attribute class best practices, cleanup docs on attributes
2020-02-19 03:54:50 +10:00
606c3bf1c2
use more advanced language features in Emulation.Cores ( #1852 )
...
* Use expression bodies in Emulation.Cores, and a few other misc cleanups
* remove unused usings in Emulation.Common
* cleanups in Tables_Direct.cs
* some cleanups in nes boards - redundant code
* remove some redundant array initializers in Emulation.Cores
* cleanup AmstradCPC.Controllers
* use object initializers in a lot of places
* nes mappers - remove disch's notes comments in favor of the nesdev wiki link
* cleanup CdtConverter.cs, mostly use of object initializers
* remove redundant .ToString() calls in Emulation.Cores
* using var in Emulation.Cores
* AmstradCPC/ZXSpectrum - simplify some linq, tabs instead of spaces, a few other misc cleanups
* Use null-propagation in Emulation.Cores
2020-02-17 16:54:51 -06:00
4b7a7dd293
Make Binary states default and Textstates opt-in for cores ( #1848 )
...
* Rewind & State config - remove the default option
* remove the savestate type of default, not that this is a breaking config change for anyone that had specifically set savestates to text
* remove BinaryStatesPreferred from IStatable and use config setting when starting movies from "Now" in record movie dialog
* remove BinaryStatesPreferred from cores
* make text savestates an extension method off of IStatable and an inteface ITextStatable it uses if the core implements it. This will allow cores to opt in to text states if desired
* make cores with actual text savestate impleemntations get ITextStatable, remove text state logic from cores that just have a binary as as text implementation
2020-02-15 10:22:26 -06:00
9d4ef3a3af
cleanup WonderSwan.ISettable
2020-02-08 11:23:58 -06:00
b1e02fbdce
Enable SA1106 and fix noncompliance
...
"Code should not contain empty statements"
i.e. don't put a semicolon there
2020-01-25 18:06:34 +10:00
f83261c116
misc cleanups in emulator core service logic
2020-01-11 13:19:51 -06:00
fef746dffa
properly dispose of IDisposables in core savestate code, and a few other places
2019-12-06 17:33:17 -06:00
067477ce18
Merge branch 'master' into clean_docs
2019-06-14 13:28:39 +00:00
2c6ecb68bd
Merge branch 'master' into brian/mem_callback_addr_value
2019-06-06 02:11:04 -07:00
d41bd867b8
flags
2019-06-06 02:04:47 -07:00
2642ef4049
Remove empty docs
2019-06-06 16:41:10 +10:00
4e91f88af3
Use nameof in cores
2019-03-28 14:18:58 +11:00
a8f293eec8
Call mem callbacks with addr, value
2019-01-24 03:23:21 -08:00
c19c7cd5c3
SubNESHawk
...
also Input register shift fix
# Conflicts:
# BizHawk.Client.EmuHawk/MainForm.Designer.cs
# BizHawk.Client.EmuHawk/MainForm.Events.cs
# BizHawk.Emulation.Cores/Computers/AmstradCPC/AmstradCPC.IEmulator.cs
# BizHawk.Emulation.Cores/Computers/SinclairSpectrum/ZXSpectrum.IEmulator.cs
# BizHawk.Emulation.Cores/Consoles/Nintendo/NES/PPU.run.cs
2019-01-10 18:25:59 +03:00
e8145af463
i hope this breaks something
2018-05-12 12:55:42 -04:00
cd289c474e
memorycallbacks with domains - Phase 2 - change api to Call methods and refactor accordingly, everything should behave as it was before the refactor at this point. No cores have yet to be implemented with domains other than the default bus they already had
2017-08-03 18:08:07 -05:00
04ce66c397
phase 1 of changing memory callback api to specify domain - require cores to specify which domains are available and have the domain passed in when creating callbacks. Still todo - cores need to pass in domain name on CallReads/Writes/Executes methods
2017-08-01 22:05:17 -05:00
c6e0e9fa57
Rename CoreAttributes to CoreAttribute as to not be a bad person
2017-07-12 14:10:55 -05:00
2dd10ea951
Update some author meat-a deet-a
2017-07-09 12:18:33 -04:00
1dae91e6a8
clean up core constructors - consistent parameter casing, and put them at the top of the class
2017-05-05 19:05:36 -05:00
59139ab266
Spell out Numerator and Denominator
2017-05-05 11:25:38 -05:00
62a13d961d
Move VsyncNum and VsyncDen out of CoreComm and into IVideoProvider
2017-05-05 11:21:37 -05:00
698c6741ae
Refactor IEmulator and remove the IController property, instead pass it as a paramter to the FrameAdvance() method
2017-05-01 20:09:11 -05:00
e1750bdce9
Move BinaryQuickSerializer from Emulation.Common to Common
2017-05-01 17:26:39 -05:00
ded1c2d7b7
Break off BoardName from IEmulator into a separate IBoardInfo service
2017-04-30 21:01:54 -05:00
3192cc70ae
slight refactor to IEmulator - make the IController property set only to more clearly express the client -> core relationship
2017-04-26 19:09:00 -05:00
54ebe75d2b
remove the obsolete MemoryDomain.FromIntPtr method
2017-04-24 13:47:40 -05:00
ab1a22bf31
add TotalExecutedCycles as an IDebuggable property, and implement it in cores with the information readily available (and throw NotImplementedExecptions in the remaining). wire the property up to lua with emu.totalexecutedcycles(). Stil todo - wire it up to the Debugger gui
2017-01-09 19:23:05 -06:00
72a59087b5
Use the IController indexing property less in preparation for removing it from the interface. Replaced with its more explicity counter-part .IsPressed()
2016-12-14 12:42:15 -06:00
b73a500d6b
Major sound provider refactor. Create a unified interface ISoundProvider, that is an IEmulator service and break it off of IEmulator. IAsyncSoundProvider was kept as a shim for now, for legacy cores that were inherintly async.
2016-12-11 11:15:00 -06:00
b697110098
Rename ISoundProvider to IAsyncSoundProvider to more accurately describe what the service does
2016-12-09 10:24:43 -06:00
66abc95c58
Wonderswan - Support settings to change colors. Breaks existing binary savestates (existing text savestates should be OK). B&W palette is exposed as a setting, albeit without a very nice UI. Color palette is available behind the scenes, but is not exposed as a setting.
2016-03-26 13:35:57 -04:00
ef1bc65ce6
IInputPollable - Make IsLagFrame settable
2016-01-26 11:34:42 +01:00
ba21484ddd
add IRegionable as an emulator service to indicate NTSC vs PAL, etc. Refactor cores that conveyed this information to use this service, fixed cheaty reflection to grab this info to use the service instead, marked some cores as region not applicable where it made sense to me (I'm sure I'm wrong in some cases)
2015-08-05 20:12:09 -04:00
3541c9e975
Make the lag counter settable, and expose this functionality in lua
2015-07-09 13:05:30 -04:00
5bcdfb5991
IInputPollable - remove the set on LagCount as it is not needed
2015-06-11 01:23:14 +00:00
ac442130ae
Refactor IMemoryDomains and MemoryDomains to have setters for MainMemory and SystemBus, so a core can customize instead of using a one size fits all assumption. Remove constructor that sets main memory and refactor accordingly
2015-01-24 16:02:28 +00:00
82fcd0bc5e
refactor IVideoProvider into a service. uses in mainform and friends are still hacky
2015-01-14 22:37:37 +00:00
8b60e74b87
swan: factor out some stuff into seperate files
2015-01-14 22:00:46 +00:00
fbdb29b64c
refactor IMemorydomains to be a domain list instead of having a domain property, refactor cores to register an IMemoryDomains instead of being one
2015-01-14 21:55:48 +00:00
b432069504
wonderswan: factor out some stuff into seperate files
2015-01-13 22:29:06 +00:00
d62ba4e2b4
Change IMemoryDomains to have an IMemoryDomainList instead of a MemoryDomainList, this is an incremental step into eventually having IMemoryDomains take over the properties of IMemoryDomainList, still todo: reduce the amount of needed functionality in IMemoryDomainList from old and not good code
2015-01-13 22:18:07 +00:00
0f2197cec1
Break off ITracer from IDebuggable, rename to ITraceable and make it an IEmulatorService, refactor things accordingly
2014-12-23 01:58:12 +00:00
ffdeb618f7
IDebugable - add a CanStep() method, and implement it in all IDebuggable implementations
2014-12-20 13:29:57 +00:00
a8116297a0
Rename Register to RegisterValue
2014-12-20 13:16:15 +00:00
zeromus