Change IMemoryDomains to have an IMemoryDomainList instead of a MemoryDomainList, this is an incremental step into eventually having IMemoryDomains take over the properties of IMemoryDomainList, still todo: reduce the amount of needed functionality in IMemoryDomainList from old and not good code

BizHawk.Client.Common/lua/EmuLuaLibrary.Memory.cs

@@ -60,6 +60,7 @@ namespace BizHawk.Client.Common
 		public LuaTable GetMemoryDomainList()
 		{
 			var table = Lua.NewTable();
+
 			for (int i = 0; i < DomainList.Count; i++)
 			{
 				table[i] = DomainList[i].Name;

BizHawk.Client.Common/lua/LuaMemoryBase.cs

@@ -24,7 +24,7 @@ namespace BizHawk.Client.Common
 
 		protected abstract MemoryDomain Domain { get; }
 
-		protected MemoryDomainList DomainList
+		protected IMemoryDomainList DomainList
 		{
 			get
 			{

BizHawk.Client.EmuHawk/Extensions/ToolExtensions.cs

@@ -218,7 +218,7 @@ namespace BizHawk.Client.EmuHawk.ToolExtensions
 			Global.CheatList.RemoveRange(watches.Where(watch => !watch.IsSeparator));
 		}
 
-		public static IEnumerable<ToolStripItem> MenuItems(this MemoryDomainList domains, Action<string> setCallback, string selected = "", int? maxSize = null)
+		public static IEnumerable<ToolStripItem> MenuItems(this IMemoryDomainList domains, Action<string> setCallback, string selected = "", int? maxSize = null)
 		{
 			foreach (var domain in domains)
 			{

BizHawk.Client.EmuHawk/tools/Debugger/BreakpointControl.cs

@@ -18,7 +18,7 @@ namespace BizHawk.Client.EmuHawk.tools.Debugger
 		public IDebuggable Core { get; set; }
 		public IMemoryCallbackSystem MCS { get; set; }
 		public GenericDebugger ParentDebugger { get; set; }
-		public MemoryDomainList MemoryDomains { get; set; }
+		public IMemoryDomainList MemoryDomains { get; set; }
 		private readonly BreakpointList Breakpoints = new BreakpointList();
 
 		public BreakpointControl()

BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.IToolForm.cs

@@ -18,7 +18,7 @@ namespace BizHawk.Client.EmuHawk
 
 		private IMemoryCallbackSystem MemoryCallbacks { get { return Debuggable.MemoryCallbacks; } }
 
-		private MemoryDomainList MemoryDomains { get { return MemoryDomainSource.MemoryDomains; } }
+		private IMemoryDomainList MemoryDomains { get { return MemoryDomainSource.MemoryDomains; } }
 
 		private uint PC
 		{

BizHawk.Client.EmuHawk/tools/GB/GBGameGenie.cs

@@ -19,7 +19,7 @@ namespace BizHawk.Client.EmuHawk
 		[RequiredService]
 		private IMemoryDomains MemoryDomainSource { get; set; }
 
-		private MemoryDomainList MemoryDomains { get { return MemoryDomainSource.MemoryDomains; } }
+		private IMemoryDomainList MemoryDomains { get { return MemoryDomainSource.MemoryDomains; } }
 
 		private readonly Dictionary<char, int> _gameGenieTable = new Dictionary<char, int>();
 		private bool _processing;

BizHawk.Client.EmuHawk/tools/Genesis/GenGameGenie.cs

@@ -26,7 +26,7 @@ namespace BizHawk.Client.EmuHawk
 
 		[RequiredService]
 		private IMemoryDomains MemoryDomainService { get; set; }
-		private MemoryDomainList MemoryDomains { get { return MemoryDomainService.MemoryDomains; } }
+		private IMemoryDomainList MemoryDomains { get { return MemoryDomainService.MemoryDomains; } }
 
 		private readonly Dictionary<char, int> _gameGenieTable = new Dictionary<char, int>
 		{

BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.cs

@@ -24,7 +24,7 @@ namespace BizHawk.Client.EmuHawk
 	{
 		[RequiredService]
 		private IMemoryDomains MemoryDomainSource { get; set; }
-		private MemoryDomainList MemoryDomains { get { return MemoryDomainSource.MemoryDomains; } }
+		private IMemoryDomainList MemoryDomains { get { return MemoryDomainSource.MemoryDomains; } }
 
 		[RequiredService]
 		private IEmulator Emulator { get; set; }

BizHawk.Client.EmuHawk/tools/NES/NESGameGenie.cs

@@ -16,7 +16,7 @@ namespace BizHawk.Client.EmuHawk
 
 		[RequiredService]
 		private IMemoryDomains MemoryDomainService { get; set; }
-		private MemoryDomainList MemoryDomains { get { return MemoryDomainService.MemoryDomains; } }
+		private IMemoryDomainList MemoryDomains { get { return MemoryDomainService.MemoryDomains; } }
 
 		private readonly Dictionary<char, int> _gameGenieTable = new Dictionary<char, int>
 		{

BizHawk.Client.EmuHawk/tools/PCE/PCECDL.cs

@@ -37,7 +37,7 @@ namespace BizHawk.Client.EmuHawk
 			}
 		}
 
-		private MemoryDomainList MemoryDomains { get { return _emu.MemoryDomains; } }
+		private IMemoryDomainList MemoryDomains { get { return _emu.MemoryDomains; } }
 
 		private string _currentFileName = string.Empty;
 

BizHawk.Client.EmuHawk/tools/SNES/SNESGameGenie.cs

@@ -16,7 +16,7 @@ namespace BizHawk.Client.EmuHawk
 		[RequiredService]
 		public LibsnesCore Emulator { get; set; }
 
-		private MemoryDomainList MemoryDomains { get { return Emulator.MemoryDomains; } }
+		private IMemoryDomainList MemoryDomains { get { return Emulator.MemoryDomains; } }
 
 		// including transposition
 		// Code: D F 4 7 0 9 1 5 6 B C 8 A 2 3 E

BizHawk.Emulation.Common/Interfaces/IMemoryDomains.cs

@@ -1,4 +1,5 @@
-namespace BizHawk.Emulation.Common
+using System.Collections.Generic;
+namespace BizHawk.Emulation.Common
 {
 	public interface IMemoryDomains : IEmulatorService
 	{
@@ -10,6 +11,17 @@
 		/// Other chips, and ram spaces can be added as well.
 		/// Subdomains of another domain are also welcome.
 		/// The MainMemory identifier will be 0 if not set
-		MemoryDomainList MemoryDomains { get; }
+		IMemoryDomainList MemoryDomains { get; }
+	}
+
+	public interface IMemoryDomainList : IList<MemoryDomain>
+	{
+		MemoryDomain this[string name] { get; }
+
+		MemoryDomain MainMemory { get; }
+
+		bool HasCheatDomain { get; }
+
+		MemoryDomain CheatDomain { get; }
 	}
 }

BizHawk.Emulation.Common/MemoryDomain.cs

@@ -184,7 +184,7 @@ namespace BizHawk.Emulation.Common
 		}
 	}
 
-	public class MemoryDomainList : ReadOnlyCollection<MemoryDomain>
+	public class MemoryDomainList : ReadOnlyCollection<MemoryDomain>, IMemoryDomainList
 	{
 		private readonly int _mainMemoryIndex;
 

BizHawk.Emulation.Cores/CPUs/HuC6280/CDL.cs

@@ -52,7 +52,7 @@ namespace BizHawk.Emulation.Cores.Components.H6280
 			w.Flush();
 		}
 
-		public void Disassemble(Stream s, MemoryDomainList mem)
+		public void Disassemble(Stream s, IMemoryDomainList mem)
 		{
 			var w = new StreamWriter(s);
 			w.WriteLine("; Bizhawk CDL Disassembly");

BizHawk.Emulation.Cores/Calculator/TI83.IMemoryDomains.cs

@@ -5,7 +5,7 @@ namespace BizHawk.Emulation.Cores.Calculators
 {
 	public partial class TI83 : IMemoryDomains
 	{
-		public MemoryDomainList MemoryDomains
+		public IMemoryDomainList MemoryDomains
 		{
 			get { return _memoryDomains; }
 		}

BizHawk.Emulation.Cores/Computers/Commodore64/C64.IMemoryDomains.cs

@@ -5,7 +5,7 @@ namespace BizHawk.Emulation.Cores.Computers.Commodore64
 {
 	public partial class C64 : IMemoryDomains
 	{
-		public MemoryDomainList MemoryDomains
+		public IMemoryDomainList MemoryDomains
 		{
 			get { return memoryDomains; }
 		}

BizHawk.Emulation.Cores/Consoles/Atari/2600/Atari2600.IMemoryDomains.cs

@@ -5,7 +5,7 @@ namespace BizHawk.Emulation.Cores.Atari.Atari2600
 {
 	public partial class Atari2600 : IMemoryDomains
 	{
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		private void SetupMemoryDomains()
 		{

BizHawk.Emulation.Cores/Consoles/Atari/7800/Atari7800.IMemoryDomains.cs

@@ -10,7 +10,7 @@ namespace BizHawk.Emulation.Cores.Atari.Atari7800
 	{
 		private List<MemoryDomain> _MemoryDomains;
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		public void SetupMemoryDomains(HSC7800 hsc7800)
 		{

BizHawk.Emulation.Cores/Consoles/Atari/lynx/Lynx.cs

@@ -390,7 +390,7 @@ namespace BizHawk.Emulation.Cores.Atari.Lynx
 		}
 
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		#endregion
 	}

BizHawk.Emulation.Cores/Consoles/Coleco/ColecoVision.IMemoryDomains.cs

@@ -7,7 +7,7 @@ namespace BizHawk.Emulation.Cores.ColecoVision
 {
 	public partial class ColecoVision : IMemoryDomains
 	{
-		public MemoryDomainList MemoryDomains
+		public IMemoryDomainList MemoryDomains
 		{
 			get { return memoryDomains; }
 		}

BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/Meteor.cs

@@ -235,7 +235,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
 		#region memorydomains
 
 		List<MemoryDomain> _MemoryDomains = new List<MemoryDomain>();
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		void AddMemoryDomain(LibMeteor.MemoryArea which, int size, string name)
 		{

BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/VBANext.cs

@@ -403,7 +403,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
 			MemoryDomains = new MemoryDomainList(mm, 0);
 		}
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		VBARegisterHelper regs;
 

BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/Gambatte.cs

@@ -782,7 +782,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
 		}
 
 		private List<MemoryDomain> _MemoryDomains = new List<MemoryDomain>();
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		#endregion
 

BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/GambatteLink.cs

@@ -405,7 +405,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
 
 		#region debugging
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		public IDictionary<string, RegisterValue> GetCpuFlagsAndRegisters()
 		{

BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64.IMemoryDomains.cs

@@ -11,7 +11,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
 	{
 		private List<MemoryDomain> _memoryDomains = new List<MemoryDomain>();
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		private void MakeMemoryDomain(string name, mupen64plusApi.N64_MEMORY id, MemoryDomain.Endian endian, bool swizzled = false)
 		{

BizHawk.Emulation.Cores/Consoles/Nintendo/NES/NES.cs

@@ -446,7 +446,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 		}
 
 		public string SystemId { get { return "NES"; } }
-		public MemoryDomainList MemoryDomains { get { return memoryDomains; } }
+		public IMemoryDomainList MemoryDomains { get { return memoryDomains; } }
 
 		public string GameName { get { return game_name; } }
 

BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.cs

@@ -381,7 +381,7 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES
 			MemoryDomains = new MemoryDomainList(mm, 0);
 		}
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		public IDictionary<string, RegisterValue> GetCpuFlagsAndRegisters()
 		{

BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/LibsnesCore.cs

@@ -1145,7 +1145,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
 
 		private MemoryDomain MainMemory;
 		private List<MemoryDomain> _memoryDomains = new List<MemoryDomain>();
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		#region audio stuff
 

BizHawk.Emulation.Cores/Consoles/PC Engine/PCEngine.cs

@@ -566,7 +566,7 @@ namespace BizHawk.Emulation.Cores.PCEngine
 		}
 
 		MemoryDomainList memoryDomains;
-		public MemoryDomainList MemoryDomains { get { return memoryDomains; } }
+		public IMemoryDomainList MemoryDomains { get { return memoryDomains; } }
 
 		public IDictionary<string, RegisterValue> GetCpuFlagsAndRegisters()
 		{

BizHawk.Emulation.Cores/Consoles/Sega/Genesis/Genesis.cs

@@ -489,7 +489,7 @@ namespace BizHawk.Emulation.Cores.Sega.Genesis
 			memoryDomains = new MemoryDomainList(domains);
 		}
 
-		public MemoryDomainList MemoryDomains { get { return memoryDomains; } }
+		public IMemoryDomainList MemoryDomains { get { return memoryDomains; } }
 
 		public void Dispose() { }
 	}

BizHawk.Emulation.Cores/Consoles/Sega/SMS/SMS.cs

@@ -487,7 +487,7 @@ namespace BizHawk.Emulation.Cores.Sega.MasterSystem
 			memoryDomains = new MemoryDomainList(domains);
 		}
 
-		public MemoryDomainList MemoryDomains { get { return memoryDomains; } }
+		public IMemoryDomainList MemoryDomains { get { return memoryDomains; } }
 
 		public IDictionary<string, RegisterValue> GetCpuFlagsAndRegisters()
 		{

BizHawk.Emulation.Cores/Consoles/Sega/Saturn/Yabause.IMemoryDomains.cs

@@ -8,7 +8,7 @@ namespace BizHawk.Emulation.Cores.Sega.Saturn
 {
 	public partial class Yabause : IMemoryDomains
 	{
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		private void InitMemoryDomains()
 		{

BizHawk.Emulation.Cores/Consoles/Sega/gpgx/GPGX.cs

@@ -583,7 +583,7 @@ namespace BizHawk.Emulation.Cores.Consoles.Sega.gpgx
 
 		#region debugging tools
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		unsafe void SetMemoryDomains()
 		{

BizHawk.Emulation.Cores/Consoles/Sony/PSX/Octoshock.cs

@@ -622,7 +622,7 @@ namespace BizHawk.Emulation.Cores.Sony.PSX
 			MemoryDomains = new MemoryDomainList(mmd, 0);
 		}
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 
 		#endregion
 

BizHawk.Emulation.Cores/Consoles/WonderSwan/WonderSwan.cs

@@ -322,7 +322,7 @@ namespace BizHawk.Emulation.Cores.WonderSwan
 		private readonly MemoryCallbackSystem _memorycallbacks = new MemoryCallbackSystem();
 		public IMemoryCallbackSystem MemoryCallbacks { get { return _memorycallbacks; } }
 
-		public MemoryDomainList MemoryDomains { get; private set; }
+		public IMemoryDomainList MemoryDomains { get; private set; }
 	
 		public IDictionary<string, RegisterValue> GetCpuFlagsAndRegisters()
 		{