Commit Graph

246 Commits

Author SHA1 Message Date
adelikat d4c8615e95 remove unused usings and other redundancies 2020-04-23 20:33:18 -05:00
zeromus 10bceeb0dc Nope, I think it's a good idea now.
Revert "This reverts commit c878c85daeaaf0cae3e28f24bc1a8b511293d7b6."
This reverts commit 1d1f2a18c6.
2020-04-23 21:20:59 -04:00
zeromus 1d1f2a18c6 This reverts commit c878c85dae. 2020-04-23 21:06:12 -04:00
zeromus c878c85dae for your consideration: sync settings return flags instead of a bool, so we can have more granularity in what needs resetting than just "reboot core". for instance, we would like to minimize the number of times the window layout is redone by not doing it when the screen settings havent changed. HOWEVER, while I was writing this commit message, I realized, I should probably do it just by being more cautious in kicking off the layout (unless the data coming from the core has changed, a layout shouldnt happen). So I am going to make this commit, in case it inspires anyone, and then revert it. 2020-04-23 21:05:56 -04:00
Asnivor f3fce7a3eb ZXHawk: Remove separate +3 embedded roms (the +2A rom is identical) 2020-04-13 16:17:51 +01:00
Asnivor de3d402958 ZXHawk: Small bugfix in reset behaviour 2020-04-13 16:06:06 +01:00
adelikat 2b281116ed misc cleanups 2020-04-08 16:03:35 -05:00
adelikat 9fa59bad42 refactor CoreComm usages in Computer cores 2020-03-15 09:10:13 -05:00
YoshiRulz 5196b97459
Fix resources for BizHawk.Emulation.Cores and cleanup 2020-03-07 07:45:19 +10:00
adelikat 46d05de51f nothing to see here 2020-02-28 12:52:48 -06:00
adelikat 2ccf03fd44 use property initializers in some cores and some constructor cleanups 2020-02-18 10:54:39 -06:00
adelikat 606c3bf1c2
use more advanced language features in Emulation.Cores (#1852)
* Use expression bodies in Emulation.Cores, and a few other misc cleanups

* remove unused usings in Emulation.Common

* cleanups in Tables_Direct.cs

* some cleanups in nes boards - redundant code

* remove some redundant array initializers in Emulation.Cores

* cleanup AmstradCPC.Controllers

* use object initializers in a lot of places

* nes mappers - remove disch's notes comments in favor of the nesdev wiki link

* cleanup CdtConverter.cs, mostly use of object initializers

* remove redundant .ToString() calls in Emulation.Cores

* using var in Emulation.Cores

* AmstradCPC/ZXSpectrum - simplify some linq, tabs instead of spaces, a few other misc cleanups

* Use null-propagation in Emulation.Cores
2020-02-17 16:54:51 -06:00
adelikat aa5cd2165b and oops 2020-02-16 18:07:12 -06:00
adelikat 27352a6f8e add Get/SetCpuFlagsAndRegisters to Z80, and remove all the boilerplate from related cores 2020-02-16 17:55:40 -06:00
adelikat 384f514445 misc cleanups in ZXSpectrum class files 2020-02-16 16:21:07 -06:00
adelikat b03b6eb9de convert spaces to tabs in some ZXSpectrum files 2020-02-16 16:10:26 -06:00
adelikat 027dc01c8b
create StateSerializer as a base implementation of IStatable (#1850)
* create StateSerializer, an ITextStatable implementation using the Serializer class, and wire it up to the TI83 core

* wire StateSerializer to A2600 core

* wire up StateSerializer to AmstradCPC, C64, and ZXS

* wire up StateSerializer to MSX, A27800, and Coleco

* wire up state serializer to ChannelF, Vectrex, Intellivision

* fix GambatteLink to implement ITextStatable, implement TextSerializer in O2

* StateSerializer - wire up a loadstate callback and implement StateSerializer for NesHawk, a bit of rework to subNesHawk as a result

* fix subneshawk text savestates

* StateSerializer - implement byte[] buffer storing (optionally), wire up to PCE

* implement StateSerializer to SMS, tweak GGLink accordingly

* implement StateSerializer in GBHawk, fix link cores accordingly

* StateSerializer - use Serializer static methods to create serializers
2020-02-16 12:05:57 -06:00
adelikat 4b7a7dd293
Make Binary states default and Textstates opt-in for cores (#1848)
* Rewind & State config - remove the default option

* remove the savestate type of default, not that this is a breaking config change for anyone that had specifically set savestates to text

* remove BinaryStatesPreferred from IStatable and use config setting when starting movies from "Now" in record movie dialog

* remove BinaryStatesPreferred from cores

* make text savestates an extension method off of IStatable and an inteface ITextStatable it uses if the core implements it. This will allow cores to opt in to text states if desired

* make cores with actual text savestate impleemntations get ITextStatable, remove text state logic from cores that just have a binary as as text implementation
2020-02-15 10:22:26 -06:00
YoshiRulz b2a3477f52
Enable SA1123 and fix noncompliance
"Do not place regions within elements"
2020-01-25 18:06:56 +10:00
YoshiRulz d9d6ed76f4
Enable SA1115 and fix noncompliance
"Parameter should follow comma"
i.e. no newlines in param list
2020-01-25 18:06:54 +10:00
YoshiRulz 6f3f01125c
Enable SA1504 and fix noncompliance
"All accessors should be single-line or multi-line"
i.e. no block form on one line
2020-01-25 14:56:56 +10:00
YoshiRulz bfde89b9f3
Enable SA1139 and fix noncompliance
"Use literal suffix notation instead of casting"
2020-01-25 07:55:48 +10:00
YoshiRulz c38fb09d3c
Fix typos in strings and comments (from #971) 2020-01-13 00:22:01 +10:00
Asnivor 91008590cf ZXHawk: Implement more faithful AY port decoding (fixes #1767) 2019-12-29 22:23:20 +00:00
adelikat 85be6af3d3 Convert spaces to tabs in ZX Spectrum and AmstradCPC cores 2019-12-06 17:47:59 -06:00
adelikat fef746dffa properly dispose of IDisposables in core savestate code, and a few other places 2019-12-06 17:33:17 -06:00
James Groom 90b0574bc3
Remove unnecessary calls to ToList (e.g. in foreach)
squashed PR #1591
2019-10-13 15:50:57 +00:00
YoshiRulz 4dd40305bc
Merge branch 'master' into interp_cores 2019-06-15 02:11:24 +10:00
YoshiRulz 2642ef4049
Remove empty docs 2019-06-06 16:41:10 +10:00
YoshiRulz ceb490828f
Fix docs "not placed on a valid language element" 2019-05-29 21:04:12 +10:00
Asnivor 47a5ce2798 ChannelF: some more changes 2019-05-07 14:43:36 +01:00
Asnivor b2584145d7 SyncSoundMixer: improved and moved out of ZXSpectrum into Cores.Sound (as the CPC will use this and future cores may find it useful) 2019-04-04 12:16:16 +01:00
YoshiRulz 9af93be0d3
Use string interpolation 2019-04-04 02:41:18 +10:00
Asnivor ae7bea226c ZXHawk: move the beeper implementation out of the core into Cores.Sound. The CPC core will also use this and we may have other cores in the future that want to make use of a nice 1-bit buzzer/implementation (tape loading, onboard speaker etc..) 2019-04-03 17:01:35 +01:00
James Groom 4e91f88af3
Use nameof in cores 2019-03-28 14:18:58 +11:00
alyosha-tas 6d0973ca7e
Merge pull request #1429 from YoshiRulz/master
Inconsequential changes (no whitespace)

looks good to me
2019-03-09 17:32:10 -06:00
Asnivor 76070cd89d OCD: Fix non-critial compiler warnings in my code 2019-01-25 15:45:15 +00:00
alyosha-tas c19c7cd5c3 SubNESHawk
also Input register shift fix

# Conflicts:
#	BizHawk.Client.EmuHawk/MainForm.Designer.cs
#	BizHawk.Client.EmuHawk/MainForm.Events.cs
#	BizHawk.Emulation.Cores/Computers/AmstradCPC/AmstradCPC.IEmulator.cs
#	BizHawk.Emulation.Cores/Computers/SinclairSpectrum/ZXSpectrum.IEmulator.cs
#	BizHawk.Emulation.Cores/Consoles/Nintendo/NES/PPU.run.cs
2019-01-10 18:25:59 +03:00
YoshiRulz c0a28a320b
Inconsequential changes (no whitespace)
Remove useless semicolon, remove useless `? true : false`, move period to next
line
2019-01-07 22:02:02 +10:00
Asnivor 2b7014f8b8 ZXHawk: Some comment and group structure cleanup 2019-01-02 14:02:09 +00:00
Asnivor 3766e2380c ZXHawk: Fix exception thrown randomly by tape player subsystem 2019-01-02 12:38:32 +00:00
Asnivor 0411be40fe ZXHawk: readme update 2018-12-06 13:15:24 +00:00
Asnivor 1ffeb7cf7e ZXHawk: pentagon initialisation 2018-12-06 12:58:52 +00:00
alyosha-tas bf9796f1e8 z80: rewrite interrupt handling 2018-09-29 22:04:37 -05:00
Asnivor f62ab685a9 ZXHawk: Fix core GUI windows monospace weirdness 2018-09-18 10:50:15 +01:00
Asnivor c76e2f35a0 ZXHawk: Starting on UDI and IPF disk image support (although neither are fully working or hooked up yet) 2018-09-13 10:44:48 +01:00
Asnivor faaf4d2f18 ZXHawk: Support double-sided *.dsk images and throw an exception if the images are not 42 track disks 2018-09-11 11:21:59 +01:00
Asnivor 16d68ea813 ZXHawk: debug only zx-state snapshot export 2018-09-10 10:05:49 +01:00
Asnivor 4e470cf17a ZXHawk: DeterministicEmulation to be overridden (TRUE) when recording a movie - #1290 2018-08-21 14:16:14 +01:00
Asnivor 7ff4cea6c7 ZXHawk: +3/+2a writes to 0x1ffd and 0x7ffd decoded more faithfully 2018-08-20 17:24:14 +01:00