mirror of https://github.com/xemu-project/xemu.git
e80c1e4c7d
Peter Xu found a potential issue: "The other thing is when I am looking at the new code I found that we actually extended the replay() to be used also in dirty tracking of vfio, in vfio_sync_dirty_bitmap(). For that maybe it's already broken if unmap_all() because afaiu log_sync() can be called in migration thread anytime during DMA so I think it means the device is prone to DMA with the IOMMU pgtable quickly erased and rebuilt here, which means the DMA could fail unexpectedly. Copy Alex, Kirti and Neo." Fix it by replacing the unmap_all() to only evacuate the iova tree (keeping all host mappings untouched, IOW, don't notify UNMAP), and do a full resync in page walk which will notify all existing mappings as MAP. This way we don't interrupt with any existing mapping if there is (e.g. for the dirty sync case), meanwhile we keep sync too to latest (for moving a vfio device into an existing iommu group). Suggested-by: Peter Xu <peterx@redhat.com> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> Reviewed-by: Peter Xu <peterx@redhat.com> Message-Id: <20230615032626.314476-2-zhenzhong.duan@intel.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> |
||
|---|---|---|
| .. | ||
| kvm | ||
| xen | ||
| Kconfig | ||
| acpi-build.c | ||
| acpi-build.h | ||
| acpi-common.c | ||
| acpi-common.h | ||
| acpi-microvm.c | ||
| acpi-microvm.h | ||
| amd_iommu.c | ||
| amd_iommu.h | ||
| e820_memory_layout.c | ||
| e820_memory_layout.h | ||
| fw_cfg.c | ||
| fw_cfg.h | ||
| generic_event_device_x86.c | ||
| intel_iommu.c | ||
| intel_iommu_internal.h | ||
| kvmvapic.c | ||
| meson.build | ||
| microvm-dt.c | ||
| microvm-dt.h | ||
| microvm.c | ||
| multiboot.c | ||
| multiboot.h | ||
| pc.c | ||
| pc_piix.c | ||
| pc_q35.c | ||
| pc_sysfw.c | ||
| pc_sysfw_ovmf-stubs.c | ||
| pc_sysfw_ovmf.c | ||
| port92.c | ||
| sgx-epc.c | ||
| sgx-stub.c | ||
| sgx.c | ||
| trace-events | ||
| trace.h | ||
| vmmouse.c | ||
| vmport.c | ||
| x86-iommu-stub.c | ||
| x86-iommu.c | ||
| x86.c | ||