mirror of https://github.com/xemu-project/xemu.git
f55cceac8c
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
* error_append_hint(), because that doesn't work with &error_fatal.
* ERRP_GUARD() lifts these restrictions.
*
* To use ERRP_GUARD(), add it right at the beginning of the function.
* @errp can then be used without worrying about the argument being
* NULL or &error_fatal.
ERRP_GUARD() could avoid the case when @errp is the pointer of
error_fatal, the user can't see this additional information, because
exit() happens in error_setg earlier than information is added [1].
The sev_inject_launch_secret() passes @errp to error_prepend(), and as
an APIs defined in target/i386/sev.h, it is necessary to protect its
@errp with ERRP_GUARD().
To avoid the issue like [1] said, add missing ERRP_GUARD() at the
beginning of this function.
[1]: Issue description in the commit message of commit
|
||
|---|---|---|
| .. | ||
| hvf | ||
| kvm | ||
| nvmm | ||
| tcg | ||
| whpx | ||
| Kconfig | ||
| arch_dump.c | ||
| arch_memory_mapping.c | ||
| cpu-dump.c | ||
| cpu-internal.h | ||
| cpu-param.h | ||
| cpu-qom.h | ||
| cpu-sysemu.c | ||
| cpu.c | ||
| cpu.h | ||
| gdbstub.c | ||
| helper.c | ||
| helper.h | ||
| host-cpu.c | ||
| host-cpu.h | ||
| machine.c | ||
| meson.build | ||
| monitor.c | ||
| ops_sse.h | ||
| sev-sysemu-stub.c | ||
| sev.c | ||
| sev.h | ||
| svm.h | ||
| trace-events | ||
| trace.h | ||
| xsave_helper.c | ||