Commit Graph

118873 Commits

Author SHA1 Message Date
Fabiano Rosas 7e4480dde2 migration/multifd: Fix compat with QEMU < 9.0
Commit f5f48a7891 ("migration/multifd: Separate SYNC request with
normal jobs") changed the multifd source side to stop sending data
along with the MULTIFD_FLAG_SYNC, effectively introducing the concept
of a SYNC-only packet. Relying on that, commit d7e58f412c
("migration/multifd: Don't send ram data during SYNC") later came
along and skipped reading data from SYNC packets.

In a versions timeline like this:

  8.2 f5f48a7 9.0 9.1 d7e58f41 9.2

The issue arises that QEMUs < 9.0 still send data along with SYNC, but
QEMUs > 9.1 don't gather that data anymore. This leads to various
kinds of migration failures due to desync/missing data.

Stop checking for a SYNC packet on the destination and unconditionally
unfill the packet.

>From now on:

old -> new:
the source sends data + sync, destination reads normally

new -> new:
source sends only sync, destination reads zeros

new -> old:
source sends only sync, destination reads zeros

CC: qemu-stable@nongnu.org
Fixes: d7e58f412c ("migration/multifd: Don't send ram data during SYNC")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2720
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Message-Id: <20241213160120.23880-2-farosas@suse.de>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
(cherry picked from commit b93d897ea2f0abbe7fc341a9ac176b5ecd0f3c93)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2025-01-12 15:54:21 +03:00
Shameer Kolothum f5827eb0ac migration/multifd: Fix compile error caused by page_size usage
>From Commit 90fa121c6c ("migration/multifd: Inline page_size and
page_count") onwards page_size is not part of MutiFD*Params but uses
an inline constant instead.

However, it missed updating an old usage, causing a compile error.

Fixes: 90fa121c6c ("migration/multifd: Inline page_size and page_count")
Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Message-Id: <20241203124943.52572-1-shameerali.kolothum.thodi@huawei.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
(cherry picked from commit d127294f265e6a17f8d614f2bef7df8455e81f56)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2025-01-12 15:53:02 +03:00
Matt Borgerson ebcacad78b meson: Disable fdt 2025-01-09 15:48:27 -07:00
Matt Borgerson f417d8b7ae scripts/archive-source.sh: Fix xemu subproject deps 2025-01-09 15:48:27 -07:00
Matt Borgerson 26db3b504f ci: Release aarch64 binaries for Windows 2025-01-07 21:42:35 -07:00
mborgerson 78ab522047
Merge QEMU v9.2.0
Merge QEMU v9.2.0
2025-01-07 21:29:33 -07:00
Matt Borgerson 26b2ac28fc i386: Disable some hardware unrelated to Xbox to trim the build 2025-01-07 18:26:26 -07:00
Matt Borgerson 7eba0d3124 nv2a/gl: Update copyright on recently modified files 2025-01-07 17:37:06 -07:00
Matt Borgerson 510c280b05 nv2a/gl: Unify ShaderBinding and ShaderLruNode 2025-01-07 17:35:06 -07:00
Matt Borgerson e7047efef2 vl: Migrate -audiodev none -> -audio none 2025-01-07 14:31:30 -07:00
Matt Borgerson 5dcbb7ebdb nvnet: Minor cleanup 2025-01-07 14:28:27 -07:00
Matt Borgerson fb8d47f9ba meson: Bump nv2a_vsh_cpu subproject version 2025-01-07 01:08:20 -07:00
Matt Borgerson 6b79ed8f3d meson: Disable -Wundef, -Wvla 2025-01-07 00:52:51 -07:00
Matt Borgerson f4482d3ced ui: Fix variable shadowing 2025-01-07 00:52:51 -07:00
Matt Borgerson e93bb37177 ui: Fix variable shadowing 2025-01-07 00:52:51 -07:00
Matt Borgerson 2558bc53a0 ui: Drop redundant SetCursorPos(GetCursorPos()) 2025-01-07 00:52:51 -07:00
Matt Borgerson 4c5858bd20 ui: Drop duplicate declaration of xemu_monitor_init 2025-01-07 00:52:51 -07:00
Matt Borgerson 6c389194b6 nv2a/psh: Remove unused arguments in string format 2025-01-07 00:52:51 -07:00
Matt Borgerson d76898f63b nv2a: Fix variable shadowing complaints 2025-01-07 00:52:51 -07:00
Matt Borgerson 281f42c5e1 mcpx: Fix variable shadowing 2025-01-07 00:52:51 -07:00
Matt Borgerson 85f84be04d mcpx: Narrow variable def scopes, fix shadowing 2025-01-07 00:52:51 -07:00
Matt Borgerson 57c6d82fa3 nv2a/vk: Simplify debug indent loop to a variable field width format 2025-01-07 00:52:51 -07:00
Matt Borgerson 6ac52147a4 nv2a/psh: Remove function scope variable i, which was being shadowed 2025-01-07 00:52:51 -07:00
Matt Borgerson 3070d6422c mstring: Remove mstring_append_{int,char} 2025-01-07 00:52:51 -07:00
Matt Borgerson 0a942630d5 mstring: Add format attribute to mstring formatting functions 2025-01-07 00:52:51 -07:00
Richard Henderson a8a8e54564 tcg: Reset free_temps before tcg_optimize
When allocating new temps during tcg_optmize, do not re-use
any EBB temps that were used within the TB.  We do not have
any idea what span of the TB in which the temp was live.

Introduce tcg_temp_ebb_reset_freed and use before tcg_optimize,
as well as replacing the equivalent in plugin_gen_inject and
tcg_func_start.

Cc: qemu-stable@nongnu.org
Fixes: fb04ab7ddd ("tcg/optimize: Lower TCG_COND_TST{EQ,NE} if unsupported")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2711
Reported-by: wannacu <wannacu2049@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
2025-01-06 23:07:47 -07:00
Matt Borgerson 0e50741c28 ui,xbox: Copyright updates on changed files 2025-01-06 23:06:21 -07:00
Matt Borgerson 34fe7918d3 nvnet: Return `true' instead of `1' when returning a bool 2025-01-06 23:05:53 -07:00
Matt Borgerson 8687b152c9 nvnet: Drop pc.h, add pci_device.h includes 2025-01-06 23:05:53 -07:00
Matt Borgerson 376280a635 xbox: Configure nic 2025-01-06 23:05:53 -07:00
Matt Borgerson d5797ef53a meson: Fix Cocoa framework dependency 2025-01-06 23:05:53 -07:00
Matt Borgerson 8c1d204d4a build: Drop LTO for now 2025-01-06 23:05:53 -07:00
Matt Borgerson 9a8ee63e71 accel/tcg/tb-hash: Include exec/cpu_ldst.h 2025-01-06 23:05:53 -07:00
Matt Borgerson 3b2f4533c5 meson: Fix loader.c file inclusion 2025-01-06 23:05:53 -07:00
Matt Borgerson 291e401897 meson: Drop gtk option check 2025-01-06 23:05:53 -07:00
Matt Borgerson abfd542891 meson: Update buildoptions 2025-01-06 23:05:53 -07:00
Matt Borgerson 8ef22bb6bf Makefile: Ignore distclean before configure error 2025-01-06 23:05:53 -07:00
Matt Borgerson 1b13d92075 meson: Fix opengl dependency 2025-01-06 23:05:53 -07:00
Matt Borgerson 675599dd56 meson: Ignore gcc_struct check 2025-01-06 23:05:53 -07:00
Matt Borgerson af22de5eb7 scripts/archive-source.sh: Drop non-xemu deps 2025-01-06 23:05:53 -07:00
Matt Borgerson 21a3ee89ba meson: Migrate genconfig submodule to subproject 2025-01-06 23:05:53 -07:00
Matt Borgerson fcf5eb84a1 meson: Migrate implot submodule to subproject 2025-01-06 23:05:53 -07:00
Matt Borgerson 09f7787fa9 meson: Migrate imgui submodule to subproject 2025-01-06 23:05:53 -07:00
Matt Borgerson 24c24e030d mc146818rtc: Move Xbox RTC init pattern to reset handler 2025-01-06 23:05:53 -07:00
Matt Borgerson 75ce25c9b5 nv2a: Define DEBUG_NV2A_*=0 ifndef 2025-01-06 23:05:53 -07:00
Matt Borgerson f4ef9f6309 mcpx: Rename dev to parent_obj, use QOM casts 2025-01-06 23:05:53 -07:00
Matt Borgerson 739850e6e0 ui/xemu: Update DISPLAYGL_* -> DISPLAY_GL_* 2025-01-06 23:05:53 -07:00
Matt Borgerson da0bdaef75 ui/xemu: Migrate #if to #ifdef check for debug builds 2025-01-06 23:05:53 -07:00
Matt Borgerson 8ae09abbf5 ui/xemu: Use surface_format accessor 2025-01-06 23:05:53 -07:00
Matt Borgerson b60fd9ac9c ui/xemu: Update sdl_mouse_warp prototype 2025-01-06 23:05:53 -07:00