ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Qt: Remove Target Partial Invalidation hwfix from the gui.

This commit is contained in:
lightningterror 2023-08-20 12:48:26 +02:00 committed by refractionpcsx2
parent 86f82951d5
commit c7b94d0a42
3 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pcsx2-qt/Settings/GraphicsSettingsWidget.cpp
View File

@ -198,18 +198,13 @@ GraphicsSettingsWidget::GraphicsSettingsWidget(SettingsDialog* dialog, QWidget*
SettingWidgetBinder::BindWidgetToIntSetting( SettingWidgetBinder::BindWidgetToIntSetting(
sif, m_ui.textureInsideRt, "EmuCore/GS", "UserHacks_TextureInsideRt", static_cast<int>(GSTextureInRtMode::Disabled)); sif, m_ui.textureInsideRt, "EmuCore/GS", "UserHacks_TextureInsideRt", static_cast<int>(GSTextureInRtMode::Disabled));
SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.readTCOnClose, "EmuCore/GS", "UserHacks_ReadTCOnClose", false); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.readTCOnClose, "EmuCore/GS", "UserHacks_ReadTCOnClose", false);
SettingWidgetBinder::BindWidgetToBoolSetting(
sif, m_ui.targetPartialInvalidation, "EmuCore/GS", "UserHacks_TargetPartialInvalidation", false);
SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.estimateTextureRegion, "EmuCore/GS", "UserHacks_EstimateTextureRegion", false); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.estimateTextureRegion, "EmuCore/GS", "UserHacks_EstimateTextureRegion", false);
SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.gpuPaletteConversion, "EmuCore/GS", "paltex", false); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.gpuPaletteConversion, "EmuCore/GS", "paltex", false);
connect(m_ui.cpuSpriteRenderBW, QOverload<int>::of(&QComboBox::currentIndexChanged), this, connect(m_ui.cpuSpriteRenderBW, QOverload<int>::of(&QComboBox::currentIndexChanged), this,
&GraphicsSettingsWidget::onCPUSpriteRenderBWChanged); &GraphicsSettingsWidget::onCPUSpriteRenderBWChanged);
connect(
m_ui.textureInsideRt, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &GraphicsSettingsWidget::onTextureInsideRtChanged);
connect(m_ui.gpuPaletteConversion, QOverload<int>::of(&QCheckBox::stateChanged), this, connect(m_ui.gpuPaletteConversion, QOverload<int>::of(&QCheckBox::stateChanged), this,
&GraphicsSettingsWidget::onGpuPaletteConversionChanged); &GraphicsSettingsWidget::onGpuPaletteConversionChanged);
onCPUSpriteRenderBWChanged(); onCPUSpriteRenderBWChanged();
onTextureInsideRtChanged();
onGpuPaletteConversionChanged(m_ui.gpuPaletteConversion->checkState()); onGpuPaletteConversionChanged(m_ui.gpuPaletteConversion->checkState());
////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////
@ -559,10 +554,6 @@ GraphicsSettingsWidget::GraphicsSettingsWidget(SettingsDialog* dialog, QWidget*
tr("Flushes all targets in the texture cache back to local memory when shutting down. Can prevent lost visuals when saving " tr("Flushes all targets in the texture cache back to local memory when shutting down. Can prevent lost visuals when saving "
"state or switching renderers, but can also cause graphical corruption.")); "state or switching renderers, but can also cause graphical corruption."));
dialog->registerWidgetHelp(m_ui.targetPartialInvalidation, tr("Target Partial Invalidation"), tr("Unchecked"),
tr("Allows partial invalidation of render targets, which can fix graphical errors in some games. Texture Inside Render Target "
"automatically enables this option."));
dialog->registerWidgetHelp(m_ui.estimateTextureRegion, tr("Estimate Texture Region"), tr("Unchecked"), dialog->registerWidgetHelp(m_ui.estimateTextureRegion, tr("Estimate Texture Region"), tr("Unchecked"),
tr("Attempts to reduce the texture size when games do not set it themselves (e.g. Snowblind games).")); tr("Attempts to reduce the texture size when games do not set it themselves (e.g. Snowblind games)."));
} }
@ -889,13 +880,6 @@ void GraphicsSettingsWidget::onCPUSpriteRenderBWChanged()
m_ui.cpuSpriteRenderLevel->setEnabled(value != 0); m_ui.cpuSpriteRenderLevel->setEnabled(value != 0);
} }
void GraphicsSettingsWidget::onTextureInsideRtChanged()
{
const bool disabled = static_cast<GSTextureInRtMode>(m_ui.textureInsideRt->currentIndex()) >= GSTextureInRtMode::InsideTargets;
m_ui.targetPartialInvalidation->setDisabled(disabled);
}
GSRendererType GraphicsSettingsWidget::getEffectiveRenderer() const GSRendererType GraphicsSettingsWidget::getEffectiveRenderer() const
{ {
const GSRendererType type = const GSRendererType type =
@ -1060,7 +1044,6 @@ void GraphicsSettingsWidget::resetManualHardwareFixes()
check_bool("EmuCore/GS", "UserHacks_DisablePartialInvalidation", false); check_bool("EmuCore/GS", "UserHacks_DisablePartialInvalidation", false);
check_int("EmuCore/GS", "UserHacks_TextureInsideRt", static_cast<int>(GSTextureInRtMode::Disabled)); check_int("EmuCore/GS", "UserHacks_TextureInsideRt", static_cast<int>(GSTextureInRtMode::Disabled));
check_bool("EmuCore/GS", "UserHacks_ReadTCOnClose", false); check_bool("EmuCore/GS", "UserHacks_ReadTCOnClose", false);
check_bool("EmuCore/GS", "UserHacks_TargetPartialInvalidation", false);
check_bool("EmuCore/GS", "UserHacks_EstimateTextureRegion", false); check_bool("EmuCore/GS", "UserHacks_EstimateTextureRegion", false);
check_bool("EmuCore/GS", "paltex", false); check_bool("EmuCore/GS", "paltex", false);
check_int("EmuCore/GS", "UserHacks_HalfPixelOffset", 0); check_int("EmuCore/GS", "UserHacks_HalfPixelOffset", 0);

1
pcsx2-qt/Settings/GraphicsSettingsWidget.h
View File

@ -42,7 +42,6 @@ private Q_SLOTS:
void onTrilinearFilteringChanged(); void onTrilinearFilteringChanged();
void onGpuPaletteConversionChanged(int state); void onGpuPaletteConversionChanged(int state);
void onCPUSpriteRenderBWChanged(); void onCPUSpriteRenderBWChanged();
void onTextureInsideRtChanged();
void onFullscreenModeChanged(int index); void onFullscreenModeChanged(int index);
void onShadeBoostChanged(); void onShadeBoostChanged();
void onCaptureContainerChanged(); void onCaptureContainerChanged();

7
pcsx2-qt/Settings/GraphicsSettingsWidget.ui
View File

@ -1027,13 +1027,6 @@
</property> </property>
</widget> </widget>
</item> </item>
<item row="4" column="1">
<widget class="QCheckBox" name="targetPartialInvalidation">
<property name="text">
<string>Target Partial Invalidation</string>
</property>
</widget>
</item>
<item row="3" column="1"> <item row="3" column="1">
<widget class="QCheckBox" name="readTCOnClose"> <widget class="QCheckBox" name="readTCOnClose">
<property name="text"> <property name="text">