ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GS/HW: Avoid copying an empty rectangle 

Fixes a possible validation error in Ultraman Fighting Evolution -
Rebirth.
This commit is contained in:
Stenzek 2023-03-04 00:36:11 +10:00 committed by refractionpcsx2
parent 0bff6f7ad9
commit c35092504c
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pcsx2/GS/Renderers/HW/GSTextureCache.cpp
View File

@ -2396,7 +2396,6 @@ GSTextureCache::Source* GSTextureCache::CreateSource(const GIFRegTEX0& TEX0, con
const GSVector2 scale = is_8bits ? GSVector2(1, 1) : dst->m_texture->GetScale(); const GSVector2 scale = is_8bits ? GSVector2(1, 1) : dst->m_texture->GetScale();
const bool use_texture = shader == ShaderConvert::COPY;
GSVector4i sRect(0, 0, w, h); GSVector4i sRect(0, 0, w, h);
int destX = 0; int destX = 0;
int destY = 0; int destY = 0;
@ -2446,6 +2445,10 @@ GSTextureCache::Source* GSTextureCache::CreateSource(const GIFRegTEX0& TEX0, con
} }
} }
// Create a cleared RT if we somehow end up with an empty source rect (because the RT isn't large enough).
const bool source_rect_empty = sRect.rempty();
const bool use_texture = (shader == ShaderConvert::COPY && !source_rect_empty);
// Assuming everything matches up, instead of copying the target, we can just sample it directly. // Assuming everything matches up, instead of copying the target, we can just sample it directly.
// It's the same as doing the copy first, except we save GPU time. // It's the same as doing the copy first, except we save GPU time.
if (!half_right && // not the size change from above if (!half_right && // not the size change from above
@ -2482,7 +2485,7 @@ GSTextureCache::Source* GSTextureCache::CreateSource(const GIFRegTEX0& TEX0, con
{ {
g_gs_device->CopyRect(sTex, dTex, sRect, destX, destY); g_gs_device->CopyRect(sTex, dTex, sRect, destX, destY);
} }
else else if (!source_rect_empty)
{ {
GSVector4 sRectF(sRect); GSVector4 sRectF(sRect);
sRectF.z /= sTex->GetWidth(); sRectF.z /= sTex->GetWidth();