ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

common: don't return a boolean for an assert 

It might help to fix those 2 coverity reports.

CID 151744 (#1 of 1): Useless call (USELESS_CALL)
side_effect_free: Calling EnumAssert(id) is only useful for its return value, which is ignored

CID 151745 (#1 of 1): Useless call (USELESS_CALL)
side_effect_free: Calling EnumAssert(id) is only useful for its return value, which is ignored.
This commit is contained in:
Gregory Hainaut 2015-10-17 10:46:11 +02:00
parent 9b796d0f27
commit 4f86cca306
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/include/Utilities/Dependencies.h
View File

@ -73,8 +73,8 @@
\ \
static __fi bool EnumIsValid( enumName id ) { \ static __fi bool EnumIsValid( enumName id ) { \
return ((int)id >= enumName##_FIRST) && ((int)id < enumName##_COUNT); } \ return ((int)id >= enumName##_FIRST) && ((int)id < enumName##_COUNT); } \
static __fi bool EnumAssert( enumName id ) { \ static __fi void EnumAssert( enumName id ) { \
return pxAssert( EnumIsValid(id) ); } \ pxAssert( EnumIsValid(id) ); } \
\ \
extern const wxChar* EnumToString( enumName id ) extern const wxChar* EnumToString( enumName id )