From 4f86cca3061eb20a00269cd125f94b78cf7e438b Mon Sep 17 00:00:00 2001 From: Gregory Hainaut Date: Sat, 17 Oct 2015 10:46:11 +0200 Subject: [PATCH] common: don't return a boolean for an assert It might help to fix those 2 coverity reports. CID 151744 (#1 of 1): Useless call (USELESS_CALL) side_effect_free: Calling EnumAssert(id) is only useful for its return value, which is ignored CID 151745 (#1 of 1): Useless call (USELESS_CALL) side_effect_free: Calling EnumAssert(id) is only useful for its return value, which is ignored. --- common/include/Utilities/Dependencies.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/include/Utilities/Dependencies.h b/common/include/Utilities/Dependencies.h index 33c18106da..8cc62a1004 100644 --- a/common/include/Utilities/Dependencies.h +++ b/common/include/Utilities/Dependencies.h @@ -73,8 +73,8 @@ \ static __fi bool EnumIsValid( enumName id ) { \ return ((int)id >= enumName##_FIRST) && ((int)id < enumName##_COUNT); } \ - static __fi bool EnumAssert( enumName id ) { \ - return pxAssert( EnumIsValid(id) ); } \ + static __fi void EnumAssert( enumName id ) { \ + pxAssert( EnumIsValid(id) ); } \ \ extern const wxChar* EnumToString( enumName id )