ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

x86/iR5900: Don't rename GPR from mf{hi,lo} when in xmm 

Redundant codegen, also incorrect when not in GPR.
This commit is contained in:
Stenzek 2022-12-29 01:09:39 +10:00 committed by refractionpcsx2
parent 9584672051
commit 2a92edd7ed
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pcsx2/x86/ix86-32/iR5900Move.cpp
View File

@ -179,10 +179,7 @@ static void recMTHILO(bool hi, bool upper)
} }
else else
{ {
// try rename rs -> {hi,lo} int gprs = _allocIfUsedGPRtoX86(_Rs_, MODE_READ);
const int gprs = _checkX86reg(X86TYPE_GPR, _Rs_, MODE_READ);
if (gprs >= 0 && !upper && _eeTryRenameReg(reg, _Rs_, gprs, -1, 0) >= 0)
return;
if (xmmhilo >= 0) if (xmmhilo >= 0)
{ {
@ -192,8 +189,9 @@ static void recMTHILO(bool hi, bool upper)
} }
else if (GPR_IS_CONST1(_Rs_)) else if (GPR_IS_CONST1(_Rs_))
{ {
_eeMoveGPRtoR(rax, _Rs_); // force it into a register, since we need to load the constant anyway
xPINSR.Q(xRegisterSSE(xmmhilo), rax, static_cast<u8>(upper)); gprs = _allocX86reg(X86TYPE_GPR, _Rs_, MODE_READ);
xPINSR.Q(xRegisterSSE(xmmhilo), xRegister64(gprs), static_cast<u8>(upper));
} }
else else
{ {
@ -202,11 +200,21 @@ static void recMTHILO(bool hi, bool upper)
} }
else else
{ {
// try rename rs -> {hi,lo}
if (gprs >= 0 && !upper && _eeTryRenameReg(reg, _Rs_, gprs, -1, 0) >= 0)
return;
const int gprreg = upper ? -1 : _allocIfUsedGPRtoX86(reg, MODE_WRITE); const int gprreg = upper ? -1 : _allocIfUsedGPRtoX86(reg, MODE_WRITE);
if (gprreg >= 0) if (gprreg >= 0)
{
_eeMoveGPRtoR(xRegister64(gprreg), _Rs_); _eeMoveGPRtoR(xRegister64(gprreg), _Rs_);
}
else else
_eeMoveGPRtoM((uptr)(hi ? &cpuRegs.HI.UD[static_cast<u8>(upper)] : &cpuRegs.LO.UD[static_cast<u8>(upper)]), _Rs_); {
// force into a register, since we need to load it to write anyway
gprs = _allocX86reg(X86TYPE_GPR, _Rs_, MODE_READ);
xMOV(ptr64[hi ? &cpuRegs.HI.UD[static_cast<u8>(upper)] : &cpuRegs.LO.UD[static_cast<u8>(upper)]], xRegister64(gprs));
}
} }
} }
} }