ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

VMManager: Avoid use-after-move conditions

This commit is contained in:
Ty 2025-02-03 20:35:12 -05:00 committed by Ty
parent 4ab4f4a67c
commit 1f0d6f0ac7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pcsx2/VMManager.cpp
View File

@ -1851,7 +1851,7 @@ bool VMManager::DoSaveState(const char* filename, s32 slot_for_message, bool zip
Console.WriteLn(fmt::format("Creating save state backup {}...", backup_filename)); Console.WriteLn(fmt::format("Creating save state backup {}...", backup_filename));
if (!FileSystem::RenamePath(filename, backup_filename.c_str())) if (!FileSystem::RenamePath(filename, backup_filename.c_str()))
{ {
Host::AddIconOSDMessage(std::move(osd_key), ICON_FA_EXCLAMATION_TRIANGLE, Host::AddIconOSDMessage(osd_key, ICON_FA_EXCLAMATION_TRIANGLE,
fmt::format( fmt::format(
TRANSLATE_FS("VMManager", "Failed to back up old save state {}."), Path::GetFileName(filename)), TRANSLATE_FS("VMManager", "Failed to back up old save state {}."), Path::GetFileName(filename)),
Host::OSD_ERROR_DURATION); Host::OSD_ERROR_DURATION);
@ -2234,7 +2234,7 @@ bool VMManager::ChangeDisc(CDVD_SourceType source, std::string path)
CDVDsys_ChangeSource(source); CDVDsys_ChangeSource(source);
if (!path.empty()) if (!path.empty())
CDVDsys_SetFile(source, std::move(path)); CDVDsys_SetFile(source, path);
Error error; Error error;
const bool result = DoCDVDopen(&error); const bool result = DoCDVDopen(&error);