From 1f0d6f0ac78696820f33ab4ceaf6674b5b7218ee Mon Sep 17 00:00:00 2001 From: Ty Date: Mon, 3 Feb 2025 20:35:12 -0500 Subject: [PATCH] VMManager: Avoid use-after-move conditions --- pcsx2/VMManager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pcsx2/VMManager.cpp b/pcsx2/VMManager.cpp index d4ddc5d4e7..ac08e422b9 100644 --- a/pcsx2/VMManager.cpp +++ b/pcsx2/VMManager.cpp @@ -1851,7 +1851,7 @@ bool VMManager::DoSaveState(const char* filename, s32 slot_for_message, bool zip Console.WriteLn(fmt::format("Creating save state backup {}...", backup_filename)); if (!FileSystem::RenamePath(filename, backup_filename.c_str())) { - Host::AddIconOSDMessage(std::move(osd_key), ICON_FA_EXCLAMATION_TRIANGLE, + Host::AddIconOSDMessage(osd_key, ICON_FA_EXCLAMATION_TRIANGLE, fmt::format( TRANSLATE_FS("VMManager", "Failed to back up old save state {}."), Path::GetFileName(filename)), Host::OSD_ERROR_DURATION); @@ -2234,7 +2234,7 @@ bool VMManager::ChangeDisc(CDVD_SourceType source, std::string path) CDVDsys_ChangeSource(source); if (!path.empty()) - CDVDsys_SetFile(source, std::move(path)); + CDVDsys_SetFile(source, path); Error error; const bool result = DoCDVDopen(&error);