dolphin/Contributing.md

Dolphin Coding Style & Legal Requirements

• Legal
• Coding style introduction
• C++ coding style and formatting
• C++ code-specific guidelines
• Android
• Help

Legal

Summary:

• Trade secrets
• Code licensing

Trade secrets

Following all relevant laws is of utmost importance for an emulation project like Dolphin.

If you know any confidential information related to the GameCube, Wii, or Triforce, either because you signed a non-disclosure agreement or because you looked at leaked materials, we ask that you don't contribute code to Dolphin at all. While accepting code from contributors who know confidential information is legal if the code is unrelated to the confidential information, we refuse to accept code from such contributors because it greatly increases our review burden and increases the legal risk we take.

Also, this probably goes without saying, but piracy is strictly forbidden both on GitHub and in all other Dolphin channels.

Code licensing

If you make any contributions to Dolphin after December 1st, 2014, you are agreeing that any code you have contributed will be licensed under the GNU GPL version 2 (or any later version).

Coding style introduction

Summary:

• Aims
• Checking and fixing formatting issues

Aims

This guide is for developers who wish to contribute to the Dolphin codebase. It will detail how to properly style and format code to fit this project. This guide also offers suggestions on specific functions and other varia that may be used in code.

Following this guide and formatting your code as detailed will likely get your pull request merged much faster than if you don't (assuming the written code has no mistakes in itself).

This project uses clang-format (stable branch) to check for common style issues. In case of conflicts between this guide and clang-format rules, the latter should be followed instead of this guide.

Checking and fixing formatting issues

Windows users need to be careful about line endings. Windows users should configure git to checkout UNIX-style line endings to keep clang-format simple.

In most cases, clang-format can and should be used to automatically reformat code and solve most formatting issues.

• To run clang-format on all staged files:

  git diff --cached --name-only | egrep '[.](cpp|h|mm)$' | xargs clang-format -i
  

• Formatting issues can be checked for before committing with a lint script that is included with the codebase. To enable it as a pre-commit hook (assuming you are in the repository root):

  ln -s ../../Tools/lint.sh .git/hooks/pre-commit
  

• Alternatively, a custom git filter driver can be used to automatically and transparently reformat any changes:

  git config filter.clang_format.smudge 'cat'
  git config filter.clang_format.clean 'clang-format %f'
  echo '/Source/Core/**/*.cpp filter=clang_format' >> .git/info/attributes
  echo '/Source/Core/**/*.h filter=clang_format' >> .git/info/attributes
  echo '/Source/Core/**/*.mm filter=clang_format' >> .git/info/attributes
  

• Visual Studio supports automatically formatting the current document according to the clang-format configuration by pressing Control+K followed by Control+D (or selecting Edit → Advanced → Format Document). This can be used without separately installing clang-format.

C++ coding style and formatting

Summary:

• General
• Naming
• Conditionals
• Classes and structs

General

• Try to limit lines of code to a maximum of 100 characters.
  • Note that this does not mean you should try and use all 100 characters every time you have the chance. Typically with well formatted code, you normally shouldn't hit a line count of anything over 80 or 90 characters.
• The indentation style we use is 2 spaces per level.
• The opening brace for namespaces, classes, functions, enums, structs, unions, conditionals, and loops go on the next line.
  • With array initializer lists and lambda expressions it is OK to keep the brace on the same line.
• References and pointers have the ampersand or asterisk against the type name, not the variable name. Example: int* var, not int *var.
• Don't use multi-line comments (/* Comment text */), use single-line comments (// Comment text) instead.
• Don't collapse single line conditional or loop bodies onto the same line as its header. Put it on the next line.

  • Yes:

    if (condition)
      return 0;
    
    while (var != 0)
      var--;
    

  • No:

    if (condition) return 0;
    
    while (var != 0) var--;
    

Naming

• All class, enum, function, and struct names should be in upper CamelCase. If the name contains an abbreviation uppercase it.
  • class SomeClassName
  • enum IPCCommandType
• All compile time constants should be fully uppercased. With constants that have more than one word in them, use an underscore to separate them.
  • constexpr double PI = 3.14159;
  • constexpr int MAX_PATH = 260;
• All variables should be lowercase with underscores separating the individual words in the name.
  • int this_variable_name;
• Please do not use Hungarian notation prefixes with variables. The only exceptions to this are the variable prefixes below.
  • Global variables – g_
  • Class variables – m_
  • Static variables – s_

Conditionals

• Do not leave else or else if conditions dangling unless the if condition lacks braces.

  • Yes:

    if (condition)
    {
      // code
    }
    else
    {
      // code
    }
    

  • Acceptable:

    if (condition)
      // code line
    else
      // code line
    

  • No:

    if (condition)
    {
      // code
    }
    else
      // code line
    

Classes and structs

• If making a POD type, use a struct for this. Use a class otherwise.
• Class layout should be in the order, public, protected, and then private.
  • If one or more of these sections are not needed, then simply don't include them.
• For each of the above specified access levels, the contents of each should follow this given order: constructor, destructor, operator overloads, functions, then variables.
• When defining the variables, define static variables before the non-static ones.

class ExampleClass : public SomeParent
{
public:
  ExampleClass(int x, int y);

  int GetX() const;
  int GetY() const;

protected:
  virtual void SomeProtectedFunction() = 0;
  static float s_some_variable;

private:
  int m_x;
  int m_y;
};

C++ code-specific guidelines

Summary:

• General
• Headers
• Loops
• Functions
• Classes and Structs

General

• The codebase currently uses C++20, though not all compilers support all C++20 features.
  • See CMakeLists.txt "Enforce minimum compiler versions" for the currently supported compilers.
• Use the nullptr type over the macro NULL.
• If a range-based for loop can be used instead of container iterators, use it.
• Obviously, try not to use goto unless you have a really good reason for it.
• If a compiler warning is found, please try and fix it.
• Try to avoid using raw pointers (pointers allocated with new) as much as possible. There are cases where using a raw pointer is unavoidable, and in these situations it is OK to use them. An example of this is functions from a C library that require them. In cases where it is avoidable, the STL usually has a means to solve this (vector, unique_ptr, etc).
• Do not use the auto keyword everywhere. While it's nice that the type can be determined by the compiler, it cannot be resolved at 'readtime' by the developer as easily. Use auto only in cases where it is obvious what the type being assigned is (note: 'obvious' means not having to open other files or reading the header file). Some situations where it is appropriate to use auto is when iterating over a std::map container in a foreach loop, or to shorten the length of container iterator variable declarations.
• Do not use using namespace [x]; in headers. Try not to use it at all if you can.
• The preferred form of the increment and decrement operator in for-loops is prefix-form (e.g. ++var).

Headers

• If a header is not necessary in a certain source file, remove them.
• If you find duplicate includes of a certain header, remove it.
• When declaring includes in a source file, make sure they follow the given pattern:
  • The header for the source file
  • Standard library headers
  • System-specific headers (these should also likely be in an #ifdef block unless the source file itself is system-specific).
  • Other Dolphin source file headers
• Each of the above header sections should also be in alphabetical order
• Project source file headers should be included in a way that is relative to the [Dolphin Root]/Source/Core directory.
• This project uses #pragma once as header guards.

Loops

• If an infinite loop is required, do not use for (;;), use while (true).

• Empty-bodied loops should use braces after their header, not a semicolon.

  • Yes: while (condition) {}
  • No: while (condition);

• For do-while loops, place 'while' on the same line as the closing brackets

  do
  {
    // code
  } while (false);
  

Functions

• If a function parameter is a pointer or reference and its value or data isn't intended to be changed, please mark that parameter as const.

• Functions that specifically modify their parameters should have the respective parameter(s) marked as a pointer so that the variables being modified are syntactically obvious.

  • What not to do:

    template<class T>
    inline void Clamp(T& val, const T& min, const T& max)
    {
      if (val < min)
        val = min;
      else if (val > max)
        val = max;
    }
    

    Example call: Clamp(var, 1000, 5000);

  • What to do:

    template<class T>
    inline void Clamp(T* val, const T& min, const T& max)
    {
      if (*val < min)
        *val = min;
      else if (*val > max)
        *val = max;
    }
    

    Example call: Clamp(&var, 1000, 5000);

• Class member functions that you do not want to be overridden in inheriting classes should be marked with the final specifier.

  class ClassName : ParentClass
  {
  public:
    void Update() final;
  };
  

• Overridden member functions that can also be inherited should be marked with the override specifier to make it easier to see which functions belong to the parent class.

  class ClassName : ParentClass
  {
  public:
    void Update() override;
  };
  

Classes and structs

• Classes and structs that are not intended to be extended through inheritance should be marked with the final specifier.

  class ClassName final : ParentClass
  {
    // Class definitions
  };
  

Android

If you are using Kotlin, just use the built-in official Kotlin code style.

To install the Java code style in Android Studio, select the gear icon in the Code Style settings as shown, select Import Scheme... and select dolphin/Source/Android/code-style-java.xml. The Code Style menu should look like this when complete.

You can now select any section of code and press Ctrl + Alt + L to automatically format it.

Help

If you have any questions about Dolphin's development or would like some help, Dolphin developers use #dolphin-emu @ irc.libera.chat to communicate. If you are new to IRC, Libera.Chat has resources to get started chatting with IRC.