49410576e9
The Wii U Gamecube controller adapter setup has always been a bit weird. It tries to be as automatic as possible to make the user experience as easy as possible. The problem with this approach is that it brings a large disconnect in the user experience because you have the Gamecube controller setup with regular gamepads and then for some reason below that you have a "direct connect" option which will cause the Gamecube Adapter to overwrite the regular inputs if something was connected. While this works and allows the user to only click one checkbox to get the device working, it breaks the user's experience because they don't really know what "direct connect" means and won't look it up to figure out what it is. Just expecting the device to work (At least one occurence of this in the IRC channel in the last week). This way around also had the terrible nature of making the code more filthy than it needed to be. The GCAdapter namespace was parasitic and hooked in to the regular GC Controller SI class to overwrite the data that it was getting from the default configuration. Now instead we have a specific SIDevice class for the Wii U Gamecube adapter. This class is fairly simple and is a child of the regular SI Gamecube Pad device and only reimplements what it needs to. This also gives the ability to configure controllers individually, which allows the user to configure rumble individually per pad input. Overall the code is cleaner, and it fits more in line with how the rest of Dolphin works. |
||
|---|---|---|
| .. | ||
| ControllerInterface | ||
| CMakeLists.txt | ||
| ControllerEmu.cpp | ||
| ControllerEmu.h | ||
| GCAdapter.cpp | ||
| GCAdapter.h | ||
| GCPadStatus.h | ||
| InputCommon.vcxproj | ||
| InputCommon.vcxproj.filters | ||
| InputConfig.cpp | ||
| InputConfig.h | ||
| KeyboardStatus.h | ||