ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
33,498 Commits 6 Branches 12 Tags 1.3 GiB
Commit Graph

33498 Commits

Author SHA1 Message Date
LC d3537e68d1
Merge pull request #9273 from leoetlino/msvc-preprocessor-fix 
CMake: Pass various /Zc flags to MSVC for consistency with Base.props
 2020-11-21 09:03:25 -05:00
Léo Lam f53a7a2b66
CMake: Pass various /Zc flags to MSVC for consistency with Base.props 
969ea6e4f5

Fixes non-conformant handling of __VA_ARGS__.
 2020-11-21 14:43:26 +01:00
LC 41b79a66c7
Merge pull request #9270 from leoetlino/dtm-gameid-null 
Core/Movie: Fix a likely out-of-bounds read for PanicAlertT
 2020-11-21 01:53:15 -05:00
Léo Lam 608dd6a37b
Merge pull request #9122 from Pokechu22/pr-4601-test 
Fix Super Mario Sunshine debug cubes (originally PR #4601 by stenzek)
 2020-11-21 02:55:50 +01:00
Léo Lam 83b9feff90
Core/Movie: Fix a likely out-of-bounds read for PanicAlertT 
gameID isn't null terminated since it is just an std::array<char, 6>
and .data() returns a char* so {fmt} would go way beyond the bounds of
the array when it attempts to determine the length of the string.

The fix is to pass a std::string_view to {fmt}. This commit adds
a GetGameID() function that can also be used to simplify
string comparisons.
 2020-11-21 01:30:02 +01:00
Stenzek d6ce8eef36 Software: Use same logic for colors as hardware backends 2020-11-20 15:54:06 -08:00
Stenzek 51724c1ccd LightingShaderGen: Always calculate lighting for both color channels 
Cel-damage depends on lighting being calculated for the first channel
even though there is no color in the vertex format (defaults to the
material color). If lighting for the channel is not enabled, the vertex
will use the default color as before.

The default value of the color is determined by the number of elements in
the vertex format. This fixes the grey cubes in Super Mario Sunshine.

If the color channel count is zero, we set the color to black before the
end of the vertex shader. It's possible that this would be undefined
behavior on hardware if a vertex color index that was greater than the
channel count was used within TEV.
 2020-11-20 15:54:04 -08:00
Léo Lam fa73b1a23f
Merge pull request #9269 from JosJuice/fmt-positional-checks 
Common: Assert that translatable strings use positional arguments
 2020-11-21 00:29:43 +01:00
Léo Lam 33f15f22e2
Merge pull request #9266 from JosJuice/android-startup-illegalstate 
Android: Fix IllegalStateException on startup
 2020-11-20 22:13:30 +01:00
JosJuice e4ceed2bed Common: Assert that translatable strings use positional arguments 
Like PR 9260, but for a different requirement (see PR 9253).
 2020-11-20 20:24:30 +01:00
JosJuice e63b00e562 Fix translatable strings which contain non-positional arguments 2020-11-20 20:24:30 +01:00
JosJuice 730f9cb7bd Android: Fix IllegalStateException on startup 
See https://github.com/dolphin-emu/dolphin/pull/9095#pullrequestreview-535576465
 2020-11-20 18:33:00 +01:00
JosJuice 17da28ff07
Merge pull request #9267 from leoetlino/fix-lambda-captures 
Core: Fix invalid lambda captures
 2020-11-20 18:32:47 +01:00
Léo Lam 542c49bab0
Core: Fix invalid lambda captures 
PR #9260 made the MsgAlert macros use lambdas so that local
constexpr variables can be added while keeping the ability to
return a boolean from the macros.

Unfortunately, C++17 forbids referring to structured bindings in lambda
captures. This is fixed in P1091R3 but we cannot rely on C++20 yet...
 2020-11-20 18:27:56 +01:00
Léo Lam f45a4a5916
Merge pull request #9263 from lioncash/core-log2 
Core: Convert logging over to fmt pt.2
 2020-11-20 16:36:47 +01:00
LC 7f5cecf7ef
Merge pull request #9264 from leoetlino/fix-fmt-log 
DSP: Fix one DEBUG_LOG call
 2020-11-20 10:21:48 -05:00
Léo Lam 88cc1b7c8a
DSP: Fix one DEBUG_LOG call 2020-11-20 16:21:05 +01:00
Lioncash a0f9b041a0 Core: Convert logging over to fmt pt.2 
Continues the core migration of logs up to the EXI handling code.
 2020-11-20 10:05:44 -05:00
Léo Lam 419dfe4be4
Merge pull request #9260 from leoetlino/fmt-checks 
Common/Log: Add compile-time format string checks
 2020-11-20 16:05:25 +01:00
Léo Lam 1d4672455c
Merge pull request #9130 from flto/master 
Vulkan: fix validation error in bSupportsGeometryShaders=false case
 2020-11-20 12:35:40 +01:00
Jonathan Marek a20e69ff51
Vulkan: fix validation error in bSupportsGeometryShaders=false case 
In CreateDescriptorSetLayouts(), one less dynamic binding is created when
bSupportsGeometryShaders=false. Reduce the dynamicOffsetCount argument by
one in that case. Avoids this validation error:

Attempting to bind 3 descriptorSets with 2 dynamic descriptors, but
dynamicOffsetCount is 3. It should exactly match the number of dynamic
descriptors. The Vulkan spec states: dynamicOffsetCount must be equal to
the total number of dynamic descriptors in pDescriptorSets

Signed-off-by: Jonathan Marek <jonathan@marek.ca>

[Applied clang-format]
Signed-off-by: Léo Lam <leo@leolam.fr>
 2020-11-20 12:23:34 +01:00
Léo Lam c580a70a12
Merge pull request #9210 from Dentomologist/regions-show-hide-all 
DolphinQt: Add Show/Hide All options to gamelist region menu
 2020-11-20 11:35:22 +01:00
Léo Lam a4aec0556b
Merge pull request #9212 from nf6429/master-diff 
Game INI Changes
 2020-11-20 11:10:52 +01:00
Dentomologist 7ded075561 DolphinQt: Add Show/Hide All options to gamelist region menu 2020-11-19 20:39:49 -08:00
Léo Lam 858d7612ef
Merge pull request #9170 from JosJuice/android-extension-hack-2 
Android: Remove hacks for Wii Remote extension setting, round 2
 2020-11-20 02:47:23 +01:00
Léo Lam 30bffca5c3
Merge pull request #9193 from JosJuice/android-clear-motioncontrolsenabled 
Android: Re-add motionControlsEnabled to clearWiimoteNewIniLinkedPreferences
 2020-11-20 02:37:51 +01:00
Léo Lam 7f7fd4d8d3
Merge pull request #9220 from jordan-woyak/ext-crypto 
WiimoteEmu: Implement extension encryption edge case.
 2020-11-20 02:28:17 +01:00
Léo Lam bca82bb942
Merge pull request #9239 from altimumdelta/FFDUMP_Separate_Logging 
FrameDump Logging: Separate log type and migrate to fmt
 2020-11-20 02:21:57 +01:00
Léo Lam 5921a93d71
Merge pull request #9247 from Dentomologist/fix-updater-temporary-folder 
Fix updater not always cleaning up temp directory
 2020-11-20 02:01:43 +01:00
Léo Lam eff566b318
Merge pull request #9258 from lioncash/core-log 
Core: Convert logging over to fmt pt. 1
 2020-11-19 20:32:19 +01:00
Lioncash 958cbf38a4 Core: Convert logging over to fmt pt. 1 
Converts up to the DSP-related files for easier reviewing, the rest will
be progressively moved over after this change gets merged.
 2020-11-19 14:21:06 -05:00
Léo Lam e3247b567d
Merge pull request #9185 from Losuc/skipEFBaccessHotkey 
Add a Skip EFB Access Hotkey
 2020-11-19 17:28:45 +01:00
Léo Lam c724447f80
Merge pull request #9259 from Strum355/utf8-source 
Fixed non-UTF8 chars in PeakFinder.cpp
 2020-11-19 17:23:00 +01:00
Léo Lam dde6090e98
Common/MsgHandler: Add compile-time format string checks 2020-11-19 17:09:24 +01:00
Léo Lam 62eeb05519
Common: Validate the number of {} fields in format strings 
Unfortunately, {fmt} allows passing too many arguments to a format call
without raising any runtime or compile-time error [1].

As this is a common source of bugs since we started migrating to {fmt},
this commit adds some custom logic to validate the number of
replacement fields in format strings in addition to {fmt}'s own checks.

[1] https://github.com/fmtlib/fmt/issues/492
 2020-11-19 17:09:24 +01:00
Léo Lam 47c91696ee
Common/Log: Check format strings 
Helps with catching incorrect format strings.

PanicAlertFmt already uses FMT_STRING and fmt::make_args_checked.
 2020-11-19 17:09:24 +01:00
Léo Lam 7e9a2dcc72
Merge pull request #9261 from AdmiralCurtiss/shop-logs 
WiiUtils: Create Wii Shop log files when installing a WAD.
 2020-11-19 16:49:34 +01:00
Admiral H. Curtiss 83c235b7cb WiiUtils: Create Wii Shop log files when installing a WAD. 
Fixes https://bugs.dolphin-emu.org/issues/12269
 2020-11-19 03:26:27 +01:00
Noah Santschi-Cooney 4d26f6ad95
Fixed non-UTF8 chars in PeakFinder.cpp 2020-11-18 19:50:40 +00:00
JosJuice 59c362d002 Translation resources sync with Transifex 2020-11-18 18:14:57 +01:00
Léo Lam 4eecb8fd11
Merge pull request #9248 from lioncash/video-fmt 
VideoCommon: Migrate over to fmt
 2020-11-18 11:10:48 +01:00
Lioncash 3d9b2aa005 VideoCommon: Migrate over to fmt 
Migrates off the printf-based formatting where applicable.
 2020-11-17 21:23:58 -05:00
Léo Lam eb1581bbcc
Merge pull request #9246 from JosJuice/translation-eot 
DolphinQt: Don't return 0x04 bytes from tr
 2020-11-18 02:31:13 +01:00
Léo Lam 31d7be521c
Merge pull request #7714 from cristian64/avoid_leaking_gamelistmodel 
DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit
 2020-11-18 02:14:51 +01:00
Léo Lam 0339889806
Merge pull request #9251 from sepalani/sockopt 
IP/Top: Add missing sockopt
 2020-11-18 02:10:37 +01:00
Léo Lam b8bc6c3c86
Merge pull request #9256 from JosJuice/android-keep 
Android: Add @Keep annotation to things accessed using JNI
 2020-11-18 01:01:34 +01:00
Léo Lam 8119318907
Merge pull request #9257 from JosJuice/redundant-i18n 
Remove a redundant i18n comment
 2020-11-18 00:56:58 +01:00
JosJuice 52c615f1b1 Remove a redundant i18n comment 2020-11-17 18:23:27 +01:00
Léo Lam 07be82d64f
Merge pull request #9253 from JosJuice/positional-arguments 
Use positional arguments in all translatable fmt strings
 2020-11-17 18:02:39 +01:00
JosJuice a8d385c705 Android: Add @Keep annotation to things accessed using JNI 
This acts as a hint to both people and automated tools
that a variable or method shouldn't be renamed or removed.
 2020-11-17 14:11:51 +01:00