Lioncash
cdfabb4524
SkylandersPortalWindow: Directly connect slot in CreateSlotLayout
...
The interface corresponds with what QCheckBox::toggled wants, so we can
use the member function directly.
2023-11-25 22:16:39 -05:00
Lioncash
24c009f7ce
SkylandersPortalWindow: Mark helpers as const/static where applicable
...
These helpers don't directly modify class state.
2023-11-25 21:44:07 -05:00
Lioncash
6d47d6c08e
SkylandersPortalWindow: Remove unnecessary string conversions
...
Same behavior without a bit of churn.
2023-11-25 21:33:25 -05:00
Tilka
c16e98a31f
Merge pull request #12323 from lioncash/virt
...
CustomAssetLibrary: Add virtual destructor
2023-11-26 00:54:11 +00:00
Lioncash
04011373f3
CustomAssetLibrary: Remove unnecessary qualifier in LoadInfo
...
The type is already in visible scope, so we don't need the rather length
qualifier.
2023-11-25 18:01:44 -05:00
Lioncash
b85902ccb5
CustomAssetLibrary: Add virtual destructor
...
This is used as a base pointer inside CustomPipelineAction, so this
should probably really have a virtual destructor to ensure derived
objects are torn down properly.
2023-11-25 18:01:17 -05:00
Tilka
88cd618b4d
Merge pull request #12322 from lioncash/guards
...
WC24Send: Add missing header guard
2023-11-25 23:01:07 +00:00
Lioncash
644f7f6e55
WC24Send: Add missing header guard
...
Prevents double inclusions from occurring in the same TU.
2023-11-25 17:53:46 -05:00
Admiral H. Curtiss
76d605639b
Merge pull request #11881 from JosJuice/aarch64-function-call
...
JitArm64: Add utility for calling a function with arguments
2023-11-25 17:30:42 +01:00
Admiral H. Curtiss
d89a0423d1
Merge pull request #12310 from oltolm/update_cubeb
...
Externals: Update cubeb to mozilla/cubeb@54217bca3f
2023-11-24 21:52:51 +01:00
Admiral H. Curtiss
afb4be1a90
Merge pull request #12311 from kemenaran/fix-metal-adapter-unknown-selector
...
Metal: fix crash by enabling concurrent compilation only if available
2023-11-24 21:52:32 +01:00
Tilka
3b74a9195d
Merge pull request #12313 from Tilka/gormiti
...
GameSettings: port Gormiti black screen fix to PAL version
2023-11-24 20:38:35 +00:00
Tillmann Karras
921d4f1e60
GameSettings: port Gormiti black screen fix to PAL version
...
Same workaround as @Pokechu22's NTSC version
(8316c7af99
).
2023-11-24 19:21:40 +00:00
Pierre de La Morinerie
0ecfaf3b9e
Metal: enable concurrent compilation only if available
...
Bug: https://bugs.dolphin-emu.org/issues/13404
On macOS 13.6 / Intel HD 5000, Dolphin crashes with this message:
> -[MTLIGAccelDevice setShouldMaximizeConcurrentCompilation:]: unrecognized selector
This should be available on all macOS 13.3+ systems – but when using OCLP drivers,
some devices use an older version of Metal.framework, which doesn't expose the selector.
This concerns Intel Ivy Bridge, Haswell and Nvidia Kepler when using OCLP on macOS 13.3
or newer.
(See
34676702f4/docs/PATCHEXPLAIN.md
?plain=1#L354C1-L354C83)
As the behavior is an optional optimization anyway, perform a dynamic
detection to avoid crashing if the feature is not available.
2023-11-24 15:09:25 +01:00
Admiral H. Curtiss
feeac104d8
Merge pull request #12304 from sepalani/pcap-io
...
BBA/HLE: Fix random PCAP file corruption
2023-11-23 19:26:00 +01:00
Sepalani
91020ac4fa
BBA/HLE: Fix random PCAP file corruption
...
Concurrency between RecvHandlePacket and SendFromDirectFIFO
2023-11-23 22:07:44 +04:00
Admiral H. Curtiss
937cb8ef3a
Merge pull request #12299 from TryTwo/PR_bugfix_frame_advance
...
Core: Add option to not report state change to SetState (bugfix)
2023-11-22 23:10:51 +01:00
Admiral H. Curtiss
ab76b15e05
Merge pull request #12305 from SuperSamus/expr-buffer-size
...
expr: increase size of `varname`
2023-11-22 23:05:55 +01:00
Admiral H. Curtiss
1cfa29f090
Merge pull request #12303 from Pokechu22/dsp-hle-aesnd-2023
...
DSPHLE: Support 2023 libaesnd uCode
2023-11-22 23:05:38 +01:00
oltolm
85133bbd8e
Externals: Update cubeb to mozilla/cubeb@54217bca3f
2023-11-22 21:26:20 +01:00
Tilka
3a3a935b9a
Merge pull request #12309 from Tilka/ios_crash
...
IOS: fix crash when closing invalid file descriptor
2023-11-21 12:37:22 +00:00
Tillmann Karras
77a1eaa740
IOS: fix crash when closing invalid file descriptor
...
This regression was introduced in 5.0-20284.
2023-11-21 12:00:34 +00:00
Tilka
f79c88f30b
Merge pull request #12302 from JosJuice/jit-replace-vectors
...
Jit: Get rid of short-lived std::vectors
2023-11-20 18:11:15 +00:00
Pokechu22
2d7a078d53
DSPHLE: Support 2023 libaesnd uCode
...
Fixes https://bugs.dolphin-emu.org/issues/13401
2023-11-19 10:16:47 -08:00
Martino Fontana
5792eefdaf
expr: increase size of `varname`
2023-11-18 23:53:19 +01:00
JosJuice
c3c0c7dc1c
Jit: Get rid of short-lived std::vectors
...
Let's aim for making as few heap allocations as possible while jitting.
2023-11-18 23:15:37 +01:00
Admiral H. Curtiss
dc0814ae46
Merge pull request #12301 from Tilka/ax_volume
...
AX: fix envelope volume for Wii ucodes
2023-11-17 18:18:16 +01:00
Tillmann Karras
da1bf29722
AX: fix envelope volume for Wii ucodes
...
Technically it is signed in the 0x7699af32 ucode but that's only used
by the Wii Startup Disc which never uses negative values.
2023-11-16 21:43:45 +00:00
TryTwo
b57ba42a55
Core::SetState() allow state to change without sending a callback.
...
Some state changes are meant to be near instantanoues, before switching to something else. By reporting ithe instant switch, the UI will flicker between states (pause/play button) and the debugger will unnecessarily update. Skipping the callback avoids these issues.
2023-11-16 11:07:37 -07:00
TryTwo
df8c0d2b39
Core::GetState() bugfix: remove forced incorrect state on frame advance.
...
This was implemented to prevent UI flickering due to the state rapidly switching between pause/play. Recently, it has been causing issues with debugger windows, which update during frame advance.
2023-11-16 10:41:53 -07:00
JosJuice
b40a824f92
Translation resources sync with Transifex
2023-11-15 21:19:12 +01:00
Admiral H. Curtiss
6309aa0010
Merge pull request #12175 from Sam-Belliveau/correct-area-sampling
...
Corrected Area Sampling Range
2023-11-15 01:49:45 +01:00
Admiral H. Curtiss
3975d5e923
Merge pull request #12176 from Filoppi/patch-22
...
Make AutoHDR work with color luminance instead of average
2023-11-14 19:53:35 +01:00
Sam Belliveau
7894b40111
Fix inner area sampling loop from going beyond bounds
2023-11-14 12:05:12 -05:00
Tilka
87c27936fc
Merge pull request #12238 from AdmiralCurtiss/achievementheaderwidget-unused-variables
...
DolphinQt/AchievementHeaderWidget: Remove unused member variables.
2023-11-12 21:24:17 +00:00
Tilka
aa1311cd78
Merge pull request #12268 from JosJuice/fastmem-terminology
...
Jit: Define new terms related to fastmem
2023-11-12 19:44:45 +00:00
Tilka
166423ad61
Merge pull request #12273 from Dentomologist/dolphinqt_remove_unnecessary_qoverloads
...
DolphinQt: Remove unnecessary qOverloads
2023-11-12 19:43:05 +00:00
Tilka
4b38560323
Merge pull request #12282 from Wack0/mmu-tlb-patch
...
MMU: Use VSID in segment register as additional TLB lookup key
2023-11-12 19:41:23 +00:00
Tilka
15a3200b70
Merge pull request #12288 from Pokechu22/bp-stride-scale-fallthrough
...
Fix accidental fallthrough in BPStructs
2023-11-12 19:35:37 +00:00
Tilka
4285e9d8aa
Merge pull request #12276 from Tilka/ax_volume
...
AX: make volume field signed
2023-11-12 19:35:15 +00:00
Pokechu22
3984d1964b
Fix accidental fallthrough in BPStructs
...
This caused us to update the indirect texture information in shaders more often than we needed to, which probably doesn't matter in practice since it's only used in ubershaders and copyyscale and stride are generally only updated before EFB/XFB copies, which generally will have other changes afterwards.
2023-11-12 10:39:56 -08:00
Tilka
e7b922ee62
Merge pull request #12286 from Pokechu22/more-bp-register-descriptions
...
Add descriptions for more BP registers
2023-11-12 07:59:32 +00:00
Pokechu22
da8407e01c
Add descriptions for more BP registers
2023-11-11 23:32:17 -08:00
Pokechu22
dfdb9a4a07
Clarify per-texture tmem information in the fifo analyzer
2023-11-11 23:32:17 -08:00
Pokechu22
ea41d0e384
Convert BPMEM_LOADTLUT1 to a struct
2023-11-11 23:32:17 -08:00
Pokechu22
2a1d445b30
Enhance description of BPMEM_PRELOAD_MODE in the fifo analyzer
2023-11-11 23:32:17 -08:00
Pokechu22
6bad17b170
Rename bpmem.copyMipMapStrideChannels to bpmem.copyDestStride
...
As far as I can tell, it has nothing to do with the mipmap/half_scale functionality, but does change based on the width of the destination texture (and the destination texture is half the width if half_scale is set). The comment that was there (which dates back to the initial megacommit) seems to not have accounted for the width aspect; it was first used as an actual stride in bbbe898839
(the first commit that used it at all).
2023-11-11 23:32:14 -08:00
Tilka
e5d2deb017
Merge pull request #12287 from Tilka/blending
...
VideoCommon: copy software renderer logic for blend mode priorities
2023-11-12 07:31:13 +00:00
Tillmann Karras
ac9079f2ca
VideoCommon: copy software renderer logic for blend mode priorities
...
I've not tested this on hardware, but it fixes issue 12271 (shadow
people in Deal or No Deal - Special Edition).
2023-11-12 05:51:28 +00:00
Pokechu22
9543555bfe
Fix typo in comment for bpmem.texcoords
2023-11-11 16:13:37 -08:00