61b977c914
WiiWad: Make WiiWAD constructor explicit
2016-09-25 18:04:11 -04:00
7de0d51345
WiiWad: Move static implementation details to cpp file
...
These functions don't actually depend on any state from the class
instance, so they don't really belong in the header, and are just
an implementation detail.
2016-09-25 18:04:04 -04:00
144c23dead
Filesystem: Return strings from GetFileName without the const qualifier
...
This is mostly pointless and can inhibit move construction
2016-09-18 12:56:25 -04:00
5aeedcd27c
NANDContentLoader: Remove unnecessary trailing semicolons
2016-09-14 20:12:25 -04:00
b43a26b90c
NANDContentLoader: Remove virtual specifier from CNANDContentLoader destructor
...
This class is marked final, so there's no need to declare it as virtual.
2016-09-14 19:45:52 -04:00
3196bf5392
NANDContentLoader: Specify constructors as explicit where applicable
...
Prevents implicit conversion.
2016-09-14 19:44:44 -04:00
89c65be703
NANDContentLoader: Delay vector construction until needed in Get()
...
No need to construct the vector right off the bat.
2016-09-14 19:41:41 -04:00
b1ffa74043
NANDContentLoader: Make CNANDContentData's Get function return by non-const value
...
const specifiers like this are practically pointless and can inhibit move construction.
2016-09-14 19:15:31 -04:00
eccec3c6d3
DiscIO: Fix NAND Memory Leak
...
CNANDContentData is a base class with a non-virtual destructor so
derived classes don't get destroyed causing them to leak resources.
2016-09-14 15:54:05 +10:00
c1184957a5
Run clang-format on missed files
...
`clang-format`s files that lint missed because of the bug. Fortunately,
not much.
2016-08-11 21:14:39 +02:00
0a15aaaa12
Move DiscIO enums to a new file
...
At first there weren't many enums in Volume.h, but the number has been
growing, and I'm planning to add one more for regions. To not make
Volume.h too large, and to avoid needing to include Volume.h in code
that doesn't use volume objects, I'm moving the enums to a new file.
I'm also turning them into enum classes while I'm at it.
2016-07-13 17:29:27 +02:00
f4d2626d2b
Merge pull request #4005 from EmptyChaos/blockcache-bug
...
SectorReader: Minor cache bias bug
2016-07-13 12:11:19 +02:00
53e7eed28d
DiscScrubber: Fix issue 9356
2016-07-11 11:46:15 +02:00
9036b9d8e8
SectorReader: Fix cache line bias
...
Minor bug where SectorReader::GetEmptyCacheLine was biased towards
the first hit.
2016-07-09 02:27:35 +10:00
31226b8503
DiscScrubber: Replace unused blocks with 0x00 instead of 0xFF
2016-07-07 11:51:58 +02:00
1878605d77
Undo some comment formatting changes from b5104a7
2016-06-25 18:07:10 +02:00
b5104a79f1
GCVolume: supports reading all opening.bnr information
...
DQT2: Game properties dialog contains info tab giving information about the selected iso.
2016-06-26 00:03:59 +10:00
3570c7f03a
Reformat all the things. Have fun with merge conflicts.
2016-06-24 10:43:46 +02:00
c4240692b6
SectorReader: Fix reading the last block of the disc.
...
Regression from PR #3795 .
2016-05-29 18:26:04 +02:00
97d570f0c9
DriveReader: Fix View > Show Drives
...
DriveReader::m_size was never initialized which was indirectly
causing CGameListCtrl to crash Dolphin when it tried to insert a
character at a negative index in a string.
Reading one sector at a time is very inefficient and appears to
be causing timing issues during boot so SectorReader has been
enhanced to support batching.
SectorReader has been given a working cache system.
2016-04-26 21:24:08 +10:00
a449ef4e11
properly open/close the file to avoid rapid open/close cycles
...
ES_OPENCONTENT and ES_CLOSECONTENT now call Open and Close respectively,
as the old code did.
2016-03-20 13:10:51 +01:00
8a6d9e1e0b
hide the distinction between WAD and File from ES
...
instead, leave all the management with the NANDContentLoader.
for file data (directly on the NAND), this opens the file on-demand and
returns the requested chunk when asked for it.
for on-the-fly decrypted WAD data, we just keep the decoded buffer in
memory, like we've done before - except that we don't give away any objects
we don't want to.
2016-03-20 13:10:50 +01:00
1e28d06f26
fix some style inconsistencies that drove me nuts
2016-03-20 13:10:47 +01:00
92278886b9
DiscIO: Use specified Wii region for discs
2016-01-15 03:35:10 +08:00
bff79df363
Merge pull request #3429 from sepalani/debug_vector_fix
...
Debug Builds: Fixed vector assertion
2016-01-07 00:48:40 +01:00
81466d7fa3
DolphinWX: Stop using XPM images
...
Using the XPM format for images has become a maintenance problem because
people don't know how to create them. This commit removes all XPM images
and all C files that contain PNG images. DolphinWX now uses the PNGs
in the Resources folder instead, just like DolphinQt and DolphinQt2 do.
2016-01-05 19:11:58 +01:00
ba794272f5
Debug Builds: Fixed vector assertion
2016-01-03 13:17:26 +01:00
1b69743ba1
Merge pull request #3362 from lioncash/memory
...
NANDContentLoader/WiiWAD: Get rid of raw delete and new
2015-12-22 06:39:12 -05:00
aaa89d4f73
Silence -Wshadow and -Wmaybe-uninitialized warnings.
2015-12-21 10:06:07 -06:00
cbeb7034eb
Volume: Make GetTMD return a vector
2015-12-19 18:00:44 -05:00
c78c54c546
NANDContentLoader/WiiWAD: Get rid of raw delete and new
2015-12-19 17:37:09 -05:00
c310b3f0e6
Merge pull request #3309 from JosJuice/reload-banner-without-volume
...
Don't read from volume when reloading Wii banners
2015-12-15 18:48:49 +01:00
2990df3f59
Merge pull request #3265 from JosJuice/volumedirectory-simplifications
...
DiscIO: Small VolumeDirectory simplifications
2015-12-15 18:36:49 +01:00
25a584626f
Merge pull request #3127 from JosJuice/read-return
...
DiscIO: Improve error handling for reading integers
2015-12-15 18:16:40 +01:00
e4b83d17bf
Merge pull request #3270 from JosJuice/more-translations
...
Mark more strings for translation
2015-12-15 18:13:26 +01:00
cbfab2a754
DiscIO: Improve DiscScrubber::ReadFromVolume error handling
2015-12-14 10:01:38 +01:00
bd67333da9
DiscIO: Improve CBlobBigEndianReader error handling
2015-12-14 09:56:44 +01:00
c01265db34
DiscIO: Unify CBlobBigEndianReader
2015-12-14 09:38:23 +01:00
c7e747d775
DiscIO: Improve IVolume::Read32 error handling
...
Callers can now check whether reads fail, either by checking the return
value or by setting the buffer to a known bad value and seeing if it stays
untouched. I've added error checks to FileSystemGCWii and Boot_BS2Emu,
but not to Boot since it doesn't check any of its other reads either.
2015-12-14 09:38:21 +01:00
5a7e0aba70
Fix building with PCH disabled.
2015-12-08 16:57:37 -06:00
6295297ab3
DiscIO: Get rid of a few explicit deletes
2015-12-08 04:35:56 -05:00
edbbf493f8
DiscIO: Make factory methods return unique_ptrs
...
Rather than rely on the developer to do the right thing,
just make the default behavior safely deallocate resources.
If shared semantics are ever needed in the future, the
constructor that takes a unique_ptr for shared_ptr can
be used.
2015-12-07 05:57:37 -05:00
a0cd753060
Don't read from volume when reloading Wii banners
...
Should make loading cached Wii games that lack banners slightly faster.
2015-12-03 17:29:59 +01:00
f9af58a388
DiscIO: Don't use PlainFileReader in VolumeDirectory
...
Blobs are not for regular file reading.
2015-11-28 09:18:22 +01:00
941125699c
Added info for Rodea The Sky Soldier
2015-11-21 11:40:03 -05:00
74ea765427
Mark more strings for translation
2015-11-20 11:33:47 +01:00
584ea8b320
Merge pull request #3206 from JosJuice/limit-filesystem-size-2
...
Limit size of loaded file systems
2015-11-18 10:43:47 +01:00
3a9e382661
DiscIO: Small VolumeDirectory simplifications
2015-11-17 10:09:54 +01:00
eddea7f15f
Merge pull request #3181 from JosJuice/scrub-directories
...
Don't reserve space for directories when scrubbing
2015-11-17 10:37:09 +13:00
df79398445
DiscIO: drop unused stuff
2015-11-10 17:03:08 +01:00
Lioncash