Pokechu22
9183c0c482
Bump state version
2020-07-29 16:57:37 -07:00
Pokechu22
e5e23c6b27
Mark several DVDInterface functions as static
2020-07-29 16:57:36 -07:00
Pokechu22
4415df463f
Remove DVDInterface::Reset
...
It only resets the registers, which isn't something that needs to be done except for in DVDInterface::Init
2020-07-29 16:57:36 -07:00
Pokechu22
0fa96df818
Remove DriveState::DiscChangeDetected hack
...
Since both GameCube and Wii resets now work correctly, this hack is not needed anymore.
2020-07-29 16:57:36 -07:00
Pokechu22
a73eaf5712
Fix DVDLowReset spinup flag being read incorrectly
2020-07-29 16:57:35 -07:00
Pokechu22
9a8d426645
Implement PI_RESET_CODE resetting DI
2020-07-29 16:57:35 -07:00
Pokechu22
b8715b42d2
Only reset drive chip state (not DI registers) when changing discs
...
Resetting the DI registers disables interrupts, which means any errors reported (for instance) are just not sent though.
2020-07-29 16:57:35 -07:00
Pokechu22
537e40afb5
Only update DIMAR and DILENGTH if transfer completed without error
...
Turns out, Gamecube games actually do check DILENGTH, and if DILENGTH is at 0, they'll think the transfer completed successfully even if DEINT is used, since after all, surely that means everything was sent. That caused all sorts of issues, from audio looping when a disc is removed since it's re-using the same buffer to just flat-out crashing instead of showing the disc removed screen.
2020-07-29 16:57:35 -07:00
Pokechu22
fba51b2956
Split drive state and drive error into 2 fields, and fix some inaccuracies
...
In particular:
- Trying to play audio in a non-ready state returns the state-specific error, not an audio buf error
- Audio status cannot be requested in non-ready states
- The audio buffer cannot be configured in states other than ReadyNoReadsMade
- Using the stop motor command while the motor is already stopped doesn't change states
Additionally, the internal state IDs are used (which distinguish ReadyNoReadsMade and Ready), instead of the state IDs exposed in request error. This makes some of the weird behavior a bit more obvious.
State and error behavior of the seek command was not implemented in this commit.
2020-07-29 16:57:34 -07:00
LC
b354e343a7
Merge pull request #8988 from JosJuice/no-refresh-rate-round
...
VideoCommon: Don't round the refresh rate
2020-07-28 17:17:34 -04:00
LC
5066d4d239
Merge pull request #8989 from JosJuice/android-minimal-post-processing
...
Android: Set preferMinimalPostProcessing="true"
2020-07-28 17:16:47 -04:00
JosJuice
9c44ad11e3
Android: Set preferMinimalPostProcessing="true"
...
When using the combination of Android 11 and HDMI 2.1,
this will send a signal to the TV suggesting it to switch to
a low latency mode ("game mode").
2020-07-28 22:21:57 +02:00
JosJuice
f72b756778
VideoCommon: Don't round the refresh rate
...
We now provide a double to the FPS counter and exact values
to FIFO recording and frame dumping.
2020-07-28 21:01:38 +02:00
Lioncash
f9b856aeda
WiimoteEmu: Mark several getters as const
...
These don't modify internal class state, so they can be made const.
2020-07-24 15:48:27 -04:00
Tillmann Karras
062dd5ab0a
DolphinQt: fix -Wunused-variable warning
2020-07-24 17:44:32 +01:00
Tillmann Karras
5bd2b2699c
DolphinQt: fix -Wsign-compare warning
2020-07-24 17:44:32 +01:00
Tillmann Karras
750cb1f830
DolphinQt: fix -Wunused-but-set-variable warning
2020-07-24 17:41:37 +01:00
Tillmann Karras
bf5b1092b2
DiscIO: fix -Wreorder warning
2020-07-24 17:41:37 +01:00
Tillmann Karras
04b31e7eee
IOS: work around incorrect -Wunused-but-set-variable warning
...
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96311
2020-07-24 16:38:54 +01:00
Tillmann Karras
fbd34f72ad
EXI: fix -Wunused-variable warning
2020-07-24 15:35:35 +01:00
Tillmann Karras
7b2e93eea8
EXI: fix -Wreorder warning
2020-07-24 15:35:24 +01:00
JMC47
781662c6ad
Merge pull request #8793 from iwubcode/dump-texture-options
...
DolphinQt / VideoCommon: Add additional texture dumping options
2020-07-24 01:38:10 -04:00
JosJuice
213c1841f7
Merge pull request #8903 from AdmiralCurtiss/gcmemcard-file-identity-check
...
GCMemcard: Change behavior of TitlePresent() to more closely resemble how saves are actually identified.
2020-07-23 17:44:16 +02:00
iwubcode
9c8338ec4c
DolphinQt / VideoCommon: Add additional texture dumping options. Specifically, this enables users to choose whether to dump mip maps, base level textures, or both.
2020-07-22 19:30:27 -05:00
LC
d7a91316da
Merge pull request #8974 from Filoppi/patch-4
...
Fix disc image conversion button not being clear #3
2020-07-22 17:24:23 -04:00
LC
bf49849f88
Merge pull request #8971 from JosJuice/simplify-issettingsaveable
...
Config: Simplify IsSettingSaveable
2020-07-22 16:27:34 -04:00
Filippo Tarpini
f6ba54b74e
Fix disc image conversion button not being clear #3
...
It wasn't clear whether the conversion would create a new file or replace the old one
Recreated #8952 directly from github
2020-07-22 23:00:20 +03:00
Ryan Meredith
9ac24a0580
Android: Some simple Clang-Tidy suggestions
2020-07-22 15:38:45 -04:00
JosJuice
26536832c3
Config: Simplify IsSettingSaveable
...
Should make it both easier to edit and faster to run.
2020-07-22 11:46:47 +02:00
JosJuice
e9cc89af83
Android: Remove hacks for Wii Remote extension and video backend settings
2020-07-20 15:25:53 +02:00
LC
ae2348023b
Merge pull request #8964 from JosJuice/list-wad-file-type
...
DolphinQt: Show WAD as "WAD" instead of "" in file format column
2020-07-19 17:35:34 -04:00
JosJuice
fe5e92f706
DolphinQt: Show WAD as "WAD" instead of "" in file format column
...
https://bugs.dolphin-emu.org/issues/12190
2020-07-19 21:30:48 +02:00
Jordan Woyak
ae44f17667
HW/GCPadEmu: Adjust gate radius values to more closely match the real hardware.
2020-07-19 09:45:33 -05:00
LC
487cd7abd9
Merge pull request #8905 from JosJuice/jni-encoding
...
Android: Use correct encoding when converting strings
2020-07-18 22:13:14 -04:00
Filip Gawin
0ede5d1537
Use range loop (if possible)
2020-07-18 18:29:16 -05:00
JosJuice
aa4896fb3f
DolphinQt: Add i18n comment for "Surround"
2020-07-17 19:10:31 +02:00
Jordan Woyak
8b3e9e6a81
DolphinQt: Replace unusual Qt::InitialSortOrderRole usage with a custom role.
2020-07-16 20:27:07 -05:00
LC
a7e475e57b
Merge pull request #8958 from jordan-woyak/sort-fix
...
DolphinQt: Fix default sort direction of game list.
2020-07-16 21:20:43 -04:00
Jordan Woyak
ecf016e80a
DolphinQt: Fix default sort direction of game list.
2020-07-16 19:21:14 -05:00
Techjar
037aa2192f
NetPlay: Limit nickname length
...
Ridiculously long nicknames cause UI silliness, so 30 characters seems
like a reasonable limit, as it's the same as the forum.
2020-07-16 19:03:54 -04:00
Techjar
92812d0b0b
QtUtils: Add UTF8CodePointCountValidator
2020-07-16 19:03:46 -04:00
LC
c59648337a
Merge pull request #8955 from JosJuice/android-no-ashmem
...
Android: Don't access /dev/ashmem on newer Android versions
2020-07-16 14:23:51 -04:00
JosJuice
00cde7cbbd
Android: Don't access /dev/ashmem on newer Android versions
...
Fixes a critical regression where 95945a0
made us unable to
start emulation on Android 10 and newer. Android is restricting
direct access to /dev/ashmem starting with the new SDK version,
but we can use the new (and simpler) ASharedMemory API instead.
We have to keep using the /dev/ashmem approach on old versions
of Android, though.
2020-07-16 20:06:58 +02:00
JosJuice
f2cc3a2948
Add Android check for strerror_r variant
...
I don't know why Android does it like this, but at least
it's easy to fix. (We are currently at __ANDROID_API__ == 21.)
2020-07-16 18:51:58 +02:00
Admiral H. Curtiss
556e93f357
GCMemcard: Change behavior of TitlePresent() to more closely resemble how saves are actually identified.
...
This modifies GCMemcard::TitlePresent() to match my findings of how the GC BIOS and various games behave when you alter the fields in the directory entry.
It looks like for a save to be recognized by a game, the following have to be true:
- Game code and maker code must exactly match what the game expects.
- Filename is only checked up to the first null byte. All bytes afterwards can be whatever.
The BIOS itself does a full compare of the filename when checking for whether it should allow copying a file from one card to another, but behaves oddly in some cases when there's non-null bytes after the first null. See the big comment in `HasSameIdentity()` for details.
2020-07-15 19:17:22 +02:00
LC
b6ee3228be
Merge pull request #8953 from JosJuice/android-target-sdk-29
...
Android: Increase targetSdkVersion to 29
2020-07-14 12:51:44 -04:00
Tilka
a98df567b1
Merge pull request #8949 from JosJuice/android-cache
...
Android: Use system cache directory as cache directory
2020-07-13 12:21:21 +01:00
Tilka
695a96498a
Merge pull request #8922 from Filoppi/timer-fixes
...
Timer fixes
2020-07-13 00:16:45 +01:00
JMC47
3c70fb7277
Merge pull request #8950 from jordan-woyak/double-time-fix
...
Common/Timer: Fix integer underflow in Timer::GetDoubleTime for dates before ~2008.
2020-07-12 15:52:15 -04:00
Jordan Woyak
eab07866a3
Common/Timer: Fix integer underflow in Timer::GetDoubleTime for dates before ~2008.
2020-07-12 12:55:02 -05:00