Mat M
78fad0aafa
Merge pull request #8443 from JosJuice/redumpverifier-datel-wii
...
RedumpVerifier: Fix handling of Datel Wii disc serials
2019-10-30 05:37:08 -04:00
JosJuice
42ec861469
RedumpVerifier: Fix handling of Datel Wii disc serials
...
GC Datel discs have empty serials, but Wii Datel discs have
serials starting with DS followed by some digits.
2019-10-30 10:11:24 +01:00
JosJuice
49977446dd
RedumpVerifier: Don't crash on missing hyphen in serial
2019-10-30 09:58:37 +01:00
JosJuice
e2ef248260
VolumeVerifier: Fix "The data partition is missing" false positive
...
My bad...
2019-10-30 09:38:18 +01:00
Mat M
427d4501bc
Merge pull request #8429 from JosJuice/redump-create-path
...
Create necessary folder when using Redump.org integration
2019-10-26 15:51:25 -04:00
JosJuice
2f1b2c6adf
Create necessary folder when using Redump.org integration
...
This was making it impossible to use the Redump.org integration
without first manually creating a Redump folder in the Cache folder.
https://bugs.dolphin-emu.org/issues/11885
2019-10-25 11:07:50 +02:00
JosJuice
742aa765c6
VolumeVerifier: Don't show problems with good dumps of Wii Freeloaders
2019-10-25 10:03:12 +02:00
Mat M
780d34dbca
Merge pull request #8426 from JosJuice/volumeverifier-region-mismatch
...
VolumeVerifier: Improve region/game ID mismatch checking
2019-10-23 20:15:31 -04:00
JosJuice
77b9a70d6c
VolumeVerifier: Don't consider region mismatch for placeholder game IDs
2019-10-23 10:43:34 +02:00
JosJuice
97c4e8ff3a
VolumeVerifier: Include revision when checking region mismatch
2019-10-23 10:39:19 +02:00
JosJuice
87c5e0b30e
VolumeVerifier: Add Redump.org downloading
2019-08-25 12:53:19 +02:00
JosJuice
3eb360b818
VolumeVerifier: Add zip support for datfile
2019-08-24 16:37:19 +02:00
JosJuice
22933d8502
VolumeVerifier: Add datfile parsing
2019-08-24 16:37:19 +02:00
JosJuice
8c8bab3657
VolumeVerifier: Show underdump warnings for WBFS/CISO too
2019-08-09 16:13:50 +02:00
JosJuice
34fb608dd6
VolumeVerifier: Multithreading
2019-08-06 16:42:59 +02:00
JosJuice
f754a1a548
VolumeVerifier: Don't read data multiple times
2019-08-06 16:32:01 +02:00
Léo Lam
c8c1a0d747
Merge pull request #8253 from JosJuice/fakesigned-common-key-fix
...
Re-implement FixCommonKeyIndex for WAD files
2019-07-23 09:41:46 +08:00
Anthony
136264d340
Merge pull request #8245 from JosJuice/volumeverifier-wii-menu-region
...
Fix VolumeVerifier considering Wii Menu WADs to have wrong region
2019-07-22 15:06:07 -07:00
JosJuice
4b73d18eaa
Re-implement FixCommonKeyIndex for WAD files
...
The old implementation of this was not able to distinguish between
a title that had the common key index set to 1 because it actually
was Korean and a title that had the common key index set to 1 due to
fakesigning. This new implementation solves the problem by
decrypting a content with each possible common key and checking
which result matches the provided SHA-1 hash.
The problem that the old implementation causes has only been reported
to affect a certain pirated WAD of Chronos Twins DX (WC6EUP), but it's
possible that the problem would start affecting more WADs if we add
support for the vWii common key (which uses index 2). Adding support
for the vWii common key would also prevent us from using the simpler
solution of always forcing the index to 0 if the title is not Korean.
2019-07-21 09:58:16 +02:00
JosJuice
4ee73dbad3
IOS: Put common key handles in an array
2019-07-21 09:37:06 +02:00
JosJuice
34f32898e6
DiscIO: Merge WiiWAD into VolumeWAD
...
These two classes are very similar, so let's merge them.
2019-07-18 22:29:04 +02:00
JosJuice
0b11f15158
Fix VolumeVerifier considering Wii Menu WADs to have wrong region
2019-07-15 12:42:13 +02:00
Lioncash
4f1f55093f
Common/MsgHandler: Namespace code within the Common namespace
...
Closes another gap in the Common library where code isn't being
namespaced under it.
2019-06-19 16:03:55 -04:00
Lioncash
5512876842
General: Migrate from deprecated mbedTLS functions
...
As indicated by mbedTLS' documentation, all of the relevant functions
have been superseded by _ret-suffixed variants in mbedTLS version
2.7.0.
2019-06-07 22:51:58 -04:00
Lioncash
d220e33862
DiscIO/VolumeVerifier: Make no-argument overload of GetBiggestUsedOffset() const
...
The overload taking a partition is already a const member function, so
this one can be turned into one as well.
2019-05-27 10:40:41 -04:00
Lioncash
bf6948c1d4
DiscIO/VolumeVerifier: Use structured bindings where applicable
...
Allows providing better names than "first" or "second".
2019-05-27 10:40:38 -04:00
Lioncash
fa57396e97
DiscIO/VolumeVerifier: In-class initialize members where applicable
...
Removes redundant initializers from the constructor and provides
initializers for all members that don't already have one for consistency
(and deterministic initial state).
2019-05-27 10:40:17 -04:00
Lioncash
52eb2d0d82
DiscIO/VolumeVerifier: Default destructor within the cpp file
...
Given the volume verifier has quite a few non-trivial object within it,
it's best to default the destructor within the cpp file to prevent
inlining complex destruction logic elsewhere, while also making it nicer
if a forward-declared type is ever used in a member variable.
2019-05-27 10:19:51 -04:00
Lioncash
0ccaa2b5d6
DiscIO/VolumeVerifier: Take std::string by value in AddProblem()
...
This allows both std::moving into the function and moving the parameter
from within the function, potentially avoiding an unnecessary copy.
2019-05-27 10:17:11 -04:00
Lioncash
a1f77fd14b
DiscIO/VolumeVerifier: Make use of unused variable in CheckMisc()
...
This variable wasn't being utilized when comments indicate that it
probably should be.
2019-05-27 10:09:55 -04:00
JosJuice
8709b21ac3
VolumeVerifier: Verify WAD contents
2019-04-09 14:18:46 +02:00
JosJuice
a469fb3150
VolumeVerifier: Check whether invalid blocks are unused
2019-04-09 14:18:46 +02:00
JosJuice
eced9d7c7e
VolumeVerifier: Calculate CRC32/MD5/SHA-1
2019-04-09 14:18:46 +02:00
JosJuice
4fd2d8e8c4
VolumeVerifier: Check hashes in Wii partitions
2019-04-09 14:18:45 +02:00
JosJuice
84cbd5150f
Add a Verify tab to game properties
2019-04-09 14:18:41 +02:00