1b808789bc
Merge pull request #12986 from mitaclaw/actually-fix-llvm
...
CMakeLists: Fix LLVM Usage In UICommon
2024-08-14 13:10:44 -04:00
a345cb0131
Merge pull request #12969 from mitaclaw/cached-interpreter-2.1a-profile
...
CachedInterpreter: Software JIT Profiling Support
2024-08-14 13:09:34 -04:00
15500198d8
Remove self-comparison
2024-08-14 14:50:15 +02:00
d5522e218f
Merge pull request #12997 from tygyh/Remove-constness
...
Constness of 'result' prevents automatic move [performance-no-automatic-move]
2024-08-14 02:28:23 +01:00
f712ea71f1
Merge pull request #13004 from Dentomologist/menubar_update_select_state_slot_on_hotkey
...
MenuBar: Update checkmarked Select State Slot when hotkeys are pressed
2024-08-14 02:27:36 +01:00
134313e313
MenuBar: Update checkmarked Select State Slot when hotkey pressed
...
Update the checkmarked slot in the Select State Slot menu when the
Increase Selected State Slot or Decrease Selected State Slot hotkeys are
pressed.
The actual selected save slot was being changed correctly before this
commit; this just fixes the menu checkmark.
2024-08-13 12:53:29 -07:00
c6eb7c566d
Constness of 'result' prevents automatic move [performance-no-automatic-move] (0 issues)
2024-08-13 21:51:43 +02:00
d4ec524f21
Merge pull request #12996 from tygyh/Fix-retro-achievement-comment
...
Fix comment
2024-08-13 16:35:18 +01:00
54fdeb50b1
Merge pull request #12998 from tygyh/Remove-unused-lambda-capture
...
Remove unused lambda capture
2024-08-13 16:14:18 +02:00
49134afb42
Remove unused lambda capture
2024-08-13 10:26:25 +02:00
b86291f868
Fix comments
2024-08-13 06:58:23 +02:00
5af0ae25e6
Merge pull request #12979 from lycheefox/skylanders
...
Skylanders: Fix some skylanders and add missing ones.
2024-08-13 03:41:15 +01:00
88bd81931f
DSPHLE/Zelda: Add two missing filters
...
The biquad filter is used in all Pikmin games for cursor sound effects
in the main menu, although the difference is subtle.
The low-pass filter is used at least by Pikmin 2 Wii during the
spaceship crash in the intro and fixes the missing "puff" sound effects
whenever there is black smoke coming out of the engine.
2024-08-13 03:36:09 +01:00
7bef0188af
Detect when running inside a flatpak sandbox
2024-08-12 18:53:12 +02:00
194a5f3996
Skylanders: Fix some skylanders and add missing ones.
2024-08-11 19:34:51 -04:00
e4bd14257f
Merge pull request #12783 from Tilka/zelda_square
...
DSPHLE/Zelda: fix Pikmin 2 save sound (issue 8855)
2024-08-11 14:16:28 -04:00
6cc2133f27
Merge pull request #12811 from JosJuice/ppcanalyst-refactor-mtspr
...
PPCAnalyst: Refactor mtspr handling code
2024-08-11 15:33:46 +02:00
430416484b
Merge pull request #12983 from OatmealDome/mac-updater-embed-3-cleanup
...
AutoUpdate: Remove the old updater app on macOS if it exists
2024-08-11 01:38:15 -04:00
8995975892
Replace redundant dereferencing
2024-08-10 14:18:44 +02:00
9c5cd817e3
CMakeLists: Fix LLVM Usage In UICommon
...
This compile definition was removed in 68cbd2640d50dc0ffbce
2024-08-08 10:14:22 -07:00
8e546e79aa
DolphinQT: Listen For `clicked` Signal Rather Than `pressed`
...
The latter signal was likely used by mistake, e.g. https://github.com/dolphin-emu/dolphin/pull/8263 .
2024-08-08 08:09:38 -07:00
feb2b287e8
AutoUpdate: Remove the old updater app on macOS if it exists
2024-08-08 02:51:18 -04:00
644508cfd7
Merge pull request #12968 from OatmealDome/mac-updater-embed-3
...
Embed the Updater into DolphinQt's app bundle on macOS
2024-08-08 02:07:58 -04:00
e0e0c074ef
JITs: Consistently Use Trivial `IsDebuggingEnabled` Getter
2024-08-07 04:44:45 -07:00
9ae560d8a0
Merge pull request #12947 from Dentomologist/qtutils_clearlayoutrecursively_fix_potential_crash
...
QtUtils/ClearLayoutRecursively: Fix potential crash
2024-08-07 03:29:52 +01:00
603c8fad85
Merge pull request #12961 from JosJuice/expression-parser-translation
...
InputCommon: Translate ExpressionParser error messages
2024-08-07 03:28:48 +01:00
e736d611fc
Merge pull request #12963 from JosJuice/i18n-2024-07-28
...
i18n: Add comments and improve source strings
2024-08-07 03:28:01 +01:00
56e7e37d4f
Merge pull request #12957 from Dentomologist/adjust_include_order_and_spacing
...
Adjust order and spacing of various #includes
2024-08-07 03:27:23 +01:00
316f7bfcbf
GeneralPane: Fix building with analytics disabled
...
Add #if statements to only create and set analytics descriptions if
analytics are enabled in the build settings.
2024-08-06 14:30:33 -07:00
0fe2abf53c
Merge pull request #12973 from Tilka/debugger
...
Debugger: keep breakpoints ordered by address
2024-08-06 19:58:24 +01:00
68fe6779eb
Merge pull request #12959 from SuperSamus/sysconf-dirty-fix
...
Config: Don't depend on `is_dirty` to save SYSCONF during restore
2024-08-05 11:42:56 -04:00
bc72226668
Merge pull request #12891 from Sintendo/jitarm64-subfic
...
JitArm64_Integer: Optimize subfic for zero
2024-08-04 23:27:40 +01:00
f1366a4546
Debugger: keep breakpoints ordered by address
...
Previously, breakpoints would move to the end of the list whenever
they were edited.
2024-08-04 19:36:20 +01:00
c824ee9758
Merge pull request #12829 from Dentomologist/generalpane_add_balloontips
...
GeneralPane: Add BalloonTips
2024-08-04 15:22:18 +02:00
cde64b6a3d
CachedInterpreter: Software JIT Profiling Support
2024-08-02 06:00:56 -07:00
058000851b
AutoUpdate: Use the embedded Updater on macOS
2024-08-01 22:09:52 -04:00
7c94edb02c
CMakeLists: Embed macOS Updater app inside DolphinQt
...
I accomplish this by adding a new step where a copy of the DolphinQt bundle is created, and then the Updater is inserted into it.
2024-08-01 22:06:55 -04:00
16acdb630b
MacUpdater: Post-process the bundle
2024-08-01 22:06:55 -04:00
37a7b1e5c9
DolphinQt: Switch to mac-codesign script for code signing
2024-08-01 22:06:55 -04:00
22dda0b0c4
DolphinQt: Disable Xcode code signing to avoid double code signing
2024-08-01 22:06:55 -04:00
cbbffce79a
MacUpdater: Switch to mac-codesign script for code signing
2024-08-01 22:06:51 -04:00
ebb6255441
Display Taiwanese covers for Taiwanese games
2024-08-01 14:42:52 -04:00
f74f748ff6
MacUpdater: Change bundle ID to org.dolphin-emu.updater
...
The domain "dolphinteam.com" is not under our control, so we shouldn't be using it.
2024-08-01 12:36:53 -04:00
5c401bd5da
MacUpdater: Change CFBundleName to match the bundle's output name
2024-08-01 12:36:53 -04:00
8499b43501
MacUpdater: Always use the same signing identity as the DolphinQt bundle
2024-08-01 12:36:49 -04:00
8a50676b83
Merge pull request #12952 from LillyJadeKatrin/retroachievements-change-discs-bug
...
Fixed achievements not working after a disc change.
2024-07-31 19:58:21 -04:00
bb5326adf4
DolphinQt: Rename output bundle on macOS to DolphinQt
2024-07-30 21:44:46 -04:00
0c18393691
Merge pull request #12965 from JosJuice/android-ndk-27
...
Android: Update to NDK 27.0.12077973
2024-07-30 13:09:53 -04:00
91a323df96
Android: Update to NDK 27.0.12077973
2024-07-30 18:24:48 +02:00
6a735f3758
GeneralPane: Add BalloonTip to generate new identity checkbox
2024-07-29 14:00:46 -07:00
5512b68020
GeneralPane: Add BalloonTip to enable analytics checkbox
2024-07-29 14:00:46 -07:00
bfbc4c8cc7
GeneralPane: Add BalloonTip to fallback region combobox
2024-07-29 14:00:46 -07:00
fa4803f38a
GeneralPane: Add BalloonTip to auto update combobox
2024-07-29 14:00:46 -07:00
427b85f2a1
GeneralPane: Add BalloonTip to speed limit combobox
2024-07-29 14:00:46 -07:00
809b8a683f
GeneralPane: Add BalloonTip to discord presence checkbox
2024-07-29 14:00:46 -07:00
ce0ab58dc9
GeneralPane: Add BalloonTip to auto disc change checkbox
2024-07-29 14:00:46 -07:00
755866b771
GeneralPane: Add BalloonTip to override region settings checkbox
2024-07-29 14:00:46 -07:00
d9336a5de0
GeneralPane: Add BalloonTip to cheats checkbox
2024-07-29 14:00:46 -07:00
b2107023ba
GeneralPane: Add BalloonTip to dualcore checkbox
2024-07-29 14:00:46 -07:00
75d49842c4
Merge pull request #12964 from mitaclaw/jit-profiling-android-correctness
...
MainAndroid: Thread Correctness In WriteJitBlockLogDump
2024-07-29 16:05:47 -04:00
4883483d09
MacUpdater: Don't set bundle name via a CMake variable
2024-07-29 12:17:08 -04:00
d4e6bd9d18
MacUpdater: Remove unused variables in CMakeLists
2024-07-29 12:16:13 -04:00
4f0954dd44
MainAndroid: Thread Correctness In WriteJitBlockLogDump
...
In a race condition, the core could shut down between the `JitInterface::GetCore` nullptr check and the `JitInterface::JitBlockLogDump` call which constructs a `CPUThreadGuard`. In this scenario, nothing horrible happens—`JitBlockLogDump` also checks for a nullptr—but it would be a failure to display the correct feedback to the user.
2024-07-28 16:10:59 -07:00
53d2311163
Merge pull request #12960 from mitaclaw/jni-false
...
MainAndroid: Use JNI_FALSE instead of static_cast<jboolean>(false)
2024-07-28 17:16:32 -04:00
9d2f5245f4
i18n: Add comments and improve source strings
...
Most of these changes are to improve consistency in capitalization.
2024-07-28 14:38:20 +02:00
9a730bacce
Change Dual Core (speedup) to Dual Core (speedhack)
2024-07-28 03:56:58 -07:00
defc38b258
InputCommon: Translate ExpressionParser error messages
...
The _trans macro marks strings for translation but doesn't do anything
at runtime. For that, we need to use a function like GetStringT.
2024-07-28 12:09:15 +02:00
9193045989
Revert "Android: Disable input device sensor input due to crash"
...
This reverts commit 75fb1a7edf
2024-07-28 11:29:17 +02:00
59cbe5a843
Android: Add workaround for AOSP input device sensor suspend bug
2024-07-28 11:29:17 +02:00
7b0a7f15b0
Android: Use structural equality for sensorDetails
...
To fix the crash in input device sensor handling, we should look up
Sensors using structural equality. Unfortunately, Sensor.equals
implements referential equality, and HashMap doesn't let us provide a
custom comparator. Because the number of sensors is relatively small,
and because we have a reason to keep a sorted list of sensors around
anyway, let's switch from HashMap to ArrayList.
2024-07-28 11:29:02 +02:00
7cafd78ffc
MainAndroid: Use JNI_FALSE instead of static_cast<jboolean>(false)
2024-07-27 20:22:25 -07:00
991bce2d68
Config: Don't depend on `is_dirty` to save SYSCONF during restore
...
`Layer::Save` only does its thing if the layer has `is_dirty == true`.
But SYSCONF could have been modified by other layers, so if the base layer wasn't made dirty by anything else, then it wouldn't be restored.
Fixes https://bugs.dolphin-emu.org/issues/13580
2024-07-27 16:45:33 +02:00
d627b78c46
Adjust order and spacing of various #includes
...
Move some #includes around to match the Contributing guidelines.
2024-07-26 14:28:34 -07:00
347aab7ab3
Fixed achievements not working after a disc change.
2024-07-25 20:46:46 -04:00
6c3024c3b1
CachedInterpreter: Combine Interpret, CheckDSI, CheckProgram, and WritePC
...
I tried making the new templated Interpret callback test only the relevant exceptions (EXCEPTION_DSI, EXCEPTION_PROGRAM, or both), but didn't find a significant performance boost in it. As I am learning, the biggest bottleneck is the number of callbacks emitted, not usually the actual contents of them.
2024-07-23 14:09:57 -07:00
ae43b10eff
CachedInterpreter: Use `CodeOp::canEndBlock`
...
This was a bigger performance boost than I expected.
2024-07-23 14:07:02 -07:00
818647d694
CachedInterpreter: WritePC optimizations
...
WritePC is now needed far less, only for instructions that end the block. Unfortunately, WritePC still needs to update `PowerPCState::npc` to support the false path of conditional branch instructions. Both drawbacks should be smoothed over by optimized cached instructions in the future.
2024-07-23 14:06:40 -07:00
0282fa7adb
CachedInterpreter: Exception Check Callback Micro-Optimization
...
This saves two register pushes / pops.
2024-07-23 14:06:22 -07:00
f79520a906
Cached Interpreter 2.0
...
It now supports variable-sized data payloads and memory range freeing. It's a little faster, too.
2024-07-23 14:06:21 -07:00
c71ccb548e
AchievementManager: Fix incorrect check on network request return value in FetchBadge()
2024-07-23 20:49:12 +02:00
2d8f54fdd2
Merge pull request #12862 from SuperSamus/debugger-fixes
...
Debugger: Various fixes
2024-07-23 20:36:34 +02:00
7db5caf43e
Merge pull request #12943 from Tilka/list_recursively
...
DolphinTool: list filesystem recursively
2024-07-23 19:56:07 +02:00
ffc7bcfbf8
Emitters: Define Trivial Getters Inline
2024-07-21 21:35:29 -07:00
384e044437
QtUtils/ClearLayoutRecursively: Fix potential crash
...
Use QObject->deleteLater() instead of the delete operator to destroy
child widgets of the layout. This prevents crashes caused by pending
events trying to access the now-destroyed widget.
2024-07-21 17:36:05 -07:00
191b36976c
DolphinTool: list filesystem recursively
2024-07-21 19:16:00 +01:00
7bd2a7bde3
Merge pull request #12945 from Tilka/erase_if
...
Use C++20 erase_if() instead of erase(remove_if()) (NFC)
2024-07-21 19:06:55 +01:00
2dcb612497
Change OperandDesc variables to not be underscore-prefixed in order to comply with https://eel.is/c++draft/lex.name#3.1 (fixes compilation under newlib; e.g. devkitPro)
2024-07-21 18:35:38 +02:00
982893b04c
Use C++20 erase_if() instead of erase(remove_if()) (NFC)
2024-07-21 16:36:06 +01:00
1fcb2ee5c1
Merge pull request #12936 from vabold/ios-inaccuracy
...
IOS: Fix return code inaccuracy
2024-07-19 21:27:07 +02:00
139e6f6f1b
Merge pull request #12941 from LillyJadeKatrin/retroachievements-leaderboard-spam-fix
...
RetroAchievements - Leaderboard Spam Fix
2024-07-18 21:15:38 +02:00
8bb2f98c6a
Properly Populate Player Index
...
The player_index field in question is ultimately what gets used to determine which ranks get displayed in the leaderboards chart, and because this was missing the chart was simply displaying the top four results no matter what.
2024-07-17 22:53:15 -04:00
5ccd157c94
Re-enable Leaderboards Tab
2024-07-17 22:51:43 -04:00
e7504d0b12
Remove Leaderboard Fetch when Getting Info
...
The cause of the leaderboard spam was primarily this call where if there was an attempt to get leaderboard info and there wasn't already, there would be a fetch request. This is bad for many reasons: some games have hundreds of boards that will be fetched at startup, if there's simply no data to populate that board, this will just continue to fetch every time the dialog needs to update. To mitigate this, I simply don't load leaderboard information until there are events for that leaderboard - less information for the player, sadly, but heavily cuts down on the number of leaderboard fetches.
2024-07-17 22:51:24 -04:00
d19aa934ae
Fixed incorrect unlock information in Achievements dialog
2024-07-17 04:36:53 -04:00
cc3ff347b4
Merge pull request #12928 from LillyJadeKatrin/retroachievements-disable-lboard-tab
...
Disable Leaderboards Tab
2024-07-15 21:33:08 -04:00
63e1419396
AchievementManager: Don't point to stack for login error message
2024-07-15 23:24:04 +02:00
c50689355b
IOS: Fix return code inaccuracy
...
Co-Authored-By: Mike <99037623+MikeIsAStar@users.noreply.github.com>
2024-07-15 16:11:15 -04:00
50b318cc31
Qt/AchievementHeaderWidget: Don't crash when we get an empty player or game badge
2024-07-15 21:55:47 +02:00
d665175a2b
AchievementManager: Return the default player and game badges if the current one isn't loaded yet
...
This saves some copying and fixes an issue where the default badges disappear after a game was closed
2024-07-15 21:55:23 +02:00
b18661f15d
Merge pull request #12931 from AdmiralCurtiss/cannot-pause-message
...
AchievementManager: Improve error message for repeated pausing
2024-07-15 12:05:45 +02:00
OatmealDome