542c49bab0
Core: Fix invalid lambda captures
...
PR #9260 made the MsgAlert macros use lambdas so that local
constexpr variables can be added while keeping the ability to
return a boolean from the macros.
Unfortunately, C++17 forbids referring to structured bindings in lambda
captures. This is fixed in P1091R3 but we cannot rely on C++20 yet...
2020-11-20 18:27:56 +01:00
f45a4a5916
Merge pull request #9263 from lioncash/core-log2
...
Core: Convert logging over to fmt pt.2
2020-11-20 16:36:47 +01:00
7f5cecf7ef
Merge pull request #9264 from leoetlino/fix-fmt-log
...
DSP: Fix one DEBUG_LOG call
2020-11-20 10:21:48 -05:00
88cc1b7c8a
DSP: Fix one DEBUG_LOG call
2020-11-20 16:21:05 +01:00
a0f9b041a0
Core: Convert logging over to fmt pt.2
...
Continues the core migration of logs up to the EXI handling code.
2020-11-20 10:05:44 -05:00
419dfe4be4
Merge pull request #9260 from leoetlino/fmt-checks
...
Common/Log: Add compile-time format string checks
2020-11-20 16:05:25 +01:00
1d4672455c
Merge pull request #9130 from flto/master
...
Vulkan: fix validation error in bSupportsGeometryShaders=false case
2020-11-20 12:35:40 +01:00
a20e69ff51
Vulkan: fix validation error in bSupportsGeometryShaders=false case
...
In CreateDescriptorSetLayouts(), one less dynamic binding is created when
bSupportsGeometryShaders=false. Reduce the dynamicOffsetCount argument by
one in that case. Avoids this validation error:
Attempting to bind 3 descriptorSets with 2 dynamic descriptors, but
dynamicOffsetCount is 3. It should exactly match the number of dynamic
descriptors. The Vulkan spec states: dynamicOffsetCount must be equal to
the total number of dynamic descriptors in pDescriptorSets
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
[Applied clang-format]
Signed-off-by: Léo Lam <leo@leolam.fr>
2020-11-20 12:23:34 +01:00
c580a70a12
Merge pull request #9210 from Dentomologist/regions-show-hide-all
...
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-20 11:35:22 +01:00
a4aec0556b
Merge pull request #9212 from nf6429/master-diff
...
Game INI Changes
2020-11-20 11:10:52 +01:00
7ded075561
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-19 20:39:49 -08:00
858d7612ef
Merge pull request #9170 from JosJuice/android-extension-hack-2
...
Android: Remove hacks for Wii Remote extension setting, round 2
2020-11-20 02:47:23 +01:00
30bffca5c3
Merge pull request #9193 from JosJuice/android-clear-motioncontrolsenabled
...
Android: Re-add motionControlsEnabled to clearWiimoteNewIniLinkedPreferences
2020-11-20 02:37:51 +01:00
7f7fd4d8d3
Merge pull request #9220 from jordan-woyak/ext-crypto
...
WiimoteEmu: Implement extension encryption edge case.
2020-11-20 02:28:17 +01:00
bca82bb942
Merge pull request #9239 from altimumdelta/FFDUMP_Separate_Logging
...
FrameDump Logging: Separate log type and migrate to fmt
2020-11-20 02:21:57 +01:00
5921a93d71
Merge pull request #9247 from Dentomologist/fix-updater-temporary-folder
...
Fix updater not always cleaning up temp directory
2020-11-20 02:01:43 +01:00
eff566b318
Merge pull request #9258 from lioncash/core-log
...
Core: Convert logging over to fmt pt. 1
2020-11-19 20:32:19 +01:00
958cbf38a4
Core: Convert logging over to fmt pt. 1
...
Converts up to the DSP-related files for easier reviewing, the rest will
be progressively moved over after this change gets merged.
2020-11-19 14:21:06 -05:00
e3247b567d
Merge pull request #9185 from Losuc/skipEFBaccessHotkey
...
Add a Skip EFB Access Hotkey
2020-11-19 17:28:45 +01:00
c724447f80
Merge pull request #9259 from Strum355/utf8-source
...
Fixed non-UTF8 chars in PeakFinder.cpp
2020-11-19 17:23:00 +01:00
dde6090e98
Common/MsgHandler: Add compile-time format string checks
2020-11-19 17:09:24 +01:00
62eeb05519
Common: Validate the number of {} fields in format strings
...
Unfortunately, {fmt} allows passing too many arguments to a format call
without raising any runtime or compile-time error [1].
As this is a common source of bugs since we started migrating to {fmt},
this commit adds some custom logic to validate the number of
replacement fields in format strings in addition to {fmt}'s own checks.
[1] https://github.com/fmtlib/fmt/issues/492
2020-11-19 17:09:24 +01:00
47c91696ee
Common/Log: Check format strings
...
Helps with catching incorrect format strings.
PanicAlertFmt already uses FMT_STRING and fmt::make_args_checked.
2020-11-19 17:09:24 +01:00
7e9a2dcc72
Merge pull request #9261 from AdmiralCurtiss/shop-logs
...
WiiUtils: Create Wii Shop log files when installing a WAD.
2020-11-19 16:49:34 +01:00
83c235b7cb
WiiUtils: Create Wii Shop log files when installing a WAD.
...
Fixes https://bugs.dolphin-emu.org/issues/12269
2020-11-19 03:26:27 +01:00
4d26f6ad95
Fixed non-UTF8 chars in PeakFinder.cpp
2020-11-18 19:50:40 +00:00
59c362d002
Translation resources sync with Transifex
2020-11-18 18:14:57 +01:00
4eecb8fd11
Merge pull request #9248 from lioncash/video-fmt
...
VideoCommon: Migrate over to fmt
2020-11-18 11:10:48 +01:00
3d9b2aa005
VideoCommon: Migrate over to fmt
...
Migrates off the printf-based formatting where applicable.
2020-11-17 21:23:58 -05:00
eb1581bbcc
Merge pull request #9246 from JosJuice/translation-eot
...
DolphinQt: Don't return 0x04 bytes from tr
2020-11-18 02:31:13 +01:00
31d7be521c
Merge pull request #7714 from cristian64/avoid_leaking_gamelistmodel
...
DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit
2020-11-18 02:14:51 +01:00
0339889806
Merge pull request #9251 from sepalani/sockopt
...
IP/Top: Add missing sockopt
2020-11-18 02:10:37 +01:00
b8bc6c3c86
Merge pull request #9256 from JosJuice/android-keep
...
Android: Add @Keep annotation to things accessed using JNI
2020-11-18 01:01:34 +01:00
8119318907
Merge pull request #9257 from JosJuice/redundant-i18n
...
Remove a redundant i18n comment
2020-11-18 00:56:58 +01:00
52c615f1b1
Remove a redundant i18n comment
2020-11-17 18:23:27 +01:00
07be82d64f
Merge pull request #9253 from JosJuice/positional-arguments
...
Use positional arguments in all translatable fmt strings
2020-11-17 18:02:39 +01:00
a8d385c705
Android: Add @Keep annotation to things accessed using JNI
...
This acts as a hint to both people and automated tools
that a variable or method shouldn't be renamed or removed.
2020-11-17 14:11:51 +01:00
9a01c3fb9f
Use positional arguments in all translatable fmt strings
...
We want to use positional arguments in translatable strings
that have more than one argument so that translators can change
the order of them, but the question is: Should we also use
positional arguments in translatable strings with only one
argument? I think it makes most sense that way, partially
so that translators don't even have to be aware of the
non-positional syntax and partially because "translatable
strings use positional arguments" is an easier rule for us
to remember than "transitional strings which have more than
one argument use positional arguments". But let me know if
you have a different opinion.
2020-11-16 13:28:11 +01:00
4c9b226bd6
Merge pull request #9252 from JosJuice/fmt-version-requirement
...
CMake: Bump fmt version requirement to 7.1.0
2020-11-16 07:12:54 -05:00
56e68e7b72
CMake: Bump fmt version requirement to 7.1.0
...
We use make_args_checked, which was added in 7.1.0.
2020-11-16 13:06:20 +01:00
6dcf7643e5
Fix updater not always cleaning up temp directory
...
Updater was only deleting TempUpdate folder when an error occured.
2020-11-13 12:25:53 -08:00
53da97208a
DolphinQt: Don't return 0x04 bytes from tr
...
tr calls with more than one argument would have a 0x04 byte
in the returned string when no translation was found
(which always is the case when using Dolphin in English).
2020-11-12 19:44:44 +01:00
8a621c2d5e
Merge pull request #9236 from lioncash/log-backend
...
VideoBackends: Migrate logging over to fmt
2020-11-12 14:51:28 +01:00
ec5313fe24
Merge pull request #9204 from fbastos1/master
...
fix emulator issue #12139
2020-11-12 14:43:35 +01:00
c991f00479
Merge pull request #9244 from lioncash/input-panic
...
InputCommon: Migrate over to fmt-capable panic alerts
2020-11-12 14:41:50 +01:00
d8e1921b57
InputCommon: Migrate over to fmt-capable panic alerts
...
Continues the migration over to fmt.
2020-11-12 02:29:26 -05:00
93212049ac
Merge pull request #9242 from lioncash/disc-panic
...
DiscIO: Make use of fmt-capable panic alerts
2020-11-12 02:22:21 -05:00
9e3e325add
Merge pull request #9243 from JosJuice/android-input-overlay-null
...
Android: Add null check for InputOverlay
2020-11-11 11:22:41 +01:00
32ad2dcec3
Android: Add null check for InputOverlay
...
Hopefully fixes https://bugs.dolphin-emu.org/issues/12316 .
2020-11-11 10:38:49 +01:00
689eec5304
DiscIO: Make use of fmt-capable panic alerts
...
Migrates the DiscIO code over to fmt.
2020-11-11 01:09:42 -05:00
Léo Lam