Léo Lam
d1439a1fa9
IOS/USB: Move scan thread logic into a separate class
...
This moves the scan thread logic and variables into a separate
ScanThread class. By turning ScanThread instances into members of the
most derived class, this ensures that the scan thread is always
properly stopped when the most derived class is destructed and fixes
a race condition that could cause the scan thread to call virtual
member functions from a derived class whose members have already
been destructed.
A drawback of this approach is that the scan thread must be the last
member variable, so this commit also adds static assertions to ensure
that the assumption stays valid.
2020-08-17 15:14:45 +02:00
Léo Lam
55c931d624
Merge pull request #8995 from Tilka/warnings
...
Fix some more GCC warnings
2020-08-17 14:49:28 +02:00
Léo Lam
6104018fe1
Merge pull request #9020 from Tilka/usb
...
IOS/USB: fix potential race condition
2020-08-17 12:15:26 +02:00
Léo Lam
c9945670f0
Merge pull request #9029 from shuffle2/vs-clean
...
vs/msbuild: fix the build generating log files in source dirs
2020-08-17 12:13:45 +02:00
Léo Lam
fee6bef252
Merge pull request #9032 from shuffle2/msbuild-unittests
...
UnitTests: avoid using glob to find compilation units
2020-08-17 12:11:59 +02:00
Shawn Hoffman
d40ae8a84b
UnitTests: expliticly list files to be compiled.
...
Fixes VS warning / bad behavior.
2020-08-16 15:17:11 -07:00
Shawn Hoffman
9a5a705d01
Fix comparison to invalidated vector iterator.
...
GetFstEntryForPath may modify the children vector,
so do it before taking an iterator to the vector.
2020-08-16 15:17:11 -07:00
Shawn Hoffman
9d880c2db3
UnitTests: quiet warnings
2020-08-16 15:17:11 -07:00
Jordan Woyak
b5241d1c2c
Merge pull request #9031 from shuffle2/msvc-overflow-workaround
...
msvc: temporary workaround for C4789 false positive
2020-08-16 15:01:14 -05:00
Shawn Hoffman
deb73d0167
msvc: temporary workaround for C4789 false positive
2020-08-16 12:49:00 -07:00
Jordan Woyak
0ad123bdbb
BTEmu: Fix home menu inquiry assigning multiple wii remotes to wrong slots.
2020-08-16 11:38:13 -05:00
Jordan Woyak
6a6f1451ff
Update state version.
2020-08-16 11:38:13 -05:00
Jordan Woyak
13ee6bd7bb
BTEmu/Wiimote: Cleanups/Fixes.
2020-08-16 11:38:13 -05:00
LC
2c5920dccc
Merge pull request #9028 from cristian64/netplaybrowser_deadlock_on_exit
...
DolphinQt: Prevent deadlock when exiting the NetPlay Session Browser dialog
2020-08-16 08:57:35 -04:00
Christian Aguilera
ddeb2236ae
Removed RunOnObject() usage to prevent deadlock on exiting the NetPlay Session Browser dialog.
2020-08-16 12:32:50 +01:00
LC
6fc7135047
Merge pull request #8855 from shuffle2/dol
...
DolReader: treat overly large data segment as bss
2020-08-16 06:02:39 -04:00
Shawn Hoffman
adf22c0728
vs/msbuild: fix the build generating log files in source dirs
2020-08-16 00:01:22 -07:00
Jordan Woyak
89ca9b51ad
Bluetooth/WiimoteDevice: Remove some silly comments.
2020-08-15 21:23:37 -05:00
Jordan Woyak
1cddf9c527
BTEmu: Remove a wrong INFO_LOG.
2020-08-15 21:23:37 -05:00
Christian Aguilera
eee1589aa3
Restoring NetPlay Session Browser dialog's settings before connecting widgets, to prevent multiple refresh requests on change.
2020-08-15 22:29:23 +01:00
JosJuice
07a0d44b36
Merge pull request #8571 from Pokechu22/di-interrupts
...
Fix gamecube games not noticing disc changes
2020-08-11 20:03:41 +02:00
LC
32061c95d4
Merge pull request #9026 from JosJuice/framedump-numerator
...
FrameDump: Don't ignore the time base numerator
2020-08-11 05:39:51 -04:00
JosJuice
bd87285f3a
FrameDump: Don't ignore the time base numerator
...
Fixes a regression where f72b756
made all dumped video super long.
2020-08-11 11:17:22 +02:00
cyrozap
c2de1d041a
Fix builds with system LZMA when using versions of CMake before 3.14
...
The "FindLibLZMA.cmake" module in CMake versions prior to 3.14 do not
set an alias like how Externals/liblzma/CMakeLists.txt does, so builds
performed using one of those older CMake versions will fail if the
system LZMA library is detected. To fix this, we need to link against
"lzma" instead of "LibLZMA::LibLZMA".
Fixes: b59ef81a7e
("WIA: Implement bzip2, LZMA, and LZMA2 decompression")
2020-08-11 02:53:16 -05:00
JosJuice
bd9d0964cd
Android: Fix defaults for WiimoteContinuousScanning/EnableSpeaker
...
The default values need to match the default values defined in C++.
2020-08-11 09:18:15 +02:00
LC
655e92478a
Merge pull request #9022 from JosJuice/android-getrendersurfacescale-java
...
Android: Rewrite GetRenderSurfaceScale in Java
2020-08-09 21:22:07 -04:00
JosJuice
02fe1cdec4
Android: Rewrite GetRenderSurfaceScale in Java
...
Long sequences of JNI calls are both hard to read and slow.
2020-08-09 21:07:22 +02:00
Tillmann Karras
ca61b6c1ab
DiscIO: make use of std::nullopt
...
This also fixes a bogus GCC warning.
2020-08-08 21:53:27 +01:00
Tillmann Karras
d2b06f4786
Fix various -Wshadow warnings
2020-08-08 21:45:03 +01:00
Tillmann Karras
ee0d4661ab
IOS/USB: deduplicate scan thread stopping
...
Unlike other functions, base ctors/dtors are always called automatically.
2020-08-08 21:40:23 +01:00
Tillmann Karras
1f4b9adbf5
ISO/USB: fix potential race condition
2020-08-08 21:40:23 +01:00
Tilka
a161e58591
Merge pull request #8914 from JosJuice/jit64-low-dcbz
...
Jit64: Implement low DCBZ hack
2020-08-08 21:19:16 +01:00
Tilka
8b236fc8f8
Merge pull request #8986 from jordan-woyak/button-pressed-no-ext
...
WiimoteEmu: Don't check extension button press for Wii remote reconnection.
2020-08-08 21:06:46 +01:00
Tilka
c0fde32d80
Merge pull request #9019 from JosJuice/verify-wad-split-tmd-ticket
...
VolumeVerifier: Split TMD error from ticket error for WADs
2020-08-08 21:05:21 +01:00
JosJuice
76228fa482
Jit64: Implement low DCBZ hack
...
I was hoping this would improve the performance of Cars 2 by
avoiding interpreter fallbacks, but it doesn't seem to have
made any measurable impact.
2020-08-08 22:03:34 +02:00
Tilka
3101d957b6
Merge pull request #8886 from JosJuice/stack-check-instruction
...
PatchEngine: Attempt to fix crash in IsStackSane
2020-08-08 20:59:48 +01:00
Tilka
6356cc8b08
Merge pull request #8910 from OatmealDome/os-deprecated-cleanup
...
Analytics: Replace usage of Gestalt for retrieving macOS version
2020-08-08 20:53:14 +01:00
Tilka
f17b5dd41b
Merge pull request #8804 from iwubcode/dsu-improvements
...
DolphinQt / InputCommon - Support multiple DSU servers
2020-08-08 20:45:57 +01:00
JosJuice
7ef0bc0359
VolumeVerifier: Split TMD error from ticket error for WADs
...
When I first made VolumeVerifier, I figured that the distinction
between an unsigned ticket and an unsigned TMD was a technical
detail that users would have no reason to care about. However,
while this might be true for discs, it isn't equally true for
WADs, due to the widespread practice of fakesigning tickets to
set the console ID to 0. This practice does not require
fakesigning the TMD (though apparently people do it anyway,
at least sometimes...), and the presence of a correctly signed
TMD is a useful indicator that the contents have not been
tampered with, even if the ticket isn't correctly signed.
2020-08-08 21:15:51 +02:00
Tilka
76b955e090
Merge pull request #8940 from RenaKunisaki/master
...
add Break On Hit and Log On Hit for instruction breakpoints
2020-08-08 19:46:10 +01:00
Tilka
6d0bc03e00
Merge pull request #8992 from Sintendo/fselx-avx
...
Jit64: Avoid unnecessary MOVAPS instructions
2020-08-08 19:38:48 +01:00
Tilka
d7a96f927c
Merge pull request #9002 from OatmealDome/renderwidget-sheet
...
MainWindow: Attach quit emulation sheet to RenderWidget if shown on macOS
2020-08-08 19:18:32 +01:00
Tilka
4c64446afe
Merge pull request #9005 from OatmealDome/macos-psn-arg
...
DolphinQt: Ignore "-psn" command line option on macOS
2020-08-08 19:11:39 +01:00
Tilka
340c08a88d
Merge pull request #9008 from Sintendo/dspjitlea
...
DSPJit: Various minor improvements
2020-08-08 19:08:24 +01:00
Tilka
3201944208
Merge pull request #9016 from JosJuice/jitarm64-fctiwzx-fcvt
...
JitArm64: Avoid double rounding in fctiwzx
2020-08-08 17:55:49 +01:00
JosJuice
8b4f16a310
JitArm64: Avoid double rounding in fctiwzx
...
FCVT doesn't necessarily round to zero, so the result
might be inaccurate if we use it. To ensure correct
rounding, we use FCVTS from double FPR to 32-bit GPR.
Unfortunately, FCVTS can't do double FPR to single FPR.
2020-08-07 22:44:04 +02:00
Jordan Woyak
a77977d0aa
Merge pull request #8999 from AdmiralCurtiss/input-expression-math
...
Add a few input expression functions (trigonometry, sqrt, pow, min, max, clamp)
2020-08-07 14:40:29 -05:00
LC
5ec65a20d6
Merge pull request #9009 from JosJuice/android-settings-recreation
...
Android: Fix SettingsActivity lifecycle management
2020-08-06 19:46:16 -04:00
LC
d8c0344ee8
Merge pull request #9010 from JosJuice/android-settingsadapter-redundant-static
...
Android: Remove some static variables from SettingsAdapter
2020-08-06 19:45:54 -04:00
LC
7b3056fee0
Merge pull request #9011 from JosJuice/android-settings-viewmodel
...
Android: Persist Settings using ViewModel
2020-08-06 19:45:17 -04:00