ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use pre-increment for iterators instead of post-increment. 

Pre-increment is more efficient, since it doesn't have to return the
old iterator.
This commit is contained in:
David Korth 2019-09-14 16:48:48 -04:00
parent c2dd2e8a2e
commit f5fe692842
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/UICommon/ResourcePack/Manager.cpp
View File

@ -76,7 +76,7 @@ std::vector<ResourcePack>& GetPacks()
std::vector<ResourcePack*> GetLowerPriorityPacks(ResourcePack& pack) std::vector<ResourcePack*> GetLowerPriorityPacks(ResourcePack& pack)
{ {
std::vector<ResourcePack*> list; std::vector<ResourcePack*> list;
for (auto it = std::find(packs.begin(), packs.end(), pack) + 1; it != packs.end(); it++) for (auto it = std::find(packs.begin(), packs.end(), pack) + 1; it != packs.end(); ++it)
{ {
auto& entry = *it; auto& entry = *it;
if (!IsInstalled(pack)) if (!IsInstalled(pack))
@ -93,7 +93,7 @@ std::vector<ResourcePack*> GetHigherPriorityPacks(ResourcePack& pack)
std::vector<ResourcePack*> list; std::vector<ResourcePack*> list;
auto end = std::find(packs.begin(), packs.end(), pack); auto end = std::find(packs.begin(), packs.end(), pack);
for (auto it = packs.begin(); it != end; it++) for (auto it = packs.begin(); it != end; ++it)
{ {
auto& entry = *it; auto& entry = *it;
if (!IsInstalled(entry)) if (!IsInstalled(entry))

2
Source/Core/VideoBackends/D3D12/StreamBuffer.cpp
View File

@ -178,7 +178,7 @@ bool StreamBuffer::WaitForClearSpace(u32 num_bytes)
u32 new_gpu_position = 0; u32 new_gpu_position = 0;
auto iter = m_tracked_fences.begin(); auto iter = m_tracked_fences.begin();
for (; iter != m_tracked_fences.end(); iter++) for (; iter != m_tracked_fences.end(); ++iter)
{ {
// Would this fence bring us in line with the GPU? // Would this fence bring us in line with the GPU?
// This is the "last resort" case, where a command buffer execution has been forced // This is the "last resort" case, where a command buffer execution has been forced

2
Source/Core/VideoBackends/Vulkan/StreamBuffer.cpp
View File

@ -254,7 +254,7 @@ bool StreamBuffer::WaitForClearSpace(u32 num_bytes)
u32 new_gpu_position = 0; u32 new_gpu_position = 0;
auto iter = m_tracked_fences.begin(); auto iter = m_tracked_fences.begin();
for (; iter != m_tracked_fences.end(); iter++) for (; iter != m_tracked_fences.end(); ++iter)
{ {
// Would this fence bring us in line with the GPU? // Would this fence bring us in line with the GPU?
// This is the "last resort" case, where a command buffer execution has been forced // This is the "last resort" case, where a command buffer execution has been forced