From f5fe69284200553e1890e55d82c53a60e9ed2ae3 Mon Sep 17 00:00:00 2001 From: David Korth Date: Sat, 14 Sep 2019 16:48:48 -0400 Subject: [PATCH] Use pre-increment for iterators instead of post-increment. Pre-increment is more efficient, since it doesn't have to return the old iterator. --- Source/Core/UICommon/ResourcePack/Manager.cpp | 4 ++-- Source/Core/VideoBackends/D3D12/StreamBuffer.cpp | 2 +- Source/Core/VideoBackends/Vulkan/StreamBuffer.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Core/UICommon/ResourcePack/Manager.cpp b/Source/Core/UICommon/ResourcePack/Manager.cpp index 1be409f6e6..d2e7c8fc25 100644 --- a/Source/Core/UICommon/ResourcePack/Manager.cpp +++ b/Source/Core/UICommon/ResourcePack/Manager.cpp @@ -76,7 +76,7 @@ std::vector& GetPacks() std::vector GetLowerPriorityPacks(ResourcePack& pack) { std::vector list; - for (auto it = std::find(packs.begin(), packs.end(), pack) + 1; it != packs.end(); it++) + for (auto it = std::find(packs.begin(), packs.end(), pack) + 1; it != packs.end(); ++it) { auto& entry = *it; if (!IsInstalled(pack)) @@ -93,7 +93,7 @@ std::vector GetHigherPriorityPacks(ResourcePack& pack) std::vector list; auto end = std::find(packs.begin(), packs.end(), pack); - for (auto it = packs.begin(); it != end; it++) + for (auto it = packs.begin(); it != end; ++it) { auto& entry = *it; if (!IsInstalled(entry)) diff --git a/Source/Core/VideoBackends/D3D12/StreamBuffer.cpp b/Source/Core/VideoBackends/D3D12/StreamBuffer.cpp index a3702a7256..d8f0699f77 100644 --- a/Source/Core/VideoBackends/D3D12/StreamBuffer.cpp +++ b/Source/Core/VideoBackends/D3D12/StreamBuffer.cpp @@ -178,7 +178,7 @@ bool StreamBuffer::WaitForClearSpace(u32 num_bytes) u32 new_gpu_position = 0; auto iter = m_tracked_fences.begin(); - for (; iter != m_tracked_fences.end(); iter++) + for (; iter != m_tracked_fences.end(); ++iter) { // Would this fence bring us in line with the GPU? // This is the "last resort" case, where a command buffer execution has been forced diff --git a/Source/Core/VideoBackends/Vulkan/StreamBuffer.cpp b/Source/Core/VideoBackends/Vulkan/StreamBuffer.cpp index aa635e4d41..9582093c89 100644 --- a/Source/Core/VideoBackends/Vulkan/StreamBuffer.cpp +++ b/Source/Core/VideoBackends/Vulkan/StreamBuffer.cpp @@ -254,7 +254,7 @@ bool StreamBuffer::WaitForClearSpace(u32 num_bytes) u32 new_gpu_position = 0; auto iter = m_tracked_fences.begin(); - for (; iter != m_tracked_fences.end(); iter++) + for (; iter != m_tracked_fences.end(); ++iter) { // Would this fence bring us in line with the GPU? // This is the "last resort" case, where a command buffer execution has been forced