ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

VideoBackends:Metal: Use max pixel samplers constant

This commit is contained in:
TellowKrinkle 2023-03-30 15:23:22 -05:00
parent 7e9a63b987
commit ed177bdbd7
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Source/Core/VideoBackends/Metal/MTLStateTracker.h
View File

@ -17,6 +17,7 @@
#include "VideoBackends/Metal/MTLTexture.h" #include "VideoBackends/Metal/MTLTexture.h"
#include "VideoBackends/Metal/MTLUtil.h" #include "VideoBackends/Metal/MTLUtil.h"
#include "VideoCommon/Constants.h"
#include "VideoCommon/FramebufferManager.h" #include "VideoCommon/FramebufferManager.h"
#include "VideoCommon/PerfQueryBase.h" #include "VideoCommon/PerfQueryBase.h"
@ -194,6 +195,8 @@ private:
// MARK: State // MARK: State
u8 m_dirty_textures; u8 m_dirty_textures;
u8 m_dirty_samplers; u8 m_dirty_samplers;
static_assert(sizeof(m_dirty_textures) * 8 >= VideoCommon::MAX_PIXEL_SHADER_SAMPLERS,
"Make these bigger");
union Flags union Flags
{ {
struct struct
@ -249,11 +252,11 @@ private:
Util::Viewport viewport; Util::Viewport viewport;
const Pipeline* render_pipeline = nullptr; const Pipeline* render_pipeline = nullptr;
const ComputePipeline* compute_pipeline = nullptr; const ComputePipeline* compute_pipeline = nullptr;
std::array<id<MTLTexture>, 8> textures = {}; std::array<id<MTLTexture>, VideoCommon::MAX_PIXEL_SHADER_SAMPLERS> textures = {};
std::array<id<MTLSamplerState>, 8> samplers = {}; std::array<id<MTLSamplerState>, VideoCommon::MAX_PIXEL_SHADER_SAMPLERS> samplers = {};
std::array<float, 8> sampler_min_lod; std::array<float, VideoCommon::MAX_PIXEL_SHADER_SAMPLERS> sampler_min_lod;
std::array<float, 8> sampler_max_lod; std::array<float, VideoCommon::MAX_PIXEL_SHADER_SAMPLERS> sampler_max_lod;
std::array<SamplerState, 8> sampler_states; std::array<SamplerState, VideoCommon::MAX_PIXEL_SHADER_SAMPLERS> sampler_states;
const Texture* compute_texture = nullptr; const Texture* compute_texture = nullptr;
std::unique_ptr<u8[]> utility_uniform; std::unique_ptr<u8[]> utility_uniform;
u32 utility_uniform_size = 0; u32 utility_uniform_size = 0;

12
Source/Core/VideoBackends/Metal/MTLStateTracker.mm
View File

@ -371,8 +371,8 @@ void Metal::StateTracker::BeginRenderPass(MTLRenderPassDescriptor* descriptor)
m_current.cull_mode = MTLCullModeNone; m_current.cull_mode = MTLCullModeNone;
m_current.perf_query_group = static_cast<PerfQueryGroup>(-1); m_current.perf_query_group = static_cast<PerfQueryGroup>(-1);
m_flags.NewEncoder(); m_flags.NewEncoder();
m_dirty_samplers = 0xff; m_dirty_samplers = (1 << VideoCommon::MAX_PIXEL_SHADER_SAMPLERS) - 1;
m_dirty_textures = 0xff; m_dirty_textures = (1 << VideoCommon::MAX_PIXEL_SHADER_SAMPLERS) - 1;
CheckScissor(); CheckScissor();
CheckViewport(); CheckViewport();
ASSERT_MSG(VIDEO, m_current_render_encoder, "Failed to create render encoder!"); ASSERT_MSG(VIDEO, m_current_render_encoder, "Failed to create render encoder!");
@ -386,8 +386,8 @@ void Metal::StateTracker::BeginComputePass()
if (m_manual_buffer_upload) if (m_manual_buffer_upload)
[m_current_compute_encoder waitForFence:m_fence]; [m_current_compute_encoder waitForFence:m_fence];
m_flags.NewEncoder(); m_flags.NewEncoder();
m_dirty_samplers = 0xff; m_dirty_samplers = (1 << VideoCommon::MAX_PIXEL_SHADER_SAMPLERS) - 1;
m_dirty_textures = 0xff; m_dirty_textures = (1 << VideoCommon::MAX_PIXEL_SHADER_SAMPLERS) - 1;
} }
void Metal::StateTracker::EndRenderPass() void Metal::StateTracker::EndRenderPass()
@ -801,13 +801,13 @@ void Metal::StateTracker::PrepareRender()
if (m_state.vertices) if (m_state.vertices)
SetVertexBufferNow(0, m_state.vertices, 0); SetVertexBufferNow(0, m_state.vertices, 0);
} }
if (u8 dirty = m_dirty_textures & pipe->GetTextures()) if (u32 dirty = m_dirty_textures & pipe->GetTextures())
{ {
m_dirty_textures &= ~pipe->GetTextures(); m_dirty_textures &= ~pipe->GetTextures();
NSRange range = RangeOfBits(dirty); NSRange range = RangeOfBits(dirty);
[enc setFragmentTextures:&m_state.textures[range.location] withRange:range]; [enc setFragmentTextures:&m_state.textures[range.location] withRange:range];
} }
if (u8 dirty = m_dirty_samplers & pipe->GetSamplers()) if (u32 dirty = m_dirty_samplers & pipe->GetSamplers())
{ {
m_dirty_samplers &= ~pipe->GetSamplers(); m_dirty_samplers &= ~pipe->GetSamplers();
NSRange range = RangeOfBits(dirty); NSRange range = RangeOfBits(dirty);