Merge pull request #6893 from spycrab/qt_gc_checkboxes

Qt/GameConfigWidget: Fix checkboxes not being saved properly
This commit is contained in:
spycrab 2018-05-19 03:34:24 +02:00 committed by GitHub
commit bf0fbdbc52
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions

View File

@ -40,8 +40,6 @@ GameConfigWidget::GameConfigWidget(const UICommon::GameFile& game) : m_game(game
m_game_id = m_game.GetGameID(); m_game_id = m_game.GetGameID();
m_gameini_local_path = m_gameini_local_path =
QString::fromStdString(File::GetUserPath(D_GAMESETTINGS_IDX) + m_game_id + ".ini"); QString::fromStdString(File::GetUserPath(D_GAMESETTINGS_IDX) + m_game_id + ".ini");
m_gameini_local = SConfig::LoadLocalGameIni(m_game_id, m_game.GetRevision());
m_gameini_default = SConfig::LoadDefaultGameIni(m_game_id, m_game.GetRevision());
CreateWidgets(); CreateWidgets();
LoadSettings(); LoadSettings();
@ -156,7 +154,7 @@ void GameConfigWidget::ConnectWidgets()
for (QCheckBox* box : {m_enable_dual_core, m_enable_mmu, m_enable_fprf, m_sync_gpu, for (QCheckBox* box : {m_enable_dual_core, m_enable_mmu, m_enable_fprf, m_sync_gpu,
m_enable_fast_disc, m_use_dsp_hle, m_use_monoscopic_shadows}) m_enable_fast_disc, m_use_dsp_hle, m_use_monoscopic_shadows})
connect(box, &QCheckBox::toggled, this, &GameConfigWidget::SaveSettings); connect(box, &QCheckBox::stateChanged, this, &GameConfigWidget::SaveSettings);
connect(m_deterministic_dual_core, connect(m_deterministic_dual_core,
static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this,
@ -216,6 +214,10 @@ void GameConfigWidget::SaveCheckBox(QCheckBox* checkbox, const std::string& sect
void GameConfigWidget::LoadSettings() void GameConfigWidget::LoadSettings()
{ {
// Reload config
m_gameini_local = SConfig::LoadLocalGameIni(m_game_id, m_game.GetRevision());
m_gameini_default = SConfig::LoadDefaultGameIni(m_game_id, m_game.GetRevision());
// Load game-specific settings // Load game-specific settings
// Core // Core