ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove popups for challenges 

The challenge popups have proven to be excessive and are no longer useful thanks to the achievements hotkey. Instead, those events will ask for an immediate RP-level update to the achievements dialog, which will among other things re-sort the dialog to show challenges on top faster.
This commit is contained in:
LillyJadeKatrin 2024-07-02 08:49:39 -04:00
parent 2372b6a386
commit 8b427de28f
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/Core/AchievementManager.cpp
View File

@ -882,9 +882,7 @@ void AchievementManager::HandleAchievementChallengeIndicatorShowEvent(
const auto [iter, inserted] = instance.m_active_challenges.insert(client_event->achievement->id); const auto [iter, inserted] = instance.m_active_challenges.insert(client_event->achievement->id);
if (inserted) if (inserted)
instance.m_challenges_updated = true; instance.m_challenges_updated = true;
OSD::AddMessage(fmt::format("Challenge Started: {}", client_event->achievement->title), AchievementManager::GetInstance().m_update_callback(UpdatedItems{.rich_presence = true});
OSD::Duration::VERY_LONG, OSD::Color::GREEN,
&instance.GetAchievementBadge(client_event->achievement->id, false));
} }
void AchievementManager::HandleAchievementChallengeIndicatorHideEvent( void AchievementManager::HandleAchievementChallengeIndicatorHideEvent(
@ -894,9 +892,7 @@ void AchievementManager::HandleAchievementChallengeIndicatorHideEvent(
const auto removed = instance.m_active_challenges.erase(client_event->achievement->id); const auto removed = instance.m_active_challenges.erase(client_event->achievement->id);
if (removed > 0) if (removed > 0)
instance.m_challenges_updated = true; instance.m_challenges_updated = true;
OSD::AddMessage(fmt::format("Challenge Ended: {}", client_event->achievement->title), AchievementManager::GetInstance().m_update_callback(UpdatedItems{.rich_presence = true});
OSD::Duration::VERY_LONG, OSD::Color::GREEN,
&instance.GetAchievementBadge(client_event->achievement->id, false));
} }
void AchievementManager::HandleAchievementProgressIndicatorShowEvent( void AchievementManager::HandleAchievementProgressIndicatorShowEvent(