From 8b427de28f0674948098a24f5807aad647af7426 Mon Sep 17 00:00:00 2001 From: LillyJadeKatrin Date: Tue, 2 Jul 2024 08:49:39 -0400 Subject: [PATCH] Remove popups for challenges The challenge popups have proven to be excessive and are no longer useful thanks to the achievements hotkey. Instead, those events will ask for an immediate RP-level update to the achievements dialog, which will among other things re-sort the dialog to show challenges on top faster. --- Source/Core/Core/AchievementManager.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp index 7d7c0af374..544ec36afc 100644 --- a/Source/Core/Core/AchievementManager.cpp +++ b/Source/Core/Core/AchievementManager.cpp @@ -882,9 +882,7 @@ void AchievementManager::HandleAchievementChallengeIndicatorShowEvent( const auto [iter, inserted] = instance.m_active_challenges.insert(client_event->achievement->id); if (inserted) instance.m_challenges_updated = true; - OSD::AddMessage(fmt::format("Challenge Started: {}", client_event->achievement->title), - OSD::Duration::VERY_LONG, OSD::Color::GREEN, - &instance.GetAchievementBadge(client_event->achievement->id, false)); + AchievementManager::GetInstance().m_update_callback(UpdatedItems{.rich_presence = true}); } void AchievementManager::HandleAchievementChallengeIndicatorHideEvent( @@ -894,9 +892,7 @@ void AchievementManager::HandleAchievementChallengeIndicatorHideEvent( const auto removed = instance.m_active_challenges.erase(client_event->achievement->id); if (removed > 0) instance.m_challenges_updated = true; - OSD::AddMessage(fmt::format("Challenge Ended: {}", client_event->achievement->title), - OSD::Duration::VERY_LONG, OSD::Color::GREEN, - &instance.GetAchievementBadge(client_event->achievement->id, false)); + AchievementManager::GetInstance().m_update_callback(UpdatedItems{.rich_presence = true}); } void AchievementManager::HandleAchievementProgressIndicatorShowEvent(