ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SymbolDB: Default constructor and destructor within the cpp file 

Given this is a class with non-trivial data-members, it's preferable to
default the constructor and destructor in the cpp file.
This commit is contained in:
Lioncash 2018-05-27 17:25:20 -04:00
parent a1a81c7bc9
commit 72e8058fb8
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/Common/SymbolDB.cpp
View File

@ -20,6 +20,10 @@ static std::string GetStrippedFunctionName(const std::string& symbol_name)
return name;
}
SymbolDB::SymbolDB() = default;
SymbolDB::~SymbolDB() = default;
void Symbol::Rename(const std::string& symbol_name)
{
this->name = symbol_name;

5
Source/Core/Common/SymbolDB.h
View File

@ -62,8 +62,9 @@ public:
using XFuncMap = std::map<u32, Symbol>;
using XFuncPtrMap = std::map<u32, std::set<Symbol*>>;
SymbolDB() {}
virtual ~SymbolDB() {}
SymbolDB();
virtual ~SymbolDB();
virtual Symbol* GetSymbolFromAddr(u32 addr) { return nullptr; }
virtual Symbol* AddFunction(u32 start_addr) { return nullptr; }
void AddCompleteSymbol(const Symbol& symbol);