From 72e8058fb8221cadd9595ed3b4c08f41c52e0ebf Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Sun, 27 May 2018 17:25:20 -0400
Subject: [PATCH] SymbolDB: Default constructor and destructor within the cpp
 file

Given this is a class with non-trivial data-members, it's preferable to
default the constructor and destructor in the cpp file.
---
 Source/Core/Common/SymbolDB.cpp | 4 ++++
 Source/Core/Common/SymbolDB.h   | 5 +++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Source/Core/Common/SymbolDB.cpp b/Source/Core/Common/SymbolDB.cpp
index eabb098f28..f6f5815dcb 100644
--- a/Source/Core/Common/SymbolDB.cpp
+++ b/Source/Core/Common/SymbolDB.cpp
@@ -20,6 +20,10 @@ static std::string GetStrippedFunctionName(const std::string& symbol_name)
   return name;
 }
 
+SymbolDB::SymbolDB() = default;
+
+SymbolDB::~SymbolDB() = default;
+
 void Symbol::Rename(const std::string& symbol_name)
 {
   this->name = symbol_name;
diff --git a/Source/Core/Common/SymbolDB.h b/Source/Core/Common/SymbolDB.h
index 618ff19067..c6af540eb2 100644
--- a/Source/Core/Common/SymbolDB.h
+++ b/Source/Core/Common/SymbolDB.h
@@ -62,8 +62,9 @@ public:
   using XFuncMap = std::map<u32, Symbol>;
   using XFuncPtrMap = std::map<u32, std::set<Symbol*>>;
 
-  SymbolDB() {}
-  virtual ~SymbolDB() {}
+  SymbolDB();
+  virtual ~SymbolDB();
+
   virtual Symbol* GetSymbolFromAddr(u32 addr) { return nullptr; }
   virtual Symbol* AddFunction(u32 start_addr) { return nullptr; }
   void AddCompleteSymbol(const Symbol& symbol);