Android: Improve GameFileCacheManager comments

This commit is contained in:
JosJuice 2023-03-15 22:12:39 +01:00
parent 3e7a16f225
commit 4203632c93
1 changed files with 4 additions and 2 deletions

View File

@ -160,8 +160,8 @@ public final class GameFileCacheManager
public static GameFile addOrGet(String gamePath) public static GameFile addOrGet(String gamePath)
{ {
// Common case: The game is in the cache, so just grab it from there. // Common case: The game is in the cache, so just grab it from there. (GameFileCache.addOrGet
// (Actually, addOrGet already checks for this case, but we want to avoid calling it if possible // actually already checks for this case, but we want to avoid calling it if possible
// because the executor thread may hold a lock on sGameFileCache for extended periods of time.) // because the executor thread may hold a lock on sGameFileCache for extended periods of time.)
GameFile[] allGames = sGameFiles.getValue(); GameFile[] allGames = sGameFiles.getValue();
for (GameFile game : allGames) for (GameFile game : allGames)
@ -198,6 +198,8 @@ public final class GameFileCacheManager
if (sRunRescanAfterLoad) if (sRunRescanAfterLoad)
{ {
// Without this, there will be a short blip where the loading indicator in the GUI disappears
// because neither sLoadInProgress nor sRescanInProgress is true
sRescanInProgress.postValue(true); sRescanInProgress.postValue(true);
} }