From 4203632c93f4b73c8fd1159272f08ca022063b2b Mon Sep 17 00:00:00 2001 From: JosJuice Date: Wed, 15 Mar 2023 22:12:39 +0100 Subject: [PATCH] Android: Improve GameFileCacheManager comments --- .../dolphinemu/services/GameFileCacheManager.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/services/GameFileCacheManager.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/services/GameFileCacheManager.java index 4c77cfdbc2..02b8b15b9f 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/services/GameFileCacheManager.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/services/GameFileCacheManager.java @@ -160,8 +160,8 @@ public final class GameFileCacheManager public static GameFile addOrGet(String gamePath) { - // Common case: The game is in the cache, so just grab it from there. - // (Actually, addOrGet already checks for this case, but we want to avoid calling it if possible + // Common case: The game is in the cache, so just grab it from there. (GameFileCache.addOrGet + // actually already checks for this case, but we want to avoid calling it if possible // because the executor thread may hold a lock on sGameFileCache for extended periods of time.) GameFile[] allGames = sGameFiles.getValue(); for (GameFile game : allGames) @@ -198,6 +198,8 @@ public final class GameFileCacheManager if (sRunRescanAfterLoad) { + // Without this, there will be a short blip where the loading indicator in the GUI disappears + // because neither sLoadInProgress nor sRescanInProgress is true sRescanInProgress.postValue(true); }