ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dolphin/Source/Core/DolphinQt/TAS/TASCheckBox.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

28 lines
517 B
C
Raw Normal View History

Qt/TAS: Implement turbo mode
2019-03-31 02:49:57 +00:00
// Copyright 2019 Dolphin Emulator Project
treewide: convert GPLv2+ license info to SPDX tags SPDX standardizes how source code conveys its copyright and licensing information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX tags are adopted in many large projects, including things like the Linux kernel.
2021-07-05 01:22:19 +00:00
// SPDX-License-Identifier: GPL-2.0-or-later
Qt/TAS: Implement turbo mode
2019-03-31 02:49:57 +00:00
#pragma once
#include <QCheckBox>
class QMouseEvent;
DolphinQt: Allow customizing TAS input turbo interval As a side effect of 9c5c3c0, Dolphin's frame counter was changed to run at 60/50 Hz even if the game is running at a lower framerate such as 30 fps. Since the TAS input turbo button functionality toggled the state of a button every other frame as reported by the frame counter, this change made the turbo button functionality not work with 30/25 fps games. I believe it would be hard to change the frame counter back to how it used to work without undermining the point of 9c5c3c0, and I'm not sure if doing so would be desireable or not anyway, so what I'm doing instead is letting the user determine how long turbo button presses should last. This lets users avoid the 30/25 fps game problem while also granting additional flexibility. Perhaps there is some game where it is useful to mash at a speed which is slower than frame perfect.
2020-06-30 19:07:25 +00:00
class TASInputWindow;
Qt/TAS: Implement turbo mode
2019-03-31 02:49:57 +00:00
class TASCheckBox : public QCheckBox
{
Q_OBJECT
public:
DolphinQt: Allow customizing TAS input turbo interval As a side effect of 9c5c3c0, Dolphin's frame counter was changed to run at 60/50 Hz even if the game is running at a lower framerate such as 30 fps. Since the TAS input turbo button functionality toggled the state of a button every other frame as reported by the frame counter, this change made the turbo button functionality not work with 30/25 fps games. I believe it would be hard to change the frame counter back to how it used to work without undermining the point of 9c5c3c0, and I'm not sure if doing so would be desireable or not anyway, so what I'm doing instead is letting the user determine how long turbo button presses should last. This lets users avoid the 30/25 fps game problem while also granting additional flexibility. Perhaps there is some game where it is useful to mash at a speed which is slower than frame perfect.
2020-06-30 19:07:25 +00:00
explicit TASCheckBox(const QString& text, TASInputWindow* parent);
Qt/TAS: Implement turbo mode
2019-03-31 02:49:57 +00:00
DolphinQt/TASCheckBox: Mark GetValue() as const This doesn't actually modify the checkbox's state, so this can be marked as a const-qualified member function.
2020-01-27 02:41:28 +00:00
bool GetValue() const;
Qt/TAS: Implement turbo mode
2019-03-31 02:49:57 +00:00
protected:
void mousePressEvent(QMouseEvent* event) override;
private:
DolphinQt: Allow customizing TAS input turbo interval As a side effect of 9c5c3c0, Dolphin's frame counter was changed to run at 60/50 Hz even if the game is running at a lower framerate such as 30 fps. Since the TAS input turbo button functionality toggled the state of a button every other frame as reported by the frame counter, this change made the turbo button functionality not work with 30/25 fps games. I believe it would be hard to change the frame counter back to how it used to work without undermining the point of 9c5c3c0, and I'm not sure if doing so would be desireable or not anyway, so what I'm doing instead is letting the user determine how long turbo button presses should last. This lets users avoid the 30/25 fps game problem while also granting additional flexibility. Perhaps there is some game where it is useful to mash at a speed which is slower than frame perfect.
2020-06-30 19:07:25 +00:00
const TASInputWindow* m_parent;
int m_frame_turbo_started;
int m_turbo_press_frames;
int m_turbo_total_frames;
Qt/TAS: Implement turbo mode
2019-03-31 02:49:57 +00:00
};