ShuriZma
/
desmume
mirror of https://github.com/TASEmulators/desmume.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix use of internal storage of temporary buffer 

The entry index gets converted to a (temporary) string, from which a
pointer to internal data is taken and only consumed outside the loop,
where parent variable no longer exists.
This commit is contained in:
Michał Janiszewski 2022-07-19 13:42:33 +02:00
parent 677c6bb907
commit d107562a16
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
desmume/src/frontend/posix/gtk/main.cpp
View File

@ -2852,8 +2852,10 @@ static void ToggleAutoFrameskip(GSimpleAction *action, GVariant *parameter, gpoi
static void desmume_gtk_menu_tools(GtkApplication *app)
{
std::vector<GActionEntry> entries;
std::vector<std::string> names;
for (int i = 0; i < dTools_list_size; i++) {
GActionEntry entry = {dTools_list[i]->shortname, Start_dTool, "u", std::to_string(i).c_str(), NULL};
names.push_back(std::to_string(i));
GActionEntry entry = {dTools_list[i]->shortname, Start_dTool, "u", names.back().c_str(), NULL};
entries.push_back(entry);
}
g_action_map_add_action_entries(G_ACTION_MAP(app), entries.data(), entries.size(), NULL);