ShuriZma
/
desmume
mirror of https://github.com/TASEmulators/desmume.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fixed possible buffer overflows in string handling

This commit is contained in:
mightymax 2007-01-31 22:52:57 +00:00
parent dd5184c57b
commit 9b83ebf2bb
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
desmume/src/saves.c
View File

@ -66,14 +66,15 @@ void scan_savestates()
for( i = 1; i <= NB_STATES; i++ )
{
strcpy(filename, szRomBaseName);
strncpy(filename, szRomBaseName,260);
if (strlen(filename) + strlen(".dst") + strlen("-2147483648") /* = biggest string for i */ + 1>260) return ;
sprintf(filename+strlen(filename), "%d.dst", i);
if( stat(filename,&sbuf) == -1 ) continue;
savestates[i-1].exists = TRUE;
strcpy(savestates[i-1].date, format_time(sbuf.st_mtime));
strncpy(savestates[i-1].date, format_time(sbuf.st_mtime),40-strlen(savestates[i-1].date));
}
return 1;
return ;
}
void savestate_slot(int num)
@ -81,19 +82,21 @@ void savestate_slot(int num)
struct stat sbuf;
char filename[MAX_PATH];
strcpy(filename, szRomBaseName);
strncpy(filename, szRomBaseName,260);
if (strlen(filename) + strlen(".dst") + strlen("-2147483648") /* = biggest string for num */ + 1>260) return ;
sprintf(filename+strlen(filename), "%d.dst", num);
savestate_save(filename);
savestates[num-1].exists = TRUE;
if( stat(filename,&sbuf) == -1 ) return;
strcpy(savestates[num-1].date, format_time(sbuf.st_mtime));
strncpy(savestates[num-1].date, format_time(sbuf.st_mtime),40-strlen(savestates[num-1].date));
}
void loadstate_slot(int num)
{
char filename[MAX_PATH];
strcpy(filename, szRomBaseName);
strncpy(filename, szRomBaseName,260);
if (strlen(filename) + strlen(".dst") + strlen("-2147483648") /* = biggest string for num */ + 1>260) return ;
sprintf(filename+strlen(filename), "%d.dst", num);
savestate_load(filename);
}