ShuriZma
/
desmume
mirror of https://github.com/TASEmulators/desmume.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

movie.cpp: 

- Fix a buffer overrun bug by disabling reading the ROM checksum in .dsm files for now. (Reading the checksum doesn't work correctly anyways, and nothing currently uses it in practice.)
This commit is contained in:
rogerman 2012-08-24 23:09:08 +00:00
parent 58faffaa26
commit 6e9a041176
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
desmume/src/movie.cpp
View File

@ -224,8 +224,16 @@ void MovieData::installValue(std::string& key, std::string& val)
installInt(val,rerecordCount);
else if(key == "romFilename")
romFilename = val;
else if(key == "romChecksum")
StringToBytes(val,&romChecksum,MD5DATA::size);
else if(key == "romChecksum") {
// TODO: The current implementation of reading the checksum doesn't work correctly, and can
// cause crashes when the MovieData object is deallocated. (This is caused by StringToBytes()
// overrunning romChecksum into romSerial, making romSerial undefined.) Set romChecksum to
// some dummy value for now to prevent crashing. This is okay, since romChecksum isn't actually
// used in practice at this time. - rogerman, 2012/08/24
//StringToBytes(val,&romChecksum,MD5DATA::size);
romChecksum = 0;
}
else if(key == "romSerial")
romSerial = val;
else if(key == "guid")