ShuriZma
/
desmume
mirror of https://github.com/TASEmulators/desmume.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

windows: update cheat list - support removing multiple entries, fix the selection glitch of radio buttons.

This commit is contained in:
gocha 2010-10-03 08:22:46 +00:00
parent c1ad2cc5a4
commit 520bd4e712
2 changed files with 66 additions and 65 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

131
desmume/src/windows/cheatsWin.cpp
View File

@ -218,7 +218,7 @@ INT_PTR CALLBACK CheatsAddProc(HWND dialog, UINT msg,WPARAM wparam,LPARAM lparam
else else
{ {
SetWindowText(GetDlgItem(dialog, IDC_EDIT2), "0"); SetWindowText(GetDlgItem(dialog, IDC_EDIT2), "0");
CheckDlgButton(dialog, IDC_RADIO1, BST_CHECKED); CheckRadioButton(dialog, IDC_RADIO1, IDC_RADIO4, IDC_RADIO1);
} }
memset(editBuf, 0, sizeof(editBuf)); memset(editBuf, 0, sizeof(editBuf));
@ -233,7 +233,7 @@ INT_PTR CALLBACK CheatsAddProc(HWND dialog, UINT msg,WPARAM wparam,LPARAM lparam
GetWindowText(GetDlgItem(dialog, IDC_EDIT2), editBuf[1], 12); GetWindowText(GetDlgItem(dialog, IDC_EDIT2), editBuf[1], 12);
CheckDlgButton(dialog, IDC_CHECK1, BST_CHECKED); CheckDlgButton(dialog, IDC_CHECK1, BST_CHECKED);
CheckDlgButton(dialog, searchSizeIDDs[searchAddSize], BST_CHECKED); CheckRadioButton(dialog, searchSizeIDDs[0], searchSizeIDDs[ARRAY_SIZE(searchSizeIDDs) - 1], searchSizeIDDs[searchAddSize]);
if(searchAddMode == 2) if(searchAddMode == 2)
{ {
@ -403,7 +403,7 @@ INT_PTR CALLBACK CheatsEditProc(HWND dialog, UINT msg,WPARAM wparam,LPARAM lpara
GetWindowText(GetDlgItem(dialog, IDC_EDIT2), editBuf[1], 12); GetWindowText(GetDlgItem(dialog, IDC_EDIT2), editBuf[1], 12);
CheckDlgButton(dialog, IDC_CHECK1, tempCheat.enabled?BST_CHECKED:BST_UNCHECKED); CheckDlgButton(dialog, IDC_CHECK1, tempCheat.enabled?BST_CHECKED:BST_UNCHECKED);
CheckDlgButton(dialog, searchSizeIDDs[tempCheat.size], BST_CHECKED); CheckRadioButton(dialog, searchSizeIDDs[0], searchSizeIDDs[ARRAY_SIZE(searchSizeIDDs) - 1], searchSizeIDDs[tempCheat.size]);
SetWindowText(GetDlgItem(dialog, IDOK), "Update"); SetWindowText(GetDlgItem(dialog, IDOK), "Update");
} }
return TRUE; return TRUE;
@ -674,14 +674,15 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
cheatListView = GetDlgItem(dialog, IDC_LIST1); cheatListView = GetDlgItem(dialog, IDC_LIST1);
ListView_SetExtendedListViewStyle(cheatListView, LVS_EX_FULLROWSELECT | LVS_EX_TWOCLICKACTIVATE); //ListView_SetExtendedListViewStyle(GetDlgItem(hDlg, IDC_CHEAT_LIST), LVS_EX_FULLROWSELECT|LVS_EX_CHECKBOXES);
ListView_SetExtendedListViewStyle(cheatListView, LVS_EX_FULLROWSELECT | LVS_EX_TWOCLICKACTIVATE | LVS_EX_CHECKBOXES);
memset(&lvColumn,0,sizeof(LV_COLUMN)); memset(&lvColumn,0,sizeof(LV_COLUMN));
lvColumn.mask=LVCF_FMT|LVCF_WIDTH|LVCF_TEXT; lvColumn.mask=LVCF_FMT|LVCF_WIDTH|LVCF_TEXT;
lvColumn.fmt=LVCFMT_CENTER; lvColumn.fmt=LVCFMT_CENTER;
lvColumn.cx=20; lvColumn.cx=20;
lvColumn.pszText="X"; lvColumn.pszText="";
ListView_InsertColumn(cheatListView, 0, &lvColumn); ListView_InsertColumn(cheatListView, 0, &lvColumn);
lvColumn.fmt=LVCFMT_LEFT; lvColumn.fmt=LVCFMT_LEFT;
@ -706,15 +707,13 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
while (cheats->getList(&tempCheat)) while (cheats->getList(&tempCheat))
{ {
char buf[256]; char buf[256];
if (tempCheat.enabled) lvi.pszText= "";
lvi.pszText= "X";
else
lvi.pszText= "";
switch (tempCheat.type) switch (tempCheat.type)
{ {
case 0: // Internal case 0: // Internal
{ {
u32 row = ListView_InsertItem(cheatListView, &lvi); u32 row = ListView_InsertItem(cheatListView, &lvi);
ListView_SetCheckState(cheatListView, row, tempCheat.enabled);
wsprintf(buf, "0x02%06X", tempCheat.code[0][0]); wsprintf(buf, "0x02%06X", tempCheat.code[0][0]);
ListView_SetItemText(cheatListView, row, 1, buf); ListView_SetItemText(cheatListView, row, 1, buf);
ltoa(tempCheat.code[0][1], buf, 10); ltoa(tempCheat.code[0][1], buf, 10);
@ -726,6 +725,7 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
case 1: // Action Replay case 1: // Action Replay
{ {
u32 row = ListView_InsertItem(cheatListView, &lvi); u32 row = ListView_InsertItem(cheatListView, &lvi);
ListView_SetCheckState(cheatListView, row, tempCheat.enabled);
ListView_SetItemText(cheatListView, row, 1, "Action"); ListView_SetItemText(cheatListView, row, 1, "Action");
ListView_SetItemText(cheatListView, row, 2, "Replay"); ListView_SetItemText(cheatListView, row, 2, "Replay");
ListView_SetItemText(cheatListView, row, 3, tempCheat.description); ListView_SetItemText(cheatListView, row, 3, tempCheat.description);
@ -735,6 +735,7 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
case 2: // Codebreaker case 2: // Codebreaker
{ {
u32 row = ListView_InsertItem(cheatListView, &lvi); u32 row = ListView_InsertItem(cheatListView, &lvi);
ListView_SetCheckState(cheatListView, row, tempCheat.enabled);
ListView_SetItemText(cheatListView, row, 1, "Code"); ListView_SetItemText(cheatListView, row, 1, "Code");
ListView_SetItemText(cheatListView, row, 2, "breaker"); ListView_SetItemText(cheatListView, row, 2, "breaker");
ListView_SetItemText(cheatListView, row, 3, tempCheat.description); ListView_SetItemText(cheatListView, row, 3, tempCheat.description);
@ -744,6 +745,8 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
} }
SendMessage(cheatListView, WM_SETREDRAW, (WPARAM)TRUE,0); SendMessage(cheatListView, WM_SETREDRAW, (WPARAM)TRUE,0);
EnableWindow(GetDlgItem(dialog, IDOK), FALSE);
ListView_SetItemState(searchListView,0, LVIS_SELECTED|LVIS_FOCUSED, LVIS_SELECTED|LVIS_FOCUSED); ListView_SetItemState(searchListView,0, LVIS_SELECTED|LVIS_FOCUSED, LVIS_SELECTED|LVIS_FOCUSED);
SetFocus(searchListView); SetFocus(searchListView);
return TRUE; return TRUE;
@ -753,46 +756,49 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
if (wparam == IDC_LIST1) if (wparam == IDC_LIST1)
{ {
LPNMHDR tmp_msg = (LPNMHDR)lparam; LPNMHDR tmp_msg = (LPNMHDR)lparam;
if ( tmp_msg->code == LVN_ITEMACTIVATE ) switch (tmp_msg->code)
{ {
cheatEditPos = ListView_GetNextItem(cheatListView, -1, LVNI_SELECTED|LVNI_FOCUSED); case LVN_ITEMCHANGED:
cheats->get(&tempCheat, cheatEditPos);
tempCheat.enabled = !tempCheat.enabled;
switch (tempCheat.type)
{ {
case 0: // internal NM_LISTVIEW* pNMListView = (NM_LISTVIEW*)lparam;
cheats->update(tempCheat.size, tempCheat.code[0][0], tempCheat.code[0][1], tempCheat.description, tempCheat.enabled, cheatEditPos); if((pNMListView->uOldState ^ pNMListView->uNewState) & LVIS_SELECTED) // on selection changed
break; {
int selCount = ListView_GetSelectedCount(cheatListView);
EnableWindow(GetDlgItem(dialog, IDC_BEDIT), (selCount == 1) ? TRUE : FALSE);
EnableWindow(GetDlgItem(dialog, IDC_BREMOVE), (selCount >= 1) ? TRUE : FALSE);
}
case 1: // Action Replay UINT oldStateImage = pNMListView->uOldState & LVIS_STATEIMAGEMASK;
cheats->update_AR(NULL, NULL, tempCheat.enabled, cheatEditPos); UINT newStateImage = pNMListView->uNewState & LVIS_STATEIMAGEMASK;
break; if(oldStateImage != newStateImage &&
(oldStateImage == INDEXTOSTATEIMAGEMASK(1) || oldStateImage == INDEXTOSTATEIMAGEMASK(2)) &&
(newStateImage == INDEXTOSTATEIMAGEMASK(1) || newStateImage == INDEXTOSTATEIMAGEMASK(2))) // on checked changed
{
bool checked = (newStateImage == INDEXTOSTATEIMAGEMASK(2));
cheatEditPos = pNMListView->iItem;
cheats->get(&tempCheat, cheatEditPos);
if ((bool)tempCheat.enabled != checked)
{
tempCheat.enabled = checked;
switch (tempCheat.type)
{
case 0: // internal
cheats->update(tempCheat.size, tempCheat.code[0][0], tempCheat.code[0][1], tempCheat.description, tempCheat.enabled, cheatEditPos);
break;
case 2: // Codebreaker case 1: // Action Replay
cheats->update_CB(NULL, NULL, tempCheat.enabled, cheatEditPos); cheats->update_AR(NULL, NULL, tempCheat.enabled, cheatEditPos);
break; break;
}
case 2: // Codebreaker
cheats->update_CB(NULL, NULL, tempCheat.enabled, cheatEditPos);
if (tempCheat.enabled) break;
ListView_SetItemText(cheatListView, cheatEditPos, 0, "X") }
else EnableWindow(GetDlgItem(dialog, IDOK), TRUE);
ListView_SetItemText(cheatListView, cheatEditPos, 0, ""); }
EnableWindow(GetDlgItem(dialog, IDOK), TRUE); }
}
if ( tmp_msg->code == NM_CLICK )
{
if (ListView_GetNextItem(cheatListView, -1, LVNI_SELECTED|LVNI_FOCUSED) != -1)
{
EnableWindow(GetDlgItem(dialog, IDC_BEDIT), TRUE);
EnableWindow(GetDlgItem(dialog, IDC_BREMOVE), TRUE);
}
else
{
EnableWindow(GetDlgItem(dialog, IDC_BEDIT), FALSE);
EnableWindow(GetDlgItem(dialog, IDC_BREMOVE), FALSE);
} }
break;
} }
return TRUE; return TRUE;
@ -830,16 +836,13 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
lvi.mask = LVIF_TEXT|LVIF_STATE; lvi.mask = LVIF_TEXT|LVIF_STATE;
lvi.iItem = INT_MAX; lvi.iItem = INT_MAX;
if (searchAddFreeze)
lvi.pszText= "X";
else
lvi.pszText= " ";
u32 row = ListView_InsertItem(cheatListView, &lvi); u32 row = ListView_InsertItem(cheatListView, &lvi);
wsprintf(buf, "0x02%06X", searchAddAddress); wsprintf(buf, "0x02%06X", searchAddAddress);
ListView_SetItemText(cheatListView, row, 1, buf); ListView_SetItemText(cheatListView, row, 1, buf);
ltoa(searchAddValue, buf, 10); ltoa(searchAddValue, buf, 10);
ListView_SetItemText(cheatListView, row, 2, buf); ListView_SetItemText(cheatListView, row, 2, buf);
ListView_SetItemText(cheatListView, row, 3, editBuf[2]); ListView_SetItemText(cheatListView, row, 3, editBuf[2]);
ListView_SetCheckState(cheatListView, row, searchAddFreeze);
EnableWindow(GetDlgItem(dialog, IDOK), TRUE); EnableWindow(GetDlgItem(dialog, IDOK), TRUE);
} }
@ -869,10 +872,6 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
lvi.mask = LVIF_TEXT|LVIF_STATE; lvi.mask = LVIF_TEXT|LVIF_STATE;
lvi.iItem = INT_MAX; lvi.iItem = INT_MAX;
if (tempCheat.enabled)
lvi.pszText= "X";
else
lvi.pszText= " ";
u32 row = ListView_InsertItem(cheatListView, &lvi); u32 row = ListView_InsertItem(cheatListView, &lvi);
if (cheatXXtype == 0) if (cheatXXtype == 0)
{ {
@ -885,6 +884,7 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
ListView_SetItemText(cheatListView, row, 2, "breaker"); ListView_SetItemText(cheatListView, row, 2, "breaker");
} }
ListView_SetItemText(cheatListView, row, 3, tempCheat.description); ListView_SetItemText(cheatListView, row, 3, tempCheat.description);
ListView_SetCheckState(cheatListView, row, tempCheat.enabled);
EnableWindow(GetDlgItem(dialog, IDOK), TRUE); EnableWindow(GetDlgItem(dialog, IDOK), TRUE);
} }
@ -905,8 +905,7 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
{ {
char buf[256]; char buf[256];
cheats->get(&tempCheat, cheatEditPos); cheats->get(&tempCheat, cheatEditPos);
if (tempCheat.enabled) ListView_SetCheckState(cheatListView, cheatEditPos, tempCheat.enabled);
ListView_SetItemText(cheatListView, cheatEditPos, 0, "X");
wsprintf(buf, "0x02%06X", tempCheat.code[0][0]); wsprintf(buf, "0x02%06X", tempCheat.code[0][0]);
ListView_SetItemText(cheatListView, cheatEditPos, 1, buf); ListView_SetItemText(cheatListView, cheatEditPos, 1, buf);
ltoa(tempCheat.code[0][1], buf, 10); ltoa(tempCheat.code[0][1], buf, 10);
@ -927,8 +926,7 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
if (DialogBoxW(hAppInst, MAKEINTRESOURCEW(IDD_CHEAT_ADD_XX_CODE), dialog, (DLGPROC) CheatsAdd_XX_Proc)) if (DialogBoxW(hAppInst, MAKEINTRESOURCEW(IDD_CHEAT_ADD_XX_CODE), dialog, (DLGPROC) CheatsAdd_XX_Proc))
{ {
cheats->get(&tempCheat, cheatEditPos); cheats->get(&tempCheat, cheatEditPos);
if (tempCheat.enabled) ListView_SetCheckState(cheatListView, cheatEditPos, tempCheat.enabled);
ListView_SetItemText(cheatListView, cheatEditPos, 0, "X");
if (cheatXXtype == 0) if (cheatXXtype == 0)
{ {
@ -951,16 +949,19 @@ INT_PTR CALLBACK CheatsListBox_Proc(HWND dialog, UINT msg,WPARAM wparam,LPARAM l
case IDC_BREMOVE: case IDC_BREMOVE:
{ {
int tmp_pos = ListView_GetNextItem(cheatListView, -1, LVNI_SELECTED|LVNI_FOCUSED); while(true)
if (tmp_pos != -1)
{ {
int tmp_pos = ListView_GetNextItem(cheatListView, -1, LVNI_ALL | LVNI_SELECTED);
if (tmp_pos == -1)
{
break;
}
if (cheats->remove(tmp_pos)) if (cheats->remove(tmp_pos))
{ {
ListView_DeleteItem(cheatListView, tmp_pos); ListView_DeleteItem(cheatListView, tmp_pos);
EnableWindow(GetDlgItem(dialog, IDOK), TRUE);
} }
} }
EnableWindow(GetDlgItem(dialog, IDOK), TRUE);
} }
return TRUE; return TRUE;
@ -1087,8 +1088,8 @@ INT_PTR CALLBACK CheatsSearchCompWnd(HWND dialog, UINT msg,WPARAM wparam,LPARAM
EnableWindow(hBView, FALSE); EnableWindow(hBView, FALSE);
EnableWindow(hBSearch, TRUE); EnableWindow(hBSearch, TRUE);
CheckDlgButton(dialog, searchCompIDDs[searchComp], BST_CHECKED); CheckRadioButton(dialog, searchCompIDDs[0], searchCompIDDs[ARRAY_SIZE(searchCompIDDs) - 1], searchCompIDDs[searchComp]);
char buf[256]; char buf[256];
ltoa(searchNumberResults, buf, 10); ltoa(searchNumberResults, buf, 10);
SetWindowText(GetDlgItem(dialog, IDC_SNUMBER), buf); SetWindowText(GetDlgItem(dialog, IDC_SNUMBER), buf);
@ -1212,9 +1213,9 @@ INT_PTR CALLBACK CheatsSearchMainWnd(HWND dialog, UINT msg,WPARAM wparam,LPARAM
{ {
case WM_INITDIALOG: case WM_INITDIALOG:
{ {
CheckDlgButton(dialog, searchSizeIDDs[searchSize], BST_CHECKED); CheckRadioButton(dialog, searchSizeIDDs[0], searchSizeIDDs[ARRAY_SIZE(searchSizeIDDs) - 1], searchSizeIDDs[searchSize]);
CheckDlgButton(dialog, searchSignIDDs[searchSign], BST_CHECKED); CheckRadioButton(dialog, searchSignIDDs[0], searchSignIDDs[ARRAY_SIZE(searchSignIDDs) - 1], searchSignIDDs[searchSign]);
CheckDlgButton(dialog, searchTypeIDDs[searchType], BST_CHECKED); CheckRadioButton(dialog, searchTypeIDDs[0], searchTypeIDDs[ARRAY_SIZE(searchTypeIDDs) - 1], searchTypeIDDs[searchType]);
for (int i = 0; i < 4; i++) for (int i = 0; i < 4; i++)
SetWindowText(GetDlgItem(dialog, searchRangeIDDs[i]), searchRangeText[searchSign][i]); SetWindowText(GetDlgItem(dialog, searchRangeIDDs[i]), searchRangeText[searchSign][i]);
EnableWindow(hBRestart, FALSE); EnableWindow(hBRestart, FALSE);

BIN
desmume/src/windows/resources.rc
View File

Binary file not shown.