ShuriZma
/
desmume
mirror of https://github.com/TASEmulators/desmume.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gpu: fix bug with 16color bg overdrawing line buffer by one pixel when scrolled to an odd offset. move assert x<256 lower in callstack to help spot these bugs more aggressively.

This commit is contained in:
zeromus 2009-08-03 21:41:07 +00:00
parent 77da6267bf
commit 4015411ad6
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
desmume/src/GPU.cpp
View File

@ -784,11 +784,10 @@ FORCEINLINE void GPU::__setFinalColorBck(u16 color, const u32 x, const int opaqu
template<bool MOSAIC, bool BACKDROP, int FUNCNUM>
FORCEINLINE void GPU::___setFinalColorBck(u16 color, const u32 x, const int opaque)
{
//I commented out this line to make a point.
//under ordinary circumstances, nobody should pass in something >=256
//but in fact, someone is going to try. specifically, that is the map viewer debug tools
//which try to render the enter BG. in cases where that is large, it could be up to 1024 wide.
//assert(x<256);
assert(debug || x<256);
int x_int;
@ -960,9 +959,12 @@ template<bool MOSAIC> INLINE void renderline_textBG(GPU * gpu, u16 XBG, u16 YBG,
x++; xoff++;
}
color = T1ReadWord(pal, ((currLine&0xF) + tilePalette) << 1);
gpu->__setFinalColorBck<MOSAIC,false>(color,x,currLine&0xF);
x++; xoff++;
if(x<xfin)
{
color = T1ReadWord(pal, ((currLine&0xF) + tilePalette) << 1);
gpu->__setFinalColorBck<MOSAIC,false>(color,x,currLine&0xF);
x++; xoff++;
}
}
} else {
line += ((xoff&7)>>1);
@ -977,9 +979,12 @@ template<bool MOSAIC> INLINE void renderline_textBG(GPU * gpu, u16 XBG, u16 YBG,
x++; xoff++;
}
color = T1ReadWord(pal, ((currLine>>4) + tilePalette) << 1);
gpu->__setFinalColorBck<MOSAIC,false>(color,x,currLine>>4);
x++; xoff++;
if(x<xfin)
{
color = T1ReadWord(pal, ((currLine>>4) + tilePalette) << 1);
gpu->__setFinalColorBck<MOSAIC,false>(color,x,currLine>>4);
x++; xoff++;
}
}
}
}