mirror of https://github.com/bsnes-emu/bsnes.git
ee982f098a
byuu says:
Changelog:
- tomoko: removed "Settings→Video Emulation→Overscan Mask" setting¹
- tomoko: remove a few unnecessary calls to resizeViewport on startup
- tomoko: only resize main window from video settings when in adaptive
or toggling adaptive mode²
- hiro/windows: add `SWP_NOACTIVATE` flag to prevent focus stealing on
resizing invisible windows³
- hiro/windows: suppress spurious API-generated `onSize()` callback
when calling `setVisible()`
¹: it just seemed like bad design to default to overscan masking
being disabled with overscan masks of 8 horizontal, 8 vertical out of
the box. Users would adjust the sliders and not see anything happening.
Instead, I've set the default masks to zero. If you want to turn off
overscan masking, simply slide those to zero again.
²: I figure the only way we're going to be able to fairly evaluate
Screwtape's suggestion is to try it both ways. And I will admit, I kind
of like the way this works as well ... a lot more so than I thought I
would, so I think it was a great suggestion. Still, now's the time if
people have strong opinions on this. Be sure to try both r10 and r11 to
compare. Barring no other feedback, I'm going to keep it this way.
³: this fixes the blinking of the main window on startup.
Screwtape, thanks again for the improvement suggestions. At this point
though, I am not using a tiling window manager. If you are able to patch
hiro/gtk and/or hiro/qt (I mostly use GTK) to work with tiling window
managers better, I wouldn't mind applying said patches, so long as they
don't break things on my own Xfce desktop with xfwm4.
Also, I noticed one issue with Xfce ... if the window is maximized and I
try to call `Window::setSize()`, it's not actually removing the maximize
flag. We'll need to look into how to add that to GTK, but I don't think
it's a huge issue. A similar glitch happens on windows where the icon
still reflects being maximized, but it does actually shrink, it just
sticks to the top left corner of the screen. So this isn't really a
critical bug, but would be extra polish.
|
||
|---|---|---|
| .. | ||
| action | ||
| widget | ||
| application.cpp | ||
| application.hpp | ||
| browser-window.cpp | ||
| browser-window.hpp | ||
| desktop.cpp | ||
| desktop.hpp | ||
| font.cpp | ||
| font.hpp | ||
| group.cpp | ||
| group.hpp | ||
| header.hpp | ||
| hiro.Manifest | ||
| hiro.rc | ||
| keyboard.cpp | ||
| keyboard.hpp | ||
| layout.cpp | ||
| layout.hpp | ||
| menu-bar.cpp | ||
| menu-bar.hpp | ||
| message-window.cpp | ||
| message-window.hpp | ||
| monitor.cpp | ||
| monitor.hpp | ||
| mouse.cpp | ||
| mouse.hpp | ||
| object.cpp | ||
| object.hpp | ||
| platform.cpp | ||
| platform.hpp | ||
| popup-menu.cpp | ||
| popup-menu.hpp | ||
| sizable.cpp | ||
| sizable.hpp | ||
| status-bar.cpp | ||
| status-bar.hpp | ||
| timer.cpp | ||
| timer.hpp | ||
| utility.cpp | ||
| window.cpp | ||
| window.hpp | ||