Commit Graph

918 Commits

Author SHA1 Message Date
libretroadmin fe529ff591 Refactor away menu_driver_list_cache 2023-05-12 01:00:08 +02:00
libretroadmin b105fa5a4f Make one function static 2023-05-11 23:14:36 +02:00
libretroadmin 7db9a4acfa Header cleanups 2023-05-11 05:45:04 +02:00
libretroadmin f2bb150b0a Get rid of some menu_driver_ctl calls 2023-05-11 05:22:17 +02:00
libretroadmin c78e83978a Refactor menu_entries_ctl into menu_entries_clear 2023-05-11 03:29:45 +02:00
libretroadmin 0f97bf52b9 Create menu_displaylist_refresh 2023-05-11 02:07:56 +02:00
libretroadmin 07cb5f4e98 Remove MENU_ENTRIES_CTL_SET_REFRESH 2023-05-11 01:58:30 +02:00
libretroadmin c3b16e1803 Get rid of MENU_ENTREIS_CTL_UNSET_REFRESH and
MENU_ENTRIES_CTL_GET_REFRESH
2023-05-11 01:18:26 +02:00
libretroadmin 91ea92e50b Get rid of some menu_driver_ctl commands 2023-05-10 21:30:09 +02:00
libretroadmin 3706c4e464 Cleanups 2023-05-10 19:03:16 +02:00
libretroadmin 1ad253e81a Get rid of menu_input_{get|set}_selection 2023-05-10 18:45:49 +02:00
libretroadmin 0674613d28 Change return types of menu_driver_list_get_selection/get_size
and simplify struct
2023-05-10 08:36:44 +02:00
libretroadmin 5de30567a1 Get rid of MENU_ENTRIES_CTL_SETTINGS_GET 2023-05-10 07:28:14 +02:00
libretroadmin 74ad3723f9 Get rid of more extraneous menu wrapper functions 2023-05-10 06:37:40 +02:00
libretroadmin 6c22249ae9 Get rid of menu_entries_get_selection_buf_ptr and menu_entries_get_size 2023-05-10 05:52:52 +02:00
libretroadmin 29329ba62f remove menu_entries_get_stack_size 2023-05-10 05:03:40 +02:00
libretroadmin 9861073363 Get rid of menu_entries_get_menu_stack_ptr 2023-05-10 04:48:27 +02:00
libretroadmin a1e4918288 Cleanups 2023-05-10 04:18:00 +02:00
libretroadmin c09268f4f4 Turn some functions static 2023-05-09 04:58:06 +02:00
libretroadmin 08f71a9b1e (Menu) Cleanups - make functions static and remove some unnecessary
wrapper functions
2023-05-09 04:41:12 +02:00
sonninnos 47d71646c9 Add menu scroll home+end actions 2023-05-08 15:25:51 +02:00
libretroadmin dfc157d1d0 Small cleanups 2023-05-06 23:19:39 +02:00
libretroadmin 80b640f62e Get rid of unnecessary function 2023-05-06 22:29:44 +02:00
libretroadmin 099f33e0b3 (Menu) Simplifications 2023-05-06 22:10:55 +02:00
libretroadmin 02a849d440 Move RGUI specific code to RGUI file 2023-05-06 20:16:59 +02:00
libretroadmin 6d9482f3f0 (Menu) Cut down on small superfluos wrapper functions 2023-05-06 17:19:40 +02:00
libretroadmin ead88eebfe (Menu) Get rid of a bunch of useless wrpaper function calls 2023-05-06 07:39:20 +02:00
libretroadmin bf370ce284 Turn more functions static 2023-05-06 02:34:02 +02:00
libretroadmin ec8aa8e186 Turn functions static 2023-05-05 22:03:41 +02:00
libretroadmin d64f11a0f7 menu_update_fullscreen_thumbnail_label - some refinements 2023-05-02 00:21:37 +02:00
libretroadmin b951a010fd Move strftime_am_pm to libretro-common and get rid of duplicated
function
2023-05-01 19:03:11 +02:00
sonninnos b2ff445531
(Ozone) Sidebar multiline scrolling (#15242) 2023-05-01 05:26:31 +02:00
libretroadmin c087b044c2 * Add TODO/FIXME localize notes
* More snprintf optimizations
2023-04-30 19:30:07 +02:00
libretroadmin 254773339b Silence some unused variable warnings 2023-04-30 17:43:46 +02:00
libretroadmin dfd0d6b14a Turn another function static 2023-04-29 14:38:31 +02:00
libretroadmin 138784a32d Turn another function static 2023-04-29 14:38:31 +02:00
libretroadmin 1a91aabd08 (menu_driver) Turn more functions static 2023-04-29 14:38:31 +02:00
libretroadmin 661f315aa8 (Menu) Turn some functions static 2023-04-29 14:38:31 +02:00
libretroadmin bce958780d Remove unused ui_companion_notify_list_loaded - and menu_list member
from menu_displaylist_info
2023-04-26 20:21:07 +02:00
libretroadmin 07eddd7229 Cleanups 2023-04-23 16:09:24 +02:00
Joe Osborn 2125770236
Replay UI support (#15048)
* Add bsv replay controls (not yet fully implemented), remove toggle

see notes in task_movie.c, make sure command.c calls the right
functions, check retroarch.c and other todos.

bsv files are also now stored with states, not saves.

* Compilation fixes

* Added command impls for play and record replay, and some code in load state to do the right thing there

* Guard some parts of the new code with HAVE_BSV_MOVIE

* wip, menu fixes

* more menu fixes, osd for movie errors, halt recording properly

* Menu and label fixes

* move bsvs to own file suffix series under savestates, fix recording and playback command validity checks

* Fix replay autoincrement

* fix endif placement, whoops

---------

Co-authored-by: Joseph C. Osborn <jcoa2018@pomona.edu>
2023-03-03 00:52:22 +01:00
libretroadmin 51d238875e Get rid of obsolete HAVE_VIDEO_LAYOUT - obsolete spec, was only
ever implemented for OpenGL2 driver, lots of code debt, best to
instead just keep improving the overlay system instead which is
already available for most video drivers
2023-02-23 21:03:41 +01:00
libretroadmin a4dda41739 (PSL1GHT) Buildfixes/warning fixes 2023-02-20 15:33:54 +01:00
sonninnos b1b7fb56a9
(Ozone) Refresh thumbnail on close content hotkey (#14924) 2023-01-29 14:52:53 +01:00
libretroadmin 378e90e745 retroarch.h functions should be namespaced 'retroarch_' instead
of 'rarch_'
2023-01-22 16:58:22 +01:00
sonninnos f8e94861b2
Core option setting type checks (#14852) 2023-01-15 16:06:56 +01:00
sonninnos 2f1a03523b
Hotkey blocking correction (#14831) 2023-01-13 04:56:14 +01:00
neil4 7213aada8d
Add Preemptive Frames to Latency Settings (#14832) 2023-01-10 07:22:14 +01:00
libretroadmin 8a3686df58 Revert "Header cleanups - don't include retroarch.h everywhere"
This reverts commit 0e3b478f8c.
2023-01-08 09:05:46 +01:00
libretroadmin 0e3b478f8c Header cleanups - don't include retroarch.h everywhere 2023-01-08 08:56:57 +01:00
Skirlez f2c16bd8d6 Scroll sound fixes
correctly get list size in xmb.c for playing scrolling sound when switching categories, play the scrolling sound when pressing cancel in ozone, play the sound when scrolling with ZL and ZR, play the correct sound when scrolling with L
2023-01-07 20:08:21 +01:00
Skirlez 9e668e1673 really fix build errors 2023-01-07 12:09:11 +01:00
Skirlez 8a127eff02 Better scrolling sound implementation, add new 'notice back' sound
The closing info box sound (NOTICE_BACK) plays if you have the regular notice sound on, implemented generally.

audio_driver_mixer_play_menu_sound(i) will now stop sound i before playing it, so when you for example, cancel in rapid succession, it will properly play all canceling sound effects instead of not doing anything if the sound is already playing.

This scrolling implementation is a lot more general than the first one, to the point where RGUI plays all the correct sounds without any special additions. However, the Ozone sidebar scrolling or category switching in XMB or MaterialUI are still handled inside their driver .c files.
This implementation also fixes an issue where if wraparound was disabled the sound would still play if you held on a direction. I've also fixed it manually for XMB category switching, since it's still handled there individually (turns out, Ozone sidebar and MaterialUI categories just don't respect the no wraparound option, so there's no need to implement a fix there as well)
2023-01-07 12:09:11 +01:00
sonninnos 0be1aa0420
Add config + input related sublabels (#14781) 2022-12-30 00:48:04 +01:00
sonninnos 3092fda58b
Fix menu switch icon correction crash (#14774) 2022-12-27 21:41:49 +01:00
sonninnos d5f58fd435
Menu switch icon corrections (#14766) 2022-12-25 18:17:16 +01:00
libretroadmin e82b75c769 Fix more C89_BUILD issues 2022-12-22 23:10:15 +01:00
LibretroAdmin f836328c56
Append Preset (#14737) (#14757)
WIP version of Append and Prepend preset, Includes UI for Standard Retroarch, but not the QT UI companion

Co-authored-by: HyperspaceMadness <remimcgill@hotmail.com>
2022-12-22 21:36:32 +01:00
sonninnos 05c3c0a552
Automatic Frame Delay improvements (#14754) 2022-12-22 18:58:26 +01:00
sonninnos 883e88fa73
Keyboard event blocking corrections (#14728) 2022-12-18 18:36:24 +01:00
sonninnos 16ca87c327
Rename Standalone Cores to Contentless Cores (#14738) 2022-12-16 19:02:24 +01:00
zoltanvb e6421f6f8b
Use sublabel as help text if there is no suitable definition. (#14714)
* Use sublabel as help text if there is no suitable definition.

* code style update
2022-12-10 18:06:45 +01:00
LibretroAdmin c75af6194b
Extended IME and Korean OSK (#14676) 2022-11-29 04:45:55 +01:00
neil4 3b0db75782
Overlay cleanups; replace bools with flags (#14661) 2022-11-22 18:29:11 +01:00
sonninnos e0e6810cf0
Allow toggling info off with the same button (#14660) 2022-11-22 17:23:19 +01:00
sonninnos 9bc7bebf51
More hotkey cleanups (#14657) 2022-11-22 14:45:30 +01:00
libretroadmin 6b71214ed7 Silence some signed/unsigned mismatch warnings 2022-11-21 19:34:43 +01:00
libretroadmin 59cce09186 Menu cleanups:
* Some control flow improvements in callback functions, less return
paths
* Remove menu_cbs_exit(), which was a stub function that always returned
-1
2022-11-20 18:55:07 +01:00
Richard c0926ad1a1
feat(iOS13): Pointer Movement Accuracy (#14641)
Co-authored-by: Richard <rf2222222@github.com>
2022-11-18 19:45:36 +01:00
libretroadmin a50f9bae85 Turn scroll.mode into enum 2022-11-17 19:44:42 +01:00
sonninnos 3b921ffbfa
Fix shader toggle and add hotkey + sublabel (#14628) 2022-11-15 22:14:09 +01:00
sonninnos 1c7855acc8
Add option for swapping menu scrolling buttons (#14577) 2022-11-01 19:48:28 +01:00
LibretroAdmin d0b3c1742d (Video) use flags for FBO passes, GL2 renderchain, etc 2022-10-26 21:21:21 +02:00
LibretroAdmin 94a3eba9ef Turn checked into flag for menu_entry_t 2022-10-26 00:28:57 +02:00
LibretroAdmin 0d16eb6e10 (Menu) menu_entries - get rid of boolean variables and
turn them into flags
2022-10-25 17:22:35 +02:00
LibretroAdmin d30f16dc79 Remove cursor directory/cursor manager list - Views obsoleted
this
2022-10-25 15:21:47 +02:00
LibretroAdmin 41de5ec80b Cleanups for runloop_state grabbing 2022-10-10 20:32:46 +02:00
LibretroAdmin d100e73780 Use more runloop flags 2022-10-10 08:59:27 +02:00
LibretroAdmin d506210fbe
(menu_driver.c) Use flags instead of bools (#14500)
* (menu_driver.c) Use flags instead of bools
2022-10-08 22:52:18 +02:00
LibretroAdmin fcbd72dbf3
Use flags pt4 (#14497)
* * Use flags for rarch_state
* Get rid of ^M linebreaks in retroarch_types.h

* Buildfixes for consoles

* (audio driver) use flags instead of bools

* (video) Use flags instead of bools

* Rewrite input driver state bools into flags
2022-10-08 10:39:15 +02:00
LibretroAdmin f8a9b0a197 Combine bit setting 2022-10-05 20:42:30 +02:00
LibretroAdmin e5897caa8f Cut down on menu_displaylist_info_t size - use flags instead of all
these boolean members
2022-10-03 18:13:32 +02:00
LibretroAdmin 8c49eed56c rarch_setting - remove dont_use_enum_idx_representation value -
set it as a flag instead
2022-10-03 15:42:36 +02:00
LibretroAdmin 045fd38f19 Reduce tertiary operators 2022-09-13 10:28:03 +02:00
tr12345 8cc866b051
New Menu Items for disabling Info & Search buttons in the menu (#14259)
* New Menu Items Disable Info & Search

Add menu options for disabling Info and   Search buttons

* Update msg_hash_us.h

Update Sublabels

* Update menu_setting.c

Set Advanced flag for new settings
2022-09-12 23:17:24 +02:00
sonninnos c4c55077a1
Allow On-Demand Thumbnails in Explore menu (#14385) 2022-09-05 00:01:38 +02:00
LibretroAdmin dfb4b603e4 Get rid of superfluous wrapper function file_list_get_at_offset 2022-09-04 07:30:21 +02:00
LibretroAdmin 1a24bfe60c (file_list) Get rid of useless wrapper functions 2022-09-04 05:39:16 +02:00
LibretroAdmin 6f84af2efa * Simplify menu_entries_get_title
* Add TODO/FIXME - localize strings to hardcoded strings
* Some more simplifications in for loops
2022-09-01 15:42:25 +02:00
LibretroAdmin 60030e373e
Reduce snprintfs + assorted cleanups (#14369)
* Reduce snprintf and/or use them only for concatenating the
string formatting of numbers/values
* Reduce snprintfs
* Use snprintf for concatenation at parts
* * We don't need to NULL-terminate strings that get passed to strlcpy/strlcat
and friends
* Use snprintf for concatenation in certain instances
* Do away with some string intermediary copies where we can avoid it
* Fix warning unused variable
* * Reduce snprintf calls
* Rewrite snprintf calls into strlcpy where possible
* Use snprintf for concatenation when necessary
* Do away with some string intermediary copies in task_translation.c
* run_translation_service - make switch slightly smaller
2022-09-01 04:17:07 +02:00
sonninnos 9b60e6c993 Menu paging navigation adjustments 2022-08-31 21:34:47 +03:00
sonninnos a96c5f77c8
(Ozone/XMB/RGUI) Explore menu thumbnails (#14365) 2022-08-31 14:42:10 +02:00
LibretroAdmin f1ff92c881 * menu_entries_append and menu_entries_append_enum are now combined into
one - if you set the last parameter to a valid 'rarch_setting_t' pointer
and enum_msg to MSG_UNKNOWN, you will get the previous menu_entries_append
behavior
* Renamed remaining function to menu_entries_append so that we have one
consistent way of adding menu entries instead of two
Reduces some code duplication significantly
2022-08-27 17:40:52 +02:00
LibretroAdmin 25b76fdb54 input_keyboard_osk_event_append and others: don't call strlen
implicitly, always leave it up to caller
font_driver_get_message_width - try to avoid scenario where 'len'
is 0
2022-08-27 15:13:56 +02:00
LibretroAdmin 575e331fd1 If we already know the length of the string, use strldup instead.
Avoids the internal strlen call inside strdup, and strdup is a deprecated
function starting from MSVC2005 anyways.

NOTE: Do NOT pass STRLEN_CONST as n parameter to strldup, it needs to
be at least +1 character higher than the strlen return value of the same
string
2022-08-25 16:31:54 +02:00
sonninnos 8fd0961c9a
Show playlist entry as 'Quick Menu' header title (#14350) 2022-08-25 04:41:14 +02:00
LibretroAdmin 2bc723bb4b (Menu) Move duplicate code is_running_quickmenu to menu_driver.c 2022-08-24 13:28:53 +02:00
LibretroAdmin a147cb09d9 Get rid of duplicate code - move function to menu_driver.c and have
both XMB and Ozone use it
2022-08-24 13:14:55 +02:00
LibretroAdmin 6f738d4fbd Gradually get rid of strcpy_literal
Reasons:
1 - Just a macro for strcpy
1.2 - doesn't have a return type unlike strlcpy, can't be used
for string concatenation
1.3 - unsafe compared to strlcpy

Do either manual string assignment per character or strlcpy, no
inbetween by resorting to strcpy
2022-08-23 15:04:47 +02:00
LibretroAdmin b2634ea588 * Create fill_pathname_join_special - and specify fill_pathname_join
as deprecated.
* Use fill_pathname_join_special in the vast majority of cases where
we can ensure out_path is a new empty string
* Get rid of some extension concatenation with strlcat where encountered
* Some general cleanups with NULL termination of strings that get immediately
passed to strlcpy/strlcpy-adjacent functions
2022-08-04 14:19:38 +02:00