d910f520d9
Don't pass entire settings pointer if we just need a few settings variables
...
to read
2021-04-10 13:03:53 +02:00
5ca666acee
Cleanups, don't try to pass settings pointer to functions unless we have to
2021-04-10 03:01:25 +02:00
338c2eb2f0
Settings cleanups
2021-04-10 01:51:28 +02:00
deccc4d8c6
Some refactors
2021-04-10 00:54:40 +02:00
204eaf0e76
Don't grab settings pointer inside video_driver_frame
2021-04-08 20:01:59 +02:00
421dbb19c2
Don't pass settings pointer if we just need a couple of variables
...
that we won't mutate
2021-04-08 19:45:30 +02:00
f7a5833cb0
Turn bunch of functions static
2021-04-08 18:33:46 +02:00
42bd709f67
Old MSVC buildfix
2021-04-08 17:31:23 +02:00
2c7226de20
Less pointer grabbing
2021-04-08 17:08:46 +02:00
d6c243143d
Simplifications to dir_init_shader_internal
2021-04-08 16:49:23 +02:00
d80833d892
Accessibility speak fix.
2021-04-07 20:39:25 -07:00
fb1258b817
Set anim.update_timecb to NULL immediately after menu driver's 'free'
...
function has been called
2021-04-08 01:37:47 +02:00
e5e8e9b5d8
Expand widget init function
2021-04-08 00:51:10 +02:00
95527fb566
Prevent some unnecessary variables being set
2021-04-08 00:22:29 +02:00
412a1885b2
Cleanups
2021-04-07 00:42:38 +02:00
886a692f1a
video_driver_init_internal - don't call small one-line functions - set
...
directly
2021-04-07 00:36:00 +02:00
d5ebf9039c
Cleanups
2021-04-06 23:05:40 +02:00
789cf29d28
Pass more pointers
2021-04-06 22:35:47 +02:00
f8a88fcb94
Cleanups
2021-04-06 20:17:06 +02:00
29a358ee3a
Pass settings pointer around to more functions
2021-04-06 20:07:06 +02:00
29513919ca
Rewrite retroarch_load_shader_preset_internal - no longer needs
...
p_rarch
2021-04-06 19:41:46 +02:00
45beb1bcdd
Cleanups - pass pointers around instead of grabbing
...
p_rarch->configuration_settings everywhere; add some verbosity_enabled
checks
2021-04-06 19:31:04 +02:00
529c0f24da
Silence some unused variable warnings
2021-04-06 18:29:59 +02:00
4855f371f1
Refactor accessibilty speak priority code - create LUT for
...
character/string pairs
2021-04-06 18:21:22 +02:00
76f000e4c8
Don't pass p_rarch around to other functions everywhere
2021-04-06 17:49:45 +02:00
2aea7a375d
Input - turbocode - button ID is always below the threshold of
...
RARCH_FIRST_META_KEY, so put it inside the conditional
2021-04-06 15:59:44 +02:00
5cf2a7abd1
input_state_device - don't keep grabbing these pointers over and over
2021-04-06 14:42:30 +02:00
d11c7cbbb1
Revert "Simplify input_state_device:"
...
This reverts commit 0b9bc85ddd
2021-04-06 14:25:58 +02:00
5c6cd1b48a
Add scaling to pointer input ( #12213 )
...
So far, if display is scaled, overlays gets correctly drawn but touch
input is not correctly scaled, resulting in an unusable overlay.
This happens for touches in menu too.
This commit aims to introduce this scaling factor adding it to the
config file, eg:
input_touch_scale = "2"
2021-04-06 13:15:43 +02:00
9910dfbee2
Replace strcpy_literal usage of trivial string setting
2021-04-06 11:21:28 +02:00
e2b084b715
Cleanups
2021-04-05 23:54:52 +02:00
5f9197bcc2
Get rid of more manual pointer grabbing
2021-04-05 23:37:42 +02:00
0b9bc85ddd
Simplify input_state_device:
...
* run it within a loop internally for button_mask enabled
* only one function call invocation in codebase
2021-04-05 22:54:13 +02:00
66ad300515
input_state_device - don't have remap_binds_enable ifdefs here
2021-04-05 22:32:06 +02:00
4ce66f0764
Cleanup command_event_init_controllers
2021-04-05 22:26:41 +02:00
48af4fc704
Simplify find_driver functions
2021-04-05 21:06:17 +02:00
8c08b531d6
Simplify hw_render_context_name
2021-04-05 20:13:24 +02:00
b830b33cf1
Rewrite commands and add new command type ( #12233 )
...
* (OSX non-Metal build) Set disable execute page protection
* Rewrite commands and add new command type
This moves commands to a separate file and creates a consistent
interface for them. It is now possible to use multiple command
interfaces simultaneously (stdin, network and UDS).
Implemented a new interface for Lakka, UDS based (so Linux only). This
allow other Lakka servies to send certain commands to Retroarch in a
secure and reliable way.
Co-authored-by: twinaphex <libretro@gmail.com>
2021-04-05 19:55:59 +02:00
af00dca08b
Get rid of some pointer grabbing for disp_get_ptr by making it
...
a part of video_frame_info
2021-04-05 14:55:28 +02:00
aaf7e1fb0d
Block accidental diagonals in menu navigation
2021-04-04 15:44:19 +03:00
371d0b7395
Add optional menu screensaver
2021-04-01 17:26:43 +01:00
32bdb49496
Ensure that 'retro_set_controller_port_device' is called when updating 'Max Users'
2021-03-29 15:32:29 +01:00
23d558564f
Customizable menu scroll hold delay
2021-03-26 04:23:52 +02:00
c26741de70
Rename local variables
2021-03-25 22:48:00 +01:00
cd9d6c0511
gfx_display - Get rid of lots of pointer grabbing
2021-03-25 20:12:34 +01:00
0a08437e0a
Add OpenDingux Beta support
2021-03-25 16:19:42 +00:00
0674de54ee
(gfx_widgets.c) Get rid of more pointer grabbing to
...
config_get_ptr/dispwidgets_get_ptr/etc
2021-03-25 15:05:09 +01:00
7505790f32
Cut down on MIDI driver logspam when MIDI just points to null driver
2021-03-25 03:33:42 +01:00
be3960e2be
(gfx widgets) Add widgets_userdata to video_frame_info
2021-03-24 19:16:46 +01:00
d9fa5585a0
Silence static code analysis warings pointed out by cppcheck
2021-03-24 02:23:58 +01:00
8f79e14d0a
Silence LGTM static code analysis warnings
2021-03-24 00:25:47 +01:00
0d06927105
Use ARRAY_SIZE where applicable
2021-03-23 17:14:41 +01:00
fdc184c60c
input_config_parse_key - unroll
2021-03-23 01:10:14 +01:00
49dc7e6c66
* Fix some DISABLE_MENU issues
...
* Optimizations to read_keybinds_conf / set_autoconfig_binds -
first fill_pathname_join_delim call always produced the same output and
this was called four times in a row in one loop, hose out of the
caller functions and move it into the loop and call it once
2021-03-23 01:05:01 +01:00
437a49780c
Add another HAVE_MENU ifdef
2021-03-22 22:12:58 +01:00
fb9d8bad74
Fix DISABLE_MENU
2021-03-22 22:03:16 +01:00
4ff2d85a18
Unsafe to leave input_driver_mapper on heap; plus no real need to
...
have it on heap when it's already on heap courtesy of rarch_state
2021-03-22 21:43:31 +01:00
882fc9bc2c
Simplify config_read_keybinds/save_keybinds
2021-03-22 00:24:00 +01:00
a204bcbf81
Simplify input_config_get_prefix
2021-03-21 23:26:06 +01:00
e5ca68a518
Simplify video_driver_get_ptr
2021-03-21 17:33:44 +01:00
26ea20905a
(retroarch.c) Get rid of two config_get_ptr calls
2021-03-21 17:18:37 +01:00
8b2eb8ed37
Cut down on config_get_ptr calls in menu_displaylist_ctl
2021-03-21 16:36:36 +01:00
a83af11754
remove unused variable
2021-03-20 17:47:44 +01:00
94ae0460cc
Cut down on calls to gfx_display_get_fb_size
2021-03-20 16:52:53 +01:00
f1330f3c98
(video_thread_wrapper) Call video_driver_get_data instead of
...
video_driver_get_ptr - last parameter passed to video_driver_get_ptr
was hardcoded
2021-03-20 15:15:52 +01:00
76c4f12089
Cleanup some VIDEO_DRIVER_GET_PTR_INTERNAL calls
2021-03-20 15:15:52 +01:00
9fd88744ff
Get rid of menu_input_reset
2021-03-20 15:15:52 +01:00
78fcdc1a46
Cleanups - don't go through some small wrapper functions
2021-03-20 13:51:56 +01:00
37a4dfb9db
Don't call some one-line wrapper functions
2021-03-20 13:46:57 +01:00
b51bb2bc66
Simplify parse_hat function
2021-03-20 13:24:10 +01:00
83a1e9170d
Simplify retroarch_load_shader_preset
2021-03-19 12:31:13 +01:00
5ac7a524a2
Further refinement to vrr_runloop_enable checks surrounding
...
audio_driver_monitor_adjust_system_rates
2021-03-19 10:28:11 +01:00
4806a34920
Cleanups in adjust_system_rates functions
2021-03-18 20:38:26 +01:00
5554e5a842
Small cleanups
2021-03-18 12:51:17 +01:00
4ff2011e02
Duplicate key event blocking additions
2021-03-17 21:22:46 +02:00
e62aabea95
Merge pull request #12157 from Jamiras/task_http_cleanup
...
have http tasks clean up after themselves
2021-03-16 09:06:58 +01:00
501fe45a9f
have http tasks clean up after themselves
2021-03-15 19:42:25 -06:00
b52577aac1
Cleanups
2021-03-15 06:52:16 +01:00
6687920c1d
Get rid of some typedefs
2021-03-15 06:37:21 +01:00
a4836bbb17
Fix analog triggers ( #12151 )
...
* Restore RETRO_DEVICE_ANALOG code while making less changes
* * When input_remap_binds_enable is true, input_driver_mapper is always
allocated and initialized - no need to NULL check
* Get rid of input_remote local variable for network gamepad code
2021-03-15 01:32:56 +01:00
e3b856dcf2
Avoid two consecutive for loops if block_libretro_input is not
...
enabled
2021-03-14 06:22:07 +01:00
e1b19d2133
Cleanups
2021-03-14 06:15:38 +01:00
bb5c168726
Revert "Create specialized versions of input_state_mask"
...
- will require more work to properly optimize
This reverts commit bca73b0a46
2021-03-14 06:06:28 +01:00
bca73b0a46
Create specialized versions of input_state_mask
2021-03-14 05:47:30 +01:00
4fc1774901
Cleanups
2021-03-14 05:29:40 +01:00
dbe620db60
Cleanups
2021-03-14 02:11:36 +01:00
4946d75c3d
Further cleanups to do with menu_dialog code
2021-03-12 11:03:57 +01:00
53b4fe7716
This ifdef is no longer needed, remove - also 'push'
...
was always true so just hardcode it for this function
2021-03-12 10:57:42 +01:00
de67a13ab9
Merge pull request #12134 from yoshisuga/macos_support_assets_bundle_extraction
...
[macOS] Support bundle assets extraction for macOS; Fix default paths
2021-03-12 10:27:22 +01:00
a142f3b852
Support bundle assets extraction for macOS; Fix to only extract assets once on first install; Change cores, assets, other directories to default to application support directory instead of app bundle
2021-03-11 23:12:52 -10:00
4d3f8c3c80
Cleanup
2021-03-12 01:56:59 +01:00
f7f6f3c5d5
Revert "Cleanups - don't call MENU_ENTRIES_CTL_SET_REFRESH in a loop - set it"
...
This reverts commit ee06ddfbc0
2021-03-11 22:32:28 +01:00
ee06ddfbc0
Cleanups - don't call MENU_ENTRIES_CTL_SET_REFRESH in a loop - set it
...
once outside
2021-03-11 22:17:38 +01:00
14248f7401
(Menu) Iterate function callback was never used, remove it
...
- Also turn menu_driver_iterate into static function and
redesign code a bit; non-functional
2021-03-11 20:17:22 +01:00
4d93ac3870
Get rid of menu_setting_ctl
2021-03-11 08:38:53 +01:00
ba7771fd28
MENU_NAVIGATION_CTL_{INCREMENT/DECREMENT/ASCEND_ALPHABET/DESCEND_ALPHABET'
...
can all be removed now and inlined
2021-03-11 06:23:29 +01:00
6a68cefe60
Cleanups
2021-03-11 05:25:37 +01:00
3c7419bac7
(Menu) Can now get rid of TODO/FIXME
2021-03-11 05:17:32 +01:00
b9d28ea76d
Cleanups
2021-03-11 05:14:07 +01:00
656e10c60c
Replace /inline file_list_get_last calls in retroarch.c
2021-03-11 05:11:08 +01:00
1afd728057
Cleanups
2021-03-11 04:28:39 +01:00
95d3b7285d
MOve functions over to retroarch.c
2021-03-11 04:13:06 +01:00
e5045fa2e2
Simplify menu_driver_deferred_push_content_list
2021-03-11 03:49:51 +01:00
839a270a97
Menu refactors:
...
- Get rid of menu_driver_search_list_clear
- Get rid of contentlist_switch callback - was only ever one
function callback implementation
2021-03-11 03:37:19 +01:00
f502cd9e16
Get rid of menu_cbs_down/menu_cbs_up
2021-03-11 03:14:31 +01:00
9f3ea51f77
Refactors pt4 ( #12126 )
...
* Cleanups:
- menu_driver_set_id - don't pass p_rarch to function
- Ozone: call ozone_list_cache directly instead of going through
wrapper function in retroarch.c that then calls ozone_list_cache
- Some other cleanups, non-functional
* (Menu) Replace calls to menu_driver_list_cache inside retroarch.c
2021-03-11 02:58:35 +01:00
a2ed065f25
Refactors pt3 ( #12124 )
...
* Remove video_pixel_get_alignment - move it to video
drivers that use it
* Rewrite video_driver_pixel_converter_{init/free} - get rid of
p_rarch dependency
* Replace some variables
* (Menu) Get rid of cbs_refresh - was never set to any other
function callback implementation
2021-03-11 02:03:37 +01:00
cb5fba6b2a
* Fix libnx build
...
* Put menu_cbs/enum_idx in menu_cbs_init behind DEBUG_LOG
2021-03-10 18:00:51 +01:00
29c509162e
Cleanups - menu_entries_get_last_stack - unroll when possible in
...
retroarch.c
2021-03-10 17:28:31 +01:00
a092fe273c
Turn retroarch_apply_shader into static function
2021-03-10 17:05:19 +01:00
4516d6626b
* Cleanups; non-functional changes -
...
- Don't pass p_rarch around to other functions if unnecessary
- Get rid of superfluous get/set runtime shader preset functions
2021-03-10 16:57:31 +01:00
a2031608e7
Don't use file_list_get_at_offset - access members directly
2021-03-10 09:41:49 +01:00
6629c20e25
video_driver_set_viewport_config - don't pass p_rarch to it
2021-03-10 05:49:59 +01:00
b53b6cbf34
Simplify menu_input_set_pointer_visibility
2021-03-10 05:49:58 +01:00
003fc7ccc8
Get rid of menu_entries_get_at_offset
2021-03-10 05:49:58 +01:00
88b2359a37
Cleanups
2021-03-09 00:51:15 +01:00
c645a9b8bb
Rewrite osk_last_update_codepoint
2021-03-08 23:28:24 +01:00
682a09fbdb
Reimplement input_joypad_analog_axis
2021-03-08 23:02:46 +01:00
d98f81359f
Small cleanup to input_keyboard_event
2021-03-08 22:09:36 +01:00
fa539c9563
runloop_key_event can be NULL - check first if non-NULL before
...
calling it
2021-03-08 21:11:04 +01:00
012b02635e
Get rid of p_rarch for more function arguments
2021-03-08 19:52:08 +01:00
af5c311fb0
Simplify code in input_keyboard_event
2021-03-08 19:45:27 +01:00
7b2256941e
(Input) Redesign some code for input_driver_mapper - if input_remap_binds_enable
...
is true, assume input_driver_mapper is allocated, to avoid having to do
the conditional checks beforehand
2021-03-08 19:23:37 +01:00
e135df2983
Simplify input_state_device - two case statements were identical
...
to an already existing one
2021-03-08 07:42:11 +01:00
d350ee0256
Remove unused variables
2021-03-08 00:31:36 +01:00
0518f6e13e
Create MENU_ENTRIES_NEEDS_REFRESH
2021-03-07 20:00:45 +01:00
db314cf5df
file_list_set_userdata / file_list_set_actiondata are trivial one-line
...
functions - just set it directly
2021-03-07 19:30:04 +01:00
0c1e63a3c1
input_overlay_poll - add fallthrough
...
menu_display_powerstate - cleanup
2021-03-07 19:16:54 +01:00
0cce2fb4e2
menu_entries_append_enum - get rid of menu_driver_ident call
2021-03-07 19:04:24 +01:00
e7702ae20f
Simplify pause button handling in runloop_check_state
2021-03-07 18:38:33 +01:00
681c5f0b2b
Only call rcheevos_hardcore_active once in runloop_check_state
2021-03-07 18:31:53 +01:00
8328043897
Don't have two consecutive rcheevos_hardcore_active boolean
...
conditionals - have only one instead
2021-03-07 17:59:01 +01:00
69bae76ec3
Buildfix for MSVC
2021-03-07 16:08:49 +01:00
a657465a4a
Don't call netplay_get_host_room/don't call state_manager_is_reversed
...
inside retroarch.c
2021-03-07 07:28:13 +01:00
58f54a757f
Move global pointer getters to the top
2021-03-07 07:16:40 +01:00
348b353907
Don't use menu_navigation_set_selection inside retroarch.c
2021-03-07 07:09:37 +01:00
d6e897ca2c
Get rid of menu_entries_set_checked
2021-03-07 06:52:35 +01:00
b65d4e483e
Avoid calls to menu_entries_get_menu_stack_ptr and
...
menu_entries_get_selection_buf
2021-03-07 06:26:51 +01:00
7b6a01056e
Optimizations to menu refresh/clear functions -
...
* don't use menu_entries_get_size but used optimized
getter
2021-03-07 06:07:45 +01:00
fa2b2708e5
Optimize MENU_ENTRIES_CTL_REFRESH
2021-03-07 06:00:35 +01:00
2bc23c9eaa
Found quirk in code - add TODO/FIXME note
2021-03-07 05:49:12 +01:00
ef650b2b48
Simplify menu_entries_elem_get_first_char - list is always non-NULL
...
so no need to check this
2021-03-07 05:25:34 +01:00
ae378b8b80
Simplify further
2021-03-07 04:59:21 +01:00
3442f57bc7
menu_shader_manager_set_preset - ret is already set to false
...
by default, no need to set it again
2021-03-07 04:57:55 +01:00
0b863d6bc7
Forget 'void' for function prototype - needed for C
2021-03-07 04:48:30 +01:00
09bf486618
More cleanups
2021-03-07 04:40:12 +01:00
b45eb0c76d
Cleanups
2021-03-07 04:28:33 +01:00
2c7d5ad944
Get rid of p_rarch being passed as argument to functions whenever
...
possible
2021-03-07 04:15:17 +01:00
48926799cb
Don't pass p_rarch around as argument unless we have to
2021-03-07 03:35:04 +01:00
5b3e3187c4
Don't pass p_rarch around to other functions if unnecessary
2021-03-07 03:12:55 +01:00
twinaphex