Commit Graph

21366 Commits

Author SHA1 Message Date
Morilli f59cfb1710 set current branch properly in TAStudio movie load
apparently, GoToFrame might frameadvance, which in turn calls UpdateAfter(), which in turns updates the current selected branch in the TasSession with the value of the current movie.
So, we need to set the current movie's current branch from the session's value before it gets deleted.

- closes #3968
2024-07-17 22:46:00 +02:00
feos e214b7dc33 fix script 2024-07-16 20:29:29 +03:00
YoshiRulz 9a5a75e5bb
Add some helpers to `BitmapBuffer` 2024-07-16 08:08:41 +10:00
YoshiRulz d7e9668d50
Add and use `Span`-from-`IntPtr` helper 2024-07-16 07:30:09 +10:00
YoshiRulz f742fe55d5
Refactor `ToolManager.Close`
that ought to cover everything
2024-07-16 04:09:01 +10:00
YoshiRulz f9cdad2ea6
Move system-specific helpers in `MainForm` to separate file 2024-07-14 05:40:25 +10:00
YoshiRulz e49c4689de
Minor refactors to system-specific helpers in `MainForm` 2024-07-14 05:34:42 +10:00
YoshiRulz b2184e46d5
Clean up some `DropDownOpened` handlers for disk switch submenus 2024-07-14 05:31:04 +10:00
YoshiRulz 65979e61ec
Reduce indentation in system-specific helpers in `MainForm` 2024-07-14 05:25:36 +10:00
YoshiRulz 2321bc55e6
Add `LoadedCoreIsNesHawkInVSMode` helper prop in `MainForm` 2024-07-14 05:10:23 +10:00
YoshiRulz f21c8b914c
Refactor `MainForm.EnsureCoreIsAccurate` 2024-07-13 01:21:45 +10:00
YoshiRulz c09f195148
Fix bug in `HawkSourceAnalyzer` 2024-07-12 23:27:29 +10:00
YoshiRulz 1fdacd762a
Refactor `yield`ing methods to conventional LINQ 2024-07-12 14:42:11 +10:00
YoshiRulz dfe8b1308c
Refactor `yield`ing methods to direct, stateless returns 2024-07-12 14:42:10 +10:00
YoshiRulz 166f1d537e
Comment-out unused `DiskBuilder.BamEntry.Entries` (C64Hawk) 2024-07-12 14:42:10 +10:00
YoshiRulz fc8fd64143
Simplify `DiskBuilder.BamEntry.GetBytes` (C64Hawk) implementation 2024-07-12 14:42:10 +10:00
YoshiRulz 18bc51f5e7
Simplify `IDisassemblable.AvailableCpus` implementations 2024-07-12 14:42:10 +10:00
YoshiRulz da06dae80c
Decrease indentation in `InputRoll.GenerateContextMenuItems` 2024-07-12 14:42:10 +10:00
Morilli c5820f0c0f TAStudio: don't select branch when none exists
-closes #3967
2024-07-12 06:03:14 +02:00
YoshiRulz 616437ff31
Restore exception message in `SavestateFile.Create`
partially reverts e9d6716a3
2024-07-12 08:09:59 +10:00
YoshiRulz ee0c0a80d0
Bump supported Win10 version 2024-07-12 01:51:28 +10:00
feos a5e7288a71 add batman-robin lua 2024-07-11 17:48:33 +03:00
Morilli e9d6716a33 Fix savestating being possible after movie has finished 2024-07-10 21:03:59 +02:00
CasualPokePlayer 662fd83f5e Prevent user changing clock stopping message pumping
TODO: Audit other usages of DateTime.Now assuming it is monotonic (also use DateTime.UtcNow where applicable to avoid DST causing issues)
2024-07-10 01:51:28 -07:00
YoshiRulz e44810a725
Fix stacktraces for `RangeToExclusive` extension 2024-07-10 13:30:35 +10:00
YoshiRulz 00c103da0b
Remove unused import 2024-07-10 13:20:55 +10:00
CasualPokePlayer d8431d615e Avoid zealously copying the entire video buffer
this might be larger than bufferwidth*bufferheight, and thus possibly dramantically decrease screenshot/dumping performance
2024-07-08 16:29:51 -07:00
Morilli 57e3c47bcc Fix InputRoll not updating CellHeight and CellWidth on padding change 2024-07-08 19:21:35 +02:00
YoshiRulz 5fd840e145
Add Analyzer (currently disabled) for target-typed `new` with `throw` 2024-07-09 00:12:46 +10:00
YoshiRulz 53fcb93d0e
Nix expr: Regen NuGet lockfile
fixes c6101a190
2024-07-09 00:12:27 +10:00
YoshiRulz 0d2844d1fd
Improve docs on `Config.CorePickerUIData`
fixes 14cf4b348, 81e2b5b47, and bbb3b4cd7
2024-07-08 23:57:58 +10:00
Morilli bbb3b4cd7d Update comment on CorePickerUIData
also restore systemid default core restore logic that exists for some reason
2024-07-08 06:26:57 +02:00
Chris Siebert 45002e6870
Fix NesHawk tracelogs sometimes using 32-bit addrs (squashed PR #3964)
specifically, only for the few instructions in this diff, and only when the PC would over- or underflow as a result of the offset
2024-07-08 11:26:34 +10:00
Morilli 81e2b5b47b Make preferred core labels more verbose
they now display all system choices that they set instead of just the first
2024-07-08 03:03:34 +02:00
Morilli d74b130c22 Add preferred core picker choice for Satellaview
idk if this list is supposed to be sorted because it kinda isn't?
2024-07-08 03:00:47 +02:00
YoshiRulz 5d24d1a260
Replace `^= true` in Virtu
fixes 2a5d4b903
2024-07-08 10:46:24 +10:00
YoshiRulz 2a5d4b903c
Add Analyzer to disallow `^= true` 2024-07-08 10:39:06 +10:00
YoshiRulz c99d2212b2
Dedup `MainForm.CheckHotkey` with existing helpers / event handlers 2024-07-08 09:27:21 +10:00
YoshiRulz d515b1bdad
Document bare minimum of CLI flag parsing behaviour 2024-07-08 04:05:12 +10:00
YoshiRulz 5e5f5772c6
Enable Analyzer rules re: blank doc comments and fix noncompliance 2024-07-08 01:37:22 +10:00
YoshiRulz 9a82dfd05f
Enable SA1517 and fix noncompliance (except in Cores)
"Code should not contain blank lines at start of file"
2024-07-08 01:17:05 +10:00
YoshiRulz 39b69641a6
Enable SA1506 and fix noncompliance
"Element documentation header should be preceded by blank line"
also fixes typo in rule config from c93a0f9d1
2024-07-08 01:13:06 +10:00
YoshiRulz e61790d3dd
Actually commit the part where I disable the new Analyzer rule
fixes 2ffb897b1
-_-
2024-07-07 15:37:13 +10:00
YoshiRulz 2ffb897b11
Add analyzer (currently disabled) to enforce a newline policy for `=>` 2024-07-07 15:32:31 +10:00
YoshiRulz 479f151bbb
Fix code style warnings in satellite .NET projects 2024-07-07 12:54:11 +10:00
YoshiRulz c93a0f9d1b
Enable SA1514 and fix noncompliance (except in Cores)
"Element documentation header should be preceded by blank line"
2024-07-07 12:12:08 +10:00
feos ee9639a6fc video dumper: mention dependency for AVC AVI 2024-07-06 19:05:33 +03:00
Morilli 4c39a81228 Remove unnecessary duplicated actions in TAStudio
this should not change any behavior.
2024-07-06 17:39:52 +02:00
Morilli d161215754 Don't control reboot in TAStudio
There seems to be no good reason for why this would be necessary. TAStudio behaves just fine when the MainForm reboots itself.
2024-07-06 01:56:13 +02:00
Morilli 74970cc576 Remove unnecessary Thread.Sleep(0)
In this same loop we are already sleeping when necessary, so this Thread.Sleep(0) could only add unwanted delay
2024-07-05 19:21:42 +02:00