Commit Graph

18448 Commits

Author SHA1 Message Date
nattthebear f284fda3a6 Object.Equals(object) overrides should not throw
Especially not if you pass null.  null is simply not equal to this, that's all.  The post condition is satisfiable; you can return false.
2021-01-01 17:06:59 -05:00
YoshiRulz 51b62629c6
Enable nullability in most of the remaining files in BizHawk.Common 2021-01-02 02:39:13 +10:00
SuuperW 021d8e6e92 Fix: LuaSandbox wasn't reverting current directory after sandboxed operations. Appears to be a regression from commit 5e89e56. 2021-01-01 06:34:05 -06:00
alyosha-tas 89c69c382c GBHawk: implement LCDC write glitch for gbc-acid-hell 2020-12-30 19:31:30 -05:00
YoshiRulz 90c0214d5e
Add prop IMemoryApi.MainMemoryName, further delegate mainmemory lib 2020-12-30 16:02:05 +10:00
YoshiRulz 1619b33e8e
Fix overlapping/duplicate controls in FirmwaresConfig's menu on Mono 2020-12-30 01:25:30 +10:00
YoshiRulz a80dbfa76b
Fix crash when clicking on column headers in FirmwaresConfig on Mono 2020-12-30 00:07:47 +10:00
YoshiRulz d0edf350f2
Finish my nullability pass over ControlExtensions.cs 2020-12-30 00:03:39 +10:00
YoshiRulz 2de32ed59a
Move more sound classes to Client.Common 2020-12-29 17:04:02 +10:00
YoshiRulz 9cfe9485ef
Fix covariant arrays (passing ASupertype[] where AType[] is expected) 2020-12-29 16:53:31 +10:00
YoshiRulz 206a3e30c8
Cleanup instantiation of FirmwaresManager and PathConfig
and remove unused MainForm interface prop
2020-12-29 16:26:01 +10:00
YoshiRulz 18ebfecc97
Move GuiApi (impl.) to Client.Common 2020-12-29 15:53:47 +10:00
YoshiRulz 7edf3b36ad
Extract a tiny interface from DisplayManager for ApiHawk 2020-12-29 15:52:57 +10:00
YoshiRulz 0704db5940
Move OSDManager to Client.Common and move types to own files 2020-12-29 15:40:13 +10:00
YoshiRulz 23a8387dc1
Replace IBlitterFont w/ the type wrapped by its sole inheritor 2020-12-29 15:36:37 +10:00
YoshiRulz 47670714b5
Remove WinForms dep from GuiApi (impl.) 2020-12-29 15:08:01 +10:00
YoshiRulz 8e67d82bd5
Rename file to match type name 2020-12-29 15:00:55 +10:00
YoshiRulz f431faf65c
Move some DiscoHawk logic to Emulation.DiscSystem 2020-12-29 15:00:25 +10:00
YoshiRulz 1a21765be6
Fix assembly resolution in DiscoHawk on Mono
without this the program wouldn't open at all, I assume all of its actual
functions will just workTM now
2020-12-29 01:33:57 +10:00
YoshiRulz a0c7e9c7fb
Fix non-string resource in DiscoHawk 2020-12-29 01:26:56 +10:00
YoshiRulz c0cf40b68e
Check for MAME's lib before instantiating the MAME core (fixes #2538) 2020-12-29 01:04:36 +10:00
nattthebear f4e98fd9bd
Refactor ZWinderBuffer to allow use of arbitrary backing Streams (#2536) 2020-12-27 18:36:42 -05:00
YoshiRulz bcf5347823
Use C# 9 improvements to switch / "pattern matching" 2020-12-28 00:07:06 +10:00
YoshiRulz 96f9e8f6e4
Encapsulate MessageBox.Show using IDialogController and some helpers
a lot of the calls to `DialogController.ShowMessageBox` from `ToolFormBase`
inheritors could be replaced with `this.ModalMessageBox` (i.e. add self as
parent window)
2020-12-28 00:03:00 +10:00
YoshiRulz 9cafddb1e0
Minor cleanup to improve readability 2020-12-28 00:00:39 +10:00
YoshiRulz ce0ccd0cfa
Remove wget binary from assets
fixes a1253407e
2020-12-26 12:44:47 +10:00
SuuperW a928d1887f fix: Attempted to evict state 0, and attempted to modify collection while enumerating 2020-12-25 09:59:32 -06:00
YoshiRulz a1253407e7
Remove gamedb/update_gamedb.bat from assets (fixes #2529)
pulling the gamedb from master into an old version is a bad idea
2020-12-26 00:52:23 +10:00
YoshiRulz 62f90f11f2
Make anything inheriting FormBase slightly less ugly on Linux 2020-12-26 00:44:21 +10:00
alyosha-tas 515f5cf9b0 GBHawk: update RAM state for GBA mode 2020-12-24 19:45:44 -05:00
YoshiRulz 42fc895e12
Update EmuHawk project file
these files were removed in b9b1e2d23
2020-12-23 16:46:03 +10:00
YoshiRulz b9b1e2d237
Move Quantize to new external project, update upstream info 2020-12-23 16:37:47 +10:00
YoshiRulz faba9035b7
Update attribution of ported code 2020-12-23 15:55:50 +10:00
alyosha-tas 28c35a6274 GBHawk:set initial HRAM to 0, this provides consistent sync when clearing RAM on console, where as 0xFF does not 2020-12-22 20:20:00 -05:00
YoshiRulz 60d2bfa85c
Bump C# language level for ReSharper/Rider 2020-12-22 20:07:35 +10:00
YoshiRulz b9c9144358
Fix new dep not being copied to output, causing crashes
fixes 1e37350e9
I already fixed this before pushing but forgot to stage it
2020-12-22 19:57:55 +10:00
YoshiRulz 1e37350e99
Use NuGet package instead of copy-pasted code in BizwareGL/Borrowed
Our copy was equivalent to version 1.0.0 + a patch which allowed Stream instead
of requiring a filename, so I've used 1.0.2 as it has the author's
implementation of the same feature.
There are more recent versions available (note, 1.0.2 isn't for .NET Core).
NuGet: https://www.nuget.org/packages/Cyotek.Drawing.BitmapFont
Project repo: https://github.com/cyotek/Cyotek.Drawing.BitmapFont
2020-12-22 19:48:50 +10:00
YoshiRulz a5fd5f5d78
Return the tool from IToolApi.GetTool instead of its type
also affects Lua client.gettool; this has been broken for quite a while
2020-12-22 18:47:32 +10:00
YoshiRulz 5a098055d7
Fix Lua client.createinstance calling the wrong ApiHawk method
fixes e6cb74d31
2020-12-22 18:46:42 +10:00
YoshiRulz 03b4ae18e0
Move Virtual Pads schemata to Cores 2020-12-22 18:37:27 +10:00
YoshiRulz 790a09067e
Cleanup LINQ in VirtualpadTool.CreatePads 2020-12-22 18:34:27 +10:00
YoshiRulz 9124b0f3b5
Pass MessageBox.Show to Virtual Pads schemata as callback 2020-12-22 18:18:40 +10:00
YoshiRulz 0ff60220f7
Use enum to represent button images in Virtual Pads schemata 2020-12-22 15:35:26 +10:00
YoshiRulz 50b17096e1
Remove WinForms dep from Virtual Pads schemata 2020-12-22 14:07:28 +10:00
YoshiRulz 9168b59382
Add base interface for *CheckBoxEx and *RadioButtonEx controls 2020-12-21 16:58:49 +10:00
nattthebear 56b158e72a minor comment clarification 2020-12-20 21:06:22 -05:00
SuuperW b5b1e17851 Fix eviction logic for _gapFiller. (we were attempting to remove the wrong value from StateCache, and also weren't checking for reserved) 2020-12-20 18:06:50 -06:00
SuuperW 01bcf22802 Deal with this TODO. Removing from the StateCache here was removing extra frames. (frames between the old last gap frame and new last gap frame which were in another buffer) 2020-12-20 18:04:02 -06:00
nattthebear 55c08dc77f Revert "misc cleanups in neshawk boards, mostly removing redundant else's"
This reverts commit 2b5d0b6219.

A lot of these make things harder to read:

- Extra empty lines in large switch stacks mean they're more likely to go off one screen
- `if` and its condition on the same line is super hard to read, please never do that.  (Are the extra empty lines an attempt to mitigate the above)
- Removing terenaries obscures intent, and now there's more copy paste than before
- """Redundant""" else clauses on if...return kept things nice and lined up.

That was a huge churning diff with no value; let's stop it from spreading.
2020-12-20 15:26:08 -05:00
SuuperW 3d84812341
add a Lua method to get inputs from the movie (#2526) 2020-12-20 13:16:28 -06:00