Commit Graph

22223 Commits

Author SHA1 Message Date
Morilli 5d6b35e2c9 fix single usage of GetValueOrDefault(IDictionary) 2025-02-14 18:50:34 +01:00
Morilli f12f90366b Revert "Add more `GetValueOrDefault` overloads"
This reverts commit 34d71e90bc.

This was hardly used and caused trouble in .net 8 with the way it was defined.
2025-02-14 18:50:10 +01:00
Morilli 426c743da9 fix SpanSplit for .net8
removed the NETCOREAPP3_0 code because it didn't even compile; lots of internals missing and we probably wouldn't need the 1% speedup anyway (the function using it is unused currently too)
2025-02-14 18:28:42 +01:00
Morilli 24641433e4 improve estimated time display in RewindConfig
now takes the estimated rewind interval into account to display the actual estimated rewind range, which is what people care about
2025-02-14 15:13:32 +01:00
Morilli 84c79b9053 fix some edge case display values in RewindConfig
specifically when rewind is disabled or if it's enabled and no state exists.
2025-02-14 14:41:20 +01:00
Morilli 8bc446bfa3 rename target frame length option for more clarity
- closes #3309
2025-02-14 14:32:15 +01:00
Morilli 89ea856ba4 implement command field in DsmImport
see #3555
2025-02-14 13:18:17 +01:00
Morilli 582a25b851 handle missing return gracefully in tastudio.onqueryitem* functions
- closes #4219
2025-02-14 08:22:40 +01:00
Morilli 95cbbecb97 harden TasView_QueryItemText exception handling
by immediately throwing out the current movie. This should prevent this message box from coming up repeatedly, not providing any additional useful information and just blocking all other windows.

should resolve #2332
2025-02-13 16:49:16 +01:00
YoshiRulz 7568a29912
Fix implementation of `NumberExtensions.Log10` and add docs
fixes fbd45915c
2025-02-13 22:19:49 +10:00
YoshiRulz cf70cc9ef4
Add unit tests for `NumberExtensions.Log10` 2025-02-13 22:15:38 +10:00
Morilli d9d1bfd1e8 remove unused using 2025-02-13 04:18:27 +01:00
Morilli 26115624e4 make circular analog range setting work in ares 2025-02-13 04:07:35 +01:00
YoshiRulz 69a938f29b
Pad frame indices in TAStudio to 5 digits from the start 2025-02-13 08:41:01 +10:00
YoshiRulz fbd45915cb
Add `Log10(int)` helper 2025-02-13 08:39:16 +10:00
YoshiRulz 6049d5e4f5
Show placeholder for VSystem menu when no rom loaded 2025-02-13 00:41:02 +10:00
YoshiRulz f92565549c
When the only option for a FW record has a dummy hash, mark it unknown
fixes c4ff97111, 296145ba2
2025-02-12 08:55:34 +10:00
YoshiRulz 3771601916
Update security policy, prioritising reporting through GitHub
forgot to include this in readme updates
2025-02-12 08:38:21 +10:00
YoshiRulz b66672f97f
Add missing import
fixes 724a7393e
obviously didn't mean to add and then immediately remove this, it got
lost in a rebase
2025-02-11 21:17:37 +10:00
YoshiRulz 724a7393e2
Alphabetise lists of core names in source
fixes 18078c876
and some others, maybe as far back as the commits introducing the lists,
I haven't checked
also I left a marker so it's easier to find these later
2025-02-11 21:12:09 +10:00
YoshiRulz f5dc73086a
Allow Stella's settings to be edited without the core loaded 2025-02-11 21:11:00 +10:00
YoshiRulz 59d875aecc
Clean up `LibUAE.ControllerType`
see #4110
2025-02-11 20:37:54 +10:00
YoshiRulz 6a115e4e65
Add `Edit` > `Go to Frame...` to TAStudio (resolves #2373) 2025-02-11 01:24:30 +10:00
YoshiRulz 59be77248a
Remove pointless indirection from `BookmarksBranchesBox` events 2025-02-10 09:21:04 +10:00
Morilli b33d7f5ce4 simplify RemoveFrames 2025-02-09 08:17:45 +01:00
Morilli 30c67cd297 fix incorrect logic in RemoveFrames 2025-02-09 07:45:38 +01:00
Morilli b0c1be30c9 make OSD text scaling configurable 2025-02-09 07:12:20 +01:00
Moritz Bender ef3b92dab4
Add more courier font sizes instead of upscaling the 16px one (#4210)
* add more courier font sizes instead of upscaling the 16px one

* use 25px font instead of 26px

* remove now-unused property
2025-02-09 07:03:43 +01:00
YoshiRulz f3c4425bf1
Nix expr: Regen NuGet lockfile
fixes 8332a6bd5
2025-02-09 02:05:55 +10:00
feos c5807662b6 uae: a game requiring empty input port found
see #4213
2025-02-08 14:46:21 +03:00
Sergio Martin bd58dd1d95
QuickerNES NES 2.0 header read fix (squashed PR #4211)
* Integrating NES2.0 cart loading fixes

* Adding windows dll

* Update bizinterface.cpp according to Morilli's recommendation
2025-02-08 05:11:33 +10:00
feos 47089a3f02 uae: don;t build debug 2025-02-06 20:17:23 +03:00
feos 74fcbc28eb uae: include more scanlines into image
fixes #4204

RANT TIME

visible area is largely nonsense when it comes to CRT TVs, because they may cover different amounts of the screen based on model, and you can adjust some of them also based on model to show more or less of it.

4:3 aspect ratio is also somewhat nonsense because TVs don't automatically rescale your video input to the entire screen like modern computers do. they just stretch or shrink it based on pixel frequency of the input and how it relates to whatever the given TV is configured to.

Rec601 was created in order to somewhat standardize this but it only contained RECOMMENDATIONS (hence the name) on how to digitize analog video, not how analog devices should be configured. so a lot of TVs looked different from what it would be digitized to based on this spec.

in gaming it's a common misconception that console output is meant to be resized to 4:3 DAR of the TV. in reality it's stretched according to PAR - pixel shape which comes from differences between color frequency of the input and standard NTSC or PAL color frequency.

if the console updates color more often than the standard, analog signal with higher pixel density will be put on the screen as is, and pixel will look "squished", sometimes up to 2x for 512px resolution modes (PS1). if the console updates color rarer, pixels will look stretched (A2600).

Amiga PAL mode has 1:1 PAR, no stretching is needed, so whatever aspect we're outputting will just go to encodes as is. NTSC Amiga PAR is 6:7, so we're shrinking a bit in encodes and when hawk is configured to device aspect.

this all means that it doesn't matter how many pixels we take of the rendered image, all we care about is stretching it to proper PAR. whether it contains overscan only affects fullscreen because extra blank area means less of useful data. and since some exceptional games decide to render AT THE VERY BOTTOM there's little to no harm in showing all 574 rendered scanlines. who hates it and wants 568 can crop it, but I don't expect anyone to care (or even notice).

so while nominal internal res for Amiga is 576 and canonical UAE default is 568 (tho it lets you adjust visible area and we don't), I think we can safely output our heretical number at all times.
2025-02-06 19:43:32 +03:00
CasualPokePlayer 08266f9450 update comment
fixes previous commit
2025-02-05 23:08:24 -08:00
CasualPokePlayer 1f276242ec Fix usage of BizHawk within a folder with a semicolon in it
Semicolons are perfectly valid for path names, but windows disallows dll paths to contain such (presumingly internally using them as path separators like with PATH env var)
A workaround for this is to simply use the "short name path" instead, which does not have a semicolon (but these names aren't guaranteed to exist, and in certain cases if they don't,GetShortPathNameW will just return the long name back, so semicolon still needs to be rechecked)
2025-02-05 22:53:16 -08:00
YoshiRulz f382ec7590
Update testroms project docs to reflect TFM change
fixes 9fb98ef5e
see 66e6aa7eb
2025-02-04 20:54:01 +10:00
YoshiRulz 924b5c7fae
Update `DummyFrontend` for `CoreComm` signature change
fixes ddd14d527
2025-02-04 17:31:01 +10:00
YoshiRulz 756c79fb60
Clean up HelloWorld sample 2025-02-01 14:57:11 +10:00
YoshiRulz de1a7b1e30
Use `SpecialType` where possible in BizHawk.Analyzer 2025-01-31 17:52:49 +10:00
YoshiRulz ae97d1f49d
Remove unused class `CoreInventory.Core.RomGameFake` 2025-01-31 14:51:50 +10:00
YoshiRulz cc0f1417f1
Enable a bunch of Analyzer rules re: `.Count()`/`.Any()` and fix cases 2025-01-31 14:49:41 +10:00
YoshiRulz adcbc8a030
Fix some redundant length checks around `foreach` 2025-01-31 14:49:41 +10:00
YoshiRulz 2874ce14c8
Reduce intendation in a couple methods on `BreakpointControl` 2025-01-31 14:49:41 +10:00
YoshiRulz d56413bfb1
Extract a couple helper props in `HexEditor` and clean up 2025-01-31 14:49:41 +10:00
YoshiRulz 6ec2f0c49f
Enable RCS1156 and fix noncompliance
"Use string.Length instead of comparison with empty string"
inb4 this introduces an NRE somewhere
2025-01-31 14:49:40 +10:00
YoshiRulz af32948756
Add Analyzer to warn about LINQ calls on string receivers 2025-01-31 14:49:40 +10:00
SaxxonPike 0bb940ea7a [C64] Disk: 1541 drive saveram now works properly when rewind is disabled
[C64] Disk: Use raw track capacity values per the G64 file format specification, should fix some disk loaders that are expecting data not to be so sparse (Spindle demos in D64 format particularly)
[C64] Disk: fix 1541 drive address decodes
[C64] VIA: 6522 core facelift, shift register and use of low-order timer latches implemented, should fix some disk loaders ("Sprite B*****e 2" demo plays, yes they called it that, and it's not what it sounds like)
[C64] CIA: fix PB6/PB7 outputs when enabled on CRA/CRB
2025-01-30 12:43:58 +10:00
Tony Konzel 4a48d945c7
[6502] Pass Lorenz C64 tests (squashed PR #4177)
* [6502] Pass Lorenz C64 tests

* [C64] make sure the 1541 drive uses the same 6502 undocumented behavior as the main CPU

* [6502] Use field instead of delegate for ANE/LXA system constants
2025-01-30 12:43:48 +10:00
YoshiRulz 87ffdb5cd2
Fix typo
fixes 12cd7885e
good catch by Morilli
2025-01-30 12:42:43 +10:00
Morilli 504b2d57f2 fix lua autocompletions missing
fixes ea810cb89b
2025-01-29 16:27:06 +01:00