250d3b6c49
simplify CheatList.Sort using OrderBy extension method
2020-03-15 18:32:31 -05:00
18762c75ee
misc cleanups in Client.Common
2020-03-01 15:49:48 -06:00
db21af9e59
cleanups in Client.Common, mostly removing redundant parenthesis
2020-03-01 14:52:16 -06:00
656f2b814e
Move IEmulator extensions to the Emulation.Common namespace, the intent is that these are used and serve as built in functionality, so it's overly tedious to when most situations require both Common and an additional extensions namespace
2020-02-15 12:33:15 -06:00
a8408ed3be
Improve exception docs in BizHawk.Client.Common
2020-01-02 21:51:27 +10:00
ae7221988b
cheats code cleanup
2019-11-02 11:25:11 -05:00
00691b58a2
misc cleanups in Client.Common movie and watch files, mostly typos and C#7isms
2019-10-31 19:25:11 -05:00
db1dc74591
Mostly Fix #1696
2019-10-19 21:28:06 -04:00
90b0574bc3
Remove unnecessary calls to ToList (e.g. in foreach)
...
squashed PR #1591
2019-10-13 15:50:57 +00:00
43cb50d5c3
Misc cleanups in Client.Common
2017-05-19 13:17:07 -05:00
0d4313af91
general Cheat code cleanup
2017-05-18 15:16:02 -05:00
70baf9d306
Client.Common cleanups
2017-05-18 11:36:38 -05:00
dfea029fe4
Misc cleanups in Client.Common, documentation fixes
2017-05-17 11:16:55 -05:00
ebe789eed2
heh
2017-05-10 07:45:23 -04:00
e0985465b6
misc Client.Common code cleanups
2017-05-09 13:19:55 -05:00
b53502eed8
Spaces -> tabs.
2017-04-15 16:37:30 -04:00
fc59710dab
some code cleanup, mostly introducing C#6isms, also add a customized resharper+stylecop settings file in case anyone is using resharper
2017-04-10 10:30:05 -05:00
ef6c9131c6
Fix behavior when loading a new rom when a cheat is loaded, fixes #550
2016-10-06 13:57:39 -05:00
c82f70763e
Fixed bug where having no comparison type would throw exception
2016-02-09 20:33:44 -08:00
5dc31d3eb9
Fixed index bug for comparison type in Load() in CheatList
2016-02-07 21:54:45 -08:00
52c587d712
Save/Load cheats now accounts for comparison type column
2016-02-07 21:40:14 -08:00
992acd9e96
Added code to sort by comparison type. Added code to compare based on comparison type selected
2016-02-07 20:56:40 -08:00
1e2f4e12be
Watch refactoring
...
Some improvement when you get Available types. Used to return a new
array each time you call the function. It has been transformed into an
IEnumrable and yield return.
DisplayType, PreviousType and Watchsize have been moved outside the
Watch Class
2015-11-28 22:52:00 +01:00
5402f1ff9e
dont reorder cheats list when editing cheats
2015-08-04 22:25:58 -05:00
515a41592c
Convert a whole bunch of ram stuff from int to long
2015-01-18 18:59:23 +00:00
fbdb29b64c
refactor IMemorydomains to be a domain list instead of having a domain property, refactor cores to register an IMemoryDomains instead of being one
2015-01-14 21:55:48 +00:00
04f9081943
in IEmulator extensions add methods such as AsMemoryDomains(), AsStatable() that do the service calling magic. In the client code replace appplicable casts of IMemoryDomains with AsMemoryDomains(), more commits of this nature for the other IEmulatorServices soon to follow
2014-12-05 00:32:29 +00:00
d003be9cda
remove some todos, I decided not to do any of them, it is too pedantic to do them
2014-09-01 19:07:05 +00:00
5ba74c631c
Remove MemoryDomains from IEmulator into a new Interface, IMemoryDomains, Add this interface to existing cores, except null emulator (and removed memory domain related code from it). Refactored EmuHawk for ram tools to use an instance of IMemoryDomains rather than IEmulator, don't expose ram tools unless the core implements IMemoryDomains. Still a few misc todos, and probably some cleanup
2014-09-01 18:43:41 +00:00
ef14f661c0
Hex Editor - properly handle (and not throw exceptions) the display of cheat values in a byte size not equal to the cheat byte size
2014-07-28 00:49:48 +00:00
4fc81991d7
Save cheats even if the cheat dialog was never opened (for instance, if the cheat were added via a game genie dialog or lua)
2014-04-26 17:28:43 +00:00
e4c7110174
Hex Editor - fix issue 150 - exceptions thrown when freezing multi-byte addresses
2014-04-11 16:45:05 +00:00
6d1675e54c
Change UnfreezeAll option on many tools to remove cheats not simply disable them.
2014-03-23 13:21:48 +00:00
75b9b132b6
Hex Editor - make freezing a range of addresses not slow
2014-03-01 18:04:21 +00:00
97bf870b74
Ram Tools - speed up many situations that are slow when freezing/unfreezing addresses with multiple tools open due to sloppy handling of change events
2014-03-01 16:30:06 +00:00
02ea7d360f
some code cleanup
2014-02-22 23:59:52 +00:00
23f7017651
Some code cleanup tinkerings in Client.Common
2014-02-03 20:48:01 +00:00
377ab3b4ea
Fix Hex Editor to show cheat value on frozen addresses, and some fix ups in misc bugs that also contributed to this problem. Note: hex editor still will show some dubious behavior when viewing in one byte size and having cheats in another, that kind of mess will have to be sorted out in another commit
2014-01-01 03:19:08 +00:00
16f7c7fcdc
A round of code cleanup on Rewind and some other misc things in Client.Common
2013-12-30 01:17:11 +00:00
8d680d79a5
Cheats - fix weird behavior caused by the Cheat changed event handler not being wired up on file load
2013-12-21 17:18:08 +00:00
79b2e03d84
Previous commit was a lie, it implemented ICollection instead, therefore change the name of the object to CheatCollection
2013-11-16 16:30:20 +00:00
a4d3e68f66
Implement IList on CheatList object
2013-11-16 16:24:45 +00:00
6f1090c87f
refactor cheatlist and watchlist to use MemoryDomain name indexing
2013-11-06 02:25:27 +00:00
1061add64f
Refactor MemoryDomains in IEmulator, make a MemoryDomainsList object rather than IList<MemoryDomain>, remove MainMemory from IEmulator and make it a property of this new collection object, also add indexing by name. Refactor cores and tools as needed
2013-11-06 02:15:29 +00:00
6f29976e9d
Cheats - fix bug where compare is 0 when clicking a cheat with a null compare value, refactor CheatList.Add() to be upsert logic
2013-11-05 23:14:22 +00:00
92f8f9982c
When adding a cheat, if it already exists, update the existing instead of doing nothing!
2013-11-05 19:53:49 +00:00
4aae8a1311
Cheats - implement editing (oops, it was released without it!), fix value display (was showing the actual ram value, not the cheat's override value), don't flag changes if erroneously adding an existing cheat.
2013-11-05 19:33:06 +00:00
9bbd8a07a6
fix an oops in last commit, and fix adding cheats via Cheats cheat form
2013-11-05 17:07:34 +00:00
5c22d7433c
Cheats - fix insert separator
2013-11-05 16:53:24 +00:00
2da8696b8d
fix some cheat related things I broke when refactoring it
2013-11-05 15:36:18 +00:00
adelikat